| Message ID | 20180801185128.23440-4-maxi.jourdan@wanadoo.fr (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | soc: amlogic: add meson-canvas driver | expand |
Hi Maxime great job! thanks for contributing the patches.. On Thu, Aug 2, 2018 at 2:51 AM, Maxime Jourdan <maxi.jourdan@wanadoo.fr> wrote: > Wrap the canvas node in a syscon node. > > Signed-off-by: Maxime Jourdan <maxi.jourdan@wanadoo.fr> > --- > arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi > index b8dc4dbb391b..d104b9e111fb 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi > @@ -423,6 +423,23 @@ > }; > }; > > + dmcbus: bus@c8838000 { > + compatible = "simple-bus"; > + reg = <0x0 0xc8838000 0x0 0x1000>; > + #address-cells = <2>; > + #size-cells = <2>; > + ranges = <0x0 0x0 0x0 0xc8838000 0x0 0x1000>; > + > + sysctrl_DMC: system-controller@0 { > + compatible = "amlogic,meson-gx-dmc-sysctrl", "syscon", "simple-mfd"; we'd like to drop 'meson-' prefix, so better using "amlogic,gx-dmc-sysctrl", please take a look at the discussion here [1] [1] https://lkml.kernel.org/r/7hk1prmg4w.fsf@baylibre.com > + reg = <0x0 0x0 0x0 0x1000>; > + > + canvas: canvas-provider@0 { > + compatible = "amlogic,meson-canvas"; ditto > + }; > + }; > + }; > + > hiubus: bus@c883c000 { > compatible = "simple-bus"; > reg = <0x0 0xc883c000 0x0 0x2000>; > -- > 2.17.1 > > > _______________________________________________ > linux-amlogic mailing list > linux-amlogic@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-amlogic
>> + sysctrl_DMC: system-controller@0 { >> + compatible = "amlogic,meson-gx-dmc-sysctrl", "syscon", "simple-mfd"; > > we'd like to drop 'meson-' prefix, so better using "amlogic,gx-dmc-sysctrl", > please take a look at the discussion here [1] > > [1] https://lkml.kernel.org/r/7hk1prmg4w.fsf@baylibre.com > On that subject, should I remove the meson keyword from dts only, or from everything ? e.g use amlogic_canvas_* symbols instead of meson_canvas_*, name the source file "amlogic-canvas.c", etc. ?
hi Maxime: On Sun, Aug 5, 2018 at 4:02 AM, Maxime Jourdan <maxi.jourdan@wanadoo.fr> wrote: >>> + sysctrl_DMC: system-controller@0 { >>> + compatible = "amlogic,meson-gx-dmc-sysctrl", "syscon", "simple-mfd"; >> >> we'd like to drop 'meson-' prefix, so better using "amlogic,gx-dmc-sysctrl", >> please take a look at the discussion here [1] >> >> [1] https://lkml.kernel.org/r/7hk1prmg4w.fsf@baylibre.com >> > > On that subject, should I remove the meson keyword from dts only, or > from everything ? > remove the 'meson-' from dts is enough.. > e.g use amlogic_canvas_* symbols instead of meson_canvas_*, name the > source file "amlogic-canvas.c", etc. ? > Actually, I'd suggest to keep using meson_canvas_* in the code for the consistency, unless Kevin or Jerome/Neil has something to say? Yixun
diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi index b8dc4dbb391b..d104b9e111fb 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi @@ -423,6 +423,23 @@ }; }; + dmcbus: bus@c8838000 { + compatible = "simple-bus"; + reg = <0x0 0xc8838000 0x0 0x1000>; + #address-cells = <2>; + #size-cells = <2>; + ranges = <0x0 0x0 0x0 0xc8838000 0x0 0x1000>; + + sysctrl_DMC: system-controller@0 { + compatible = "amlogic,meson-gx-dmc-sysctrl", "syscon", "simple-mfd"; + reg = <0x0 0x0 0x0 0x1000>; + + canvas: canvas-provider@0 { + compatible = "amlogic,meson-canvas"; + }; + }; + }; + hiubus: bus@c883c000 { compatible = "simple-bus"; reg = <0x0 0xc883c000 0x0 0x2000>;
Wrap the canvas node in a syscon node. Signed-off-by: Maxime Jourdan <maxi.jourdan@wanadoo.fr> --- arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)