From patchwork Mon Oct 29 15:13:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 10659387 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2600213B5 for ; Mon, 29 Oct 2018 15:14:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 373551FFB7 for ; Mon, 29 Oct 2018 15:14:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2B86828FAF; Mon, 29 Oct 2018 15:14:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D6ECF1FFB7 for ; Mon, 29 Oct 2018 15:14:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=eZHWkIz117ybVggKQrKlWZcINcepha7iFh39T2rJvKM=; b=XcVEhoGXGpcVmycs3LMyNFpREB aJZ0WmeTZmN8MODl4I5T7CS/UYnwuxzcvWWPoRRxJ1H4cgFJJ1JNA+Psz+vuypeN77LgweRaiumX0 VQofXFj3rAjx6IaFVO9jEPvnbAQULXBkvkQsQWW+lDDiiFrGaenc0nVw582NYkbO5GSkLNgKfR27t 6bpS5+JGvQxcQBQ+AX4kOlwAl/Jxi4ODhIM/HG0fqfp16ZWZIT7YOHSusdupNZxcM/dGpSGITo+um FPSurk32u+m0+53CgOzKnP6hhIvBU1vb/e+aJWRK58VhwlOpv9mnRFN5VYh5LaRrjSjmQJcjHHCUl fVzE9dAg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gH9FQ-0003AG-E3; Mon, 29 Oct 2018 15:14:32 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gH9Ex-0002v9-7b for linux-amlogic@lists.infradead.org; Mon, 29 Oct 2018 15:14:26 +0000 Received: by mail-wr1-x444.google.com with SMTP id x12-v6so9095290wrw.8 for ; Mon, 29 Oct 2018 08:13:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=IVKNCElcTw4O7+BsXJj7w6a+UoV8WRTsqsukzgsta1A=; b=Mg+p9GQ5lAvK9A4y6No9a/ymvvVUBXtA3cpfZVbKj82N5hzU0OQcTMeSs0GhMm3xeE mWOHClwKFhq8wNox68iXnxAEJYsJxMFoIfWLY4uwOEnOCejNILnD7gWYxN3kgW5htqCA MrOtMDLiO7CJgvgQyOSHSfCbSirCWTbB7N4FVlNS7f8QX05aBunaHsd1efMB8uMkCpyh DmmHRaixUP/Dxm4feejY8Amte7gMaO1d6CBZDkb3D5ysQxcfR0zw95cW3ASX4vr3B+2U acT099QeBUY+XSF2tQlu6wpz1twyP30XhW+GtcB9xgGJa6MEBHWH/WAjqIFCbmezawJ9 4NCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=IVKNCElcTw4O7+BsXJj7w6a+UoV8WRTsqsukzgsta1A=; b=Xmi8LA5Pf2619LSxFuhP9wdckmqR2a66TFXBbjlkDwZpmsF2Jti5PD2JhygTc2ct8S gDk6wTs9uFowsQEDxUNur85QnPAqh/5QRJT0PtlaN+PI8OVsYN7m3gHAEQExBbcthsdc AX7RwhVS8lRrrZO7jGHeG4vvVaa+cAVMdWSJVDzX4fcKYMh84pqWvnX4zS9Soih6VB0o ChEJCvNueHY5AODPrrEbOZRUm39ZOG+ZlEi+R81hhrCS0o1sE/3avN/PIgHGkK1QiVF6 tmCYsza+LL4m/+ISGkjI3N1ekS1TWiPwc8vuug8DOdpWVjUWYnZ2/ZHnPWlbLDOi5Hk7 t8gw== X-Gm-Message-State: AGRZ1gLHfs0bRGb6tZwlVVIJAEZwSua5eKKzTmQIrhimf9rjOM8oFu/r tMxLZAHdCDbUdGz41QIW3LXDxzD8CYQ= X-Google-Smtp-Source: AJdET5fLzHpcK+2A+4mFLgf+Wm+tfRHGE/RLD6/RtL2yhacmXoHF5pt+cAnexoLfunULXtTSpGKRCA== X-Received: by 2002:a5d:51cb:: with SMTP id n11-v6mr3931700wrv.121.1540826031334; Mon, 29 Oct 2018 08:13:51 -0700 (PDT) Received: from boomer.baylibre.local ([90.63.244.31]) by smtp.googlemail.com with ESMTPSA id i7-v6sm23045236wmd.41.2018.10.29.08.13.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 Oct 2018 08:13:50 -0700 (PDT) From: Jerome Brunet To: Linus Walleij , Kevin Hilman , Carlo Caione , Martin Blumenstingl Subject: [PATCH 3/4] pinctrl: meson: fix meson8 ao pull register bits Date: Mon, 29 Oct 2018 16:13:39 +0100 Message-Id: <20181029151340.9087-4-jbrunet@baylibre.com> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20181029151340.9087-1-jbrunet@baylibre.com> References: <20181029151340.9087-1-jbrunet@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181029_081403_322742_8E3A5AAC X-CRM114-Status: GOOD ( 12.43 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-gpio@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, Jerome Brunet MIME-Version: 1.0 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+patchwork-linux-amlogic=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP AO pull register definition is inverted between pull (up/down) and pull enable. Fixing this allows to properly apply bias setting through pinconf Fixes: 6ac730951104 ("pinctrl: add driver for Amlogic Meson SoCs") Signed-off-by: Jerome Brunet --- drivers/pinctrl/meson/pinctrl-meson8.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/meson/pinctrl-meson8.c b/drivers/pinctrl/meson/pinctrl-meson8.c index c6d79315218f..86466173114d 100644 --- a/drivers/pinctrl/meson/pinctrl-meson8.c +++ b/drivers/pinctrl/meson/pinctrl-meson8.c @@ -1053,7 +1053,7 @@ static struct meson_bank meson8_cbus_banks[] = { static struct meson_bank meson8_aobus_banks[] = { /* name first last irq pullen pull dir out in */ - BANK("AO", GPIOAO_0, GPIO_TEST_N, 0, 13, 0, 0, 0, 16, 0, 0, 0, 16, 1, 0), + BANK("AO", GPIOAO_0, GPIO_TEST_N, 0, 13, 0, 16, 0, 0, 0, 0, 0, 16, 1, 0), }; static struct meson_pinctrl_data meson8_cbus_pinctrl_data = {