From patchwork Thu Nov 8 10:44:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 10673991 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D3AD917D4 for ; Thu, 8 Nov 2018 10:45:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C11C62CE3F for ; Thu, 8 Nov 2018 10:45:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B53E52CF65; Thu, 8 Nov 2018 10:45:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 5F8CE2CF5D for ; Thu, 8 Nov 2018 10:45:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=61rnbZxJC7zfl9e7wn5ss23GBwM6yRZFI5t3xWp7NiM=; b=QmRgbZdZTgelUd wW9Fi7L7qIGtFYghrQFUvq69jPqlL2+klSrbMJToqJw08V3U07ry9ZIm3VKcqrJy5/qljN+h8FBKM O2GplRyocPjmlFOHpbZNlGr7hnLoNhdd4a3yEuvy3bvKr2XDBSgMwAq3qA9mIm/CeFgX71r6QIsNj l5teaQrIxsxVsDPF07WDSsdPgWCJKq85OS0VTpRneSaf/1FIrHarKDpR/v2hGYg1AY3IczkYFPnOH Agkq6IobbkNtv6VEy18lYczbSn6UIncds9y0GyRYXXrK5X+imSHvKkvLWfp8V+pmyvfgo53bEhzfc 64uNGKSG9mp1Fu49JlIA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gKhoI-0000lp-Px; Thu, 08 Nov 2018 10:45:14 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gKho8-0007fc-QB for linux-amlogic@lists.infradead.org; Thu, 08 Nov 2018 10:45:11 +0000 Received: by mail-wr1-x444.google.com with SMTP id 74-v6so20673195wrb.13 for ; Thu, 08 Nov 2018 02:44:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/0smNNuQStEDVjeoyozdvGvGeLKrZskOlohutZmWEJk=; b=LfGhrjBg6DMcn4cNo7AmfB7y//7qkdqB/koH3La2fS7kJps7k5GaW/9bD9MZgbWQU7 aZvp5/sM1/WgIavguv/5jveYy/LOUVG7lPvKDH67N98K7U99evAlWGvZcsKg9lBl1NeI HW3RnL0ecd7qfFGNA0KsdJERPEScsPpx2BSS1UsllUYz8OykEo0T8nIeh1Q1zkFuKgoq 83R8PIHSIz7w3xzHdcYynfL/cW4xRHTPiSy8U5RsOO8HNjtqThKMZz7j/yyDFvGJMeqn OZRgVsWJCC+c7cSrjP737gwgkZvYuZMcf4/0BO2R9FDRe6E6/tZ5w2btPkHO89Aw+4Gq coLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/0smNNuQStEDVjeoyozdvGvGeLKrZskOlohutZmWEJk=; b=BLZ1ZWoWXwlX0ffNjmsL/kkF1W1UQXBNtfO7jent/sGjSz7GD1p2BDL/m/ZeQTtMu5 3LQyEuFd8kpu/tXP21x53K1UCTwX2tr2GvrppueLVW4oWYxmzU/OcW4udKv0LabkzwX6 Y1yvqxFHQ+i7iYJnUf3wh/tPlTWGWpIzRfZCEQJFK4lGKU1pv3q4f3KZCuBRrPCUxMGs og+Kd70K7+kXN33cUYyWFYs8ODAKE7+6A3ZVPYD7xWP/RVcPDue3Ln1r61gXzdQmQMuy 690m42Xwr3IkbwTpBb93CpE0P55utzaRsQO5EAxVSimCBlvgcoNMqBGQfQJoSoWa1RWE FZyw== X-Gm-Message-State: AGRZ1gLZrsLCoBgPpozyUprAJvIBkxFI5U1GPNO02tSh9dABFogqbOQj YpZEukhrPaOIlwMZXj8v4nnekw== X-Google-Smtp-Source: AJdET5dEMrRepd9CuR7mCf76zp+beIvWMsXF1WL/GKf0BrOnP39UxiEfE9xSgTDWNMEc9nQD68wQMg== X-Received: by 2002:adf:84a4:: with SMTP id 33-v6mr3645430wrg.191.1541673892133; Thu, 08 Nov 2018 02:44:52 -0800 (PST) Received: from boomer.local ([90.63.244.31]) by smtp.googlemail.com with ESMTPSA id o130-v6sm5884800wmd.11.2018.11.08.02.44.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 08 Nov 2018 02:44:51 -0800 (PST) From: Jerome Brunet To: Kevin Hilman , Carlo Caione Subject: [PATCH 2/4] arm64: dts: meson: disable pad bias for mmc pinmuxes Date: Thu, 8 Nov 2018 11:44:24 +0100 Message-Id: <20181108104426.1877-3-jbrunet@baylibre.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181108104426.1877-1-jbrunet@baylibre.com> References: <20181108104426.1877-1-jbrunet@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181108_024504_861310_2EE445C9 X-CRM114-Status: GOOD ( 10.20 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, Jerome Brunet Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+patchwork-linux-amlogic=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP In some cases (such as a boot from SPI) the bootloader or the ROM code may leave a bias pull-down on the mmc pins. If so the MMC will fail during the initialisation. Explicitly disabling the pinmux solves the problem. Signed-off-by: Jerome Brunet --- arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 2 ++ arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 4 ++++ arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 4 ++++ 3 files changed, 10 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi index e86f5f721f8f..bc427b9d3e13 100644 --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi @@ -273,6 +273,7 @@ "emmc_cmd", "emmc_ds"; function = "emmc"; + bias-disable; }; }; @@ -503,6 +504,7 @@ "sdio_cmd", "sdio_clk"; function = "sdio"; + bias-disable; }; }; diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi index 1cb8e7e0d0da..32ef82321340 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi @@ -363,6 +363,7 @@ "emmc_cmd", "emmc_clk"; function = "emmc"; + bias-disable; }; }; @@ -370,6 +371,7 @@ mux { groups = "emmc_ds"; function = "emmc"; + bias-disable; }; }; @@ -416,6 +418,7 @@ "sdcard_cmd", "sdcard_clk"; function = "sdcard"; + bias-disable; }; }; @@ -436,6 +439,7 @@ "sdio_cmd", "sdio_clk"; function = "sdio"; + bias-disable; }; }; diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi index 7cfee40d89e9..cfeec5579726 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi @@ -310,6 +310,7 @@ "emmc_cmd", "emmc_clk"; function = "emmc"; + bias-disable; }; }; @@ -317,6 +318,7 @@ mux { groups = "emmc_ds"; function = "emmc"; + bias-disable; }; }; @@ -363,6 +365,7 @@ "sdcard_cmd", "sdcard_clk"; function = "sdcard"; + bias-disable; }; }; @@ -383,6 +386,7 @@ "sdio_cmd", "sdio_clk"; function = "sdio"; + bias-disable; }; };