From patchwork Fri Nov 9 14:04:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 10675989 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 71F9C13B0 for ; Fri, 9 Nov 2018 14:05:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 603322EA87 for ; Fri, 9 Nov 2018 14:05:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 54D392EA91; Fri, 9 Nov 2018 14:05:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 308902EA94 for ; Fri, 9 Nov 2018 14:05:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=61rnbZxJC7zfl9e7wn5ss23GBwM6yRZFI5t3xWp7NiM=; b=O485tMGhn/e/ae sTjuNlsptiZOhza49ulWhugG00QO12Dh0KoeuR08hFhPMGqo18GZSOL2Gjf/kcEu8tdf//Zj9btQX 9gxTBYXRS6Y/Gv41ocPpbfj58gc5rgcsh8c+epIVDPMvQ/hOj0s/2olxMP4GyMyEN8lSkuQmsLO79 TdaieqpvZjHPm+Cd+qwzuVWTztibGg/rB9KtXPUAJ6vZ6i16MENT5ypO7m9w1FKt8gjaaELgldRKF fVF+6Tb+OxN3WLsKkabUoffGhT50PQopAxbBiQvH2GD6KhxWZuAG14VOjJwxMGKAruXzOXaDSkBcP 7ZCU10C7JAUL4WPv5yng==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gL7PT-0001Rn-Sg; Fri, 09 Nov 2018 14:05:19 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gL7PJ-0008PD-8s for linux-amlogic@lists.infradead.org; Fri, 09 Nov 2018 14:05:17 +0000 Received: by mail-wm1-x341.google.com with SMTP id b203-v6so2046615wme.5 for ; Fri, 09 Nov 2018 06:05:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/0smNNuQStEDVjeoyozdvGvGeLKrZskOlohutZmWEJk=; b=f+mSw5cpUaZcnpAq2GahJvGFTV0HHsWqEo3+scU7rhlulqlm+RgWgTsrIoUumxjtwJ BL835mB9Z3wcjUdARRVKEhU/ad8gPzgQ5WHiM7JpxUxKEzTYrefrjWJ0+31+V4+NXByI D9AWo9f1DgmdORxhd+5zRfFyRZPyXDLuG5l/9wuDvUeXpWebD7Yi/dpRswmq60NYTdYQ yff8hQdStJW0TTFuIk6TI2+wQC41fMtldAEZtwLjadENw/In3kHmZPZFUS6w+e/llg1o LR/mao8vIVdIoKkv0hY/WvxFgf84FEjEchkr2itYrD4tGsWPOywHQotzp2si8h58Q6JM thjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/0smNNuQStEDVjeoyozdvGvGeLKrZskOlohutZmWEJk=; b=jvHgmpMdqz3svszzzIdZAiu7XvoyfWgeGjIKEk1GWm6yAfM+/bMU4LwRIcFgq/aV8g 9uT2bOc8F4yr33OEcNSDNyPQvVOzdiMj2fQihyW2P6P3fa7CNdWSvMGHGBAEYcuvbYJq 4MK4RDe3EINvhIV+h9o6deHUfUkQ6i2Jae+W1DVr3P0joms17N7i4OxPLx6uWYEB2z/1 YBIdLAVEQHPOQEhw68NZQxgZlkRLm2bKUExup7ZGZzgm18rvSyhOTdHaZVKVv6edUoj1 BSPCEOfHwWY+tKvWRK5ReeQx6CpBNdF7uqRSDTWQv0le9GW8JyDO9QhSoX8wpW/ULfYd AgZQ== X-Gm-Message-State: AGRZ1gIehVMglHxz4a9hRTwX2DbDR4l2mqz9swaPca4EfBIOlRAu+Ryj G0ARIo931WTJFowBIx5aSFvpVQ== X-Google-Smtp-Source: AJdET5frIafgg314lxQPKgEk/NrkBlWJcmor7+hy0LDIQrNcxYe/53o9PmcJmnTS0Uylwr5SGs1vpQ== X-Received: by 2002:a1c:e088:: with SMTP id x130-v6mr4720487wmg.6.1541772298896; Fri, 09 Nov 2018 06:04:58 -0800 (PST) Received: from boomer.baylibre.com ([2a01:e34:eeb6:4690:106b:bae3:31ed:7561]) by smtp.googlemail.com with ESMTPSA id w18-v6sm15964987wrn.66.2018.11.09.06.04.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 09 Nov 2018 06:04:58 -0800 (PST) From: Jerome Brunet To: Kevin Hilman , Carlo Caione Subject: [PATCH v2 2/4] arm64: dts: meson: disable pad bias for mmc pinmuxes Date: Fri, 9 Nov 2018 15:04:43 +0100 Message-Id: <20181109140445.17795-3-jbrunet@baylibre.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181109140445.17795-1-jbrunet@baylibre.com> References: <20181109140445.17795-1-jbrunet@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181109_060509_322272_E50F3241 X-CRM114-Status: GOOD ( 10.54 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, Jerome Brunet Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+patchwork-linux-amlogic=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP In some cases (such as a boot from SPI) the bootloader or the ROM code may leave a bias pull-down on the mmc pins. If so the MMC will fail during the initialisation. Explicitly disabling the pinmux solves the problem. Signed-off-by: Jerome Brunet --- arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 2 ++ arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 4 ++++ arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 4 ++++ 3 files changed, 10 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi index e86f5f721f8f..bc427b9d3e13 100644 --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi @@ -273,6 +273,7 @@ "emmc_cmd", "emmc_ds"; function = "emmc"; + bias-disable; }; }; @@ -503,6 +504,7 @@ "sdio_cmd", "sdio_clk"; function = "sdio"; + bias-disable; }; }; diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi index 1cb8e7e0d0da..32ef82321340 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi @@ -363,6 +363,7 @@ "emmc_cmd", "emmc_clk"; function = "emmc"; + bias-disable; }; }; @@ -370,6 +371,7 @@ mux { groups = "emmc_ds"; function = "emmc"; + bias-disable; }; }; @@ -416,6 +418,7 @@ "sdcard_cmd", "sdcard_clk"; function = "sdcard"; + bias-disable; }; }; @@ -436,6 +439,7 @@ "sdio_cmd", "sdio_clk"; function = "sdio"; + bias-disable; }; }; diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi index 7cfee40d89e9..cfeec5579726 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi @@ -310,6 +310,7 @@ "emmc_cmd", "emmc_clk"; function = "emmc"; + bias-disable; }; }; @@ -317,6 +318,7 @@ mux { groups = "emmc_ds"; function = "emmc"; + bias-disable; }; }; @@ -363,6 +365,7 @@ "sdcard_cmd", "sdcard_clk"; function = "sdcard"; + bias-disable; }; }; @@ -383,6 +386,7 @@ "sdio_cmd", "sdio_clk"; function = "sdio"; + bias-disable; }; };