From patchwork Sun Jan 13 18:18:08 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 10761375 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DC63613BF for ; Sun, 13 Jan 2019 18:19:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CBAC228793 for ; Sun, 13 Jan 2019 18:19:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BCB40287C1; Sun, 13 Jan 2019 18:19:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 14E4128793 for ; Sun, 13 Jan 2019 18:19:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yyOiPX4MGxfZKz7Hqr7d1J4pCHgKVlm5A9WxzgmXJzQ=; b=M9VdTCP7ajDWm9 sNZTTBgEXvsZ6eCxN72l7QLOr6Jn4i8IIUjFLQfbz3kDubou6RRETH74M9rRU+w+S/v8LdzmXtU3i WiedK2we9TEIM1JjDOpIfEvFF2z2GVKaeiVQKXv20arBOOyJBOtvttti9rnTJwNQvosRVn1Adk3Y2 6OZ1bmUeM6RWplokPKqRq4L6CfBGQoSIopBzoOo5L11dAHfKWtIPfY5/zhovh4tdHKNNXgohL07Zb vEkr1V07tN+evNAtr/WTuFN/sHTjwuHGRL6m2o0hSMYsJNGkr5xAAcXvNDLzX6/uVus4iVda80VjB qmc+zDem0/eczVIxn8bg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gikLb-0000GX-Mk; Sun, 13 Jan 2019 18:18:59 +0000 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gikL7-0008EK-A0; Sun, 13 Jan 2019 18:18:30 +0000 Received: by mail-pg1-x544.google.com with SMTP id w6so8483176pgl.6; Sun, 13 Jan 2019 10:18:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qh1Vvz9nFt0zbkJ37Q8bDQfJww+y6baj77fJu8mv98I=; b=swFYHZlfdSg6jCEkobODwgnPuE6nEjJPb3gCppvr+w/wWhlYMhNhkpdli0TsuPs1xU LiPfvXrWVD1YZenmBCRbBIUcU1NlxKLj6noaSmaDDwGEay1PQS82tug/nRt3b5ySrrib JhQKHQI43TFPHc26H7D99Jyos/romqrC0+XSFier8LOeAasMYNDbUDjCNhVa6x0dow96 3aeCwoGWgnwlVFQ8xb/nTEd5B0kfJ3pq8t2W8BO+waZg/pvzoQ916HYusyXU6idwrx8q nY1OMC/wh0r7BpKC1hLlyPmx4pJFx0r7h8epi8w8h6HnDQHHTO8nrzvp3eqbUvvOv/ey ycKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qh1Vvz9nFt0zbkJ37Q8bDQfJww+y6baj77fJu8mv98I=; b=mXZvWUDgKcJr4UlN3cFDGRsK3XSu/ZGI5G03H7F0w88viFQgC5FRRiZiTzMGI8oi3F jy12gHjZc5GgDInNlpcrmsQx4d+R8x0ZnCEWHwutnpTpekTYtX7+qrAR0zx7k0fkDfEf jOH1iOh93i8dJjK+q0yp0p70xyqeBB6H06kdGMlYQYiQlIl42DR+EOIE0dFtVB5Wx52w jxkgbx7gy79AUCzfMI7qMW1EKb6OtuWmd1Dq/0Jh4onn5Rh/5//wJPcvs5PuO5tESSCk MN+m+fCtn0lDSWSb7kYjnjDh2utFUJSxGmi8YigRaQ7v3gVUEYcXUnAOXZsLZ91cvMVv EtuA== X-Gm-Message-State: AJcUukfNJWv4gnheul3cMi3j9TjEqPP6hZK7+5X/U2IhM40jL9fRN1Gz hYXNLcZhJQkNYUMoDBqBcZ4= X-Google-Smtp-Source: ALg8bN5zH9qH94ZZJjYOfVGfLt2TvQIJ/wKbeMQOEPYGeoGwZN29QJ8K9d3ZnoCFHJQyGixOX2BN9A== X-Received: by 2002:a63:9b11:: with SMTP id r17mr20476965pgd.416.1547403508296; Sun, 13 Jan 2019 10:18:28 -0800 (PST) Received: from localhost.localdomain ([103.51.74.105]) by smtp.gmail.com with ESMTPSA id i193sm157504416pgc.22.2019.01.13.10.18.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 13 Jan 2019 10:18:27 -0800 (PST) From: Anand Moon To: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] ARM: dts: meson8b: odroidc1: Fix usb phy regulator power failed warning Date: Sun, 13 Jan 2019 18:18:08 +0000 Message-Id: <20190113181808.5768-2-linux.amoon@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190113181808.5768-1-linux.amoon@gmail.com> References: <20190113181808.5768-1-linux.amoon@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190113_101829_356516_09F56E9F X-CRM114-Status: GOOD ( 11.79 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Martin Blumenstingl , Kevin Hilman , Rob Herring , Emiliano Ingrassia , Jerome Brunet Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+patchwork-linux-amlogic=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Override the dr_mode from "host" to "peripheral" for dwc2 usb_phy0->usb0 initialization of OTG Micro-B type. Changes fix the below warning for phy poweron failed --> -22 This fix the initialization of c9040000.usb phy. [ 1.639706] phy phy-c1108800.phy.0: USB ID detect failed! [ 1.643850] phy phy-c1108800.phy.0: phy poweron failed --> -22 [ 1.649706] ------------[ cut here ]------------ [ 1.654273] WARNING: CPU: 0 PID: 29 at drivers/regulator/core.c:2054 _regulator_put.part.8+0xf8/0xfc [ 1.663400] Modules linked in: [ 1.666439] CPU: 0 PID: 29 Comm: kworker/0:1 Not tainted 4.20.0-xc1ml #11 [ 1.673192] Hardware name: Amlogic Meson platform [ 1.677894] Workqueue: events deferred_probe_work_func [ 1.683027] [] (unwind_backtrace) from [] (show_stack+0x10/0x14) [ 1.690746] [] (show_stack) from [] (dump_stack+0x8c/0xa0) [ 1.697953] [] (dump_stack) from [] (__warn.part.3+0xbc/0xd8) [ 1.705418] [] (__warn.part.3) from [] (warn_slowpath_null+0x44/0x4c) [ 1.713579] [] (warn_slowpath_null) from [] (_regulator_put.part.8+0xf8/0xfc) [ 1.722437] [] (_regulator_put.part.8) from [] (regulator_put+0x28/0x38) [ 1.730859] [] (regulator_put) from [] (regulator_bulk_free+0x28/0x38) [ 1.739112] [] (regulator_bulk_free) from [] (release_nodes+0x1bc/0x200) [ 1.747537] [] (release_nodes) from [] (really_probe+0x110/0x2cc) [ 1.755350] [] (really_probe) from [] (driver_probe_device+0x60/0x16c) [ 1.763599] [] (driver_probe_device) from [] (bus_for_each_drv+0x80/0xc4) [ 1.772110] [] (bus_for_each_drv) from [] (__device_attach+0xd0/0x138) [ 1.780359] [] (__device_attach) from [] (bus_probe_device+0x84/0x8c) [ 1.788522] [] (bus_probe_device) from [] (deferred_probe_work_func+0x60/0x8c) [ 1.797470] [] (deferred_probe_work_func) from [] (process_one_work+0x218/0x504) [ 1.806585] [] (process_one_work) from [] (worker_thread+0x2a8/0x5bc) [ 1.814748] [] (worker_thread) from [] (kthread+0x14c/0x154) [ 1.822128] [] (kthread) from [] (ret_from_fork+0x14/0x2c) [ 1.829331] Exception stack(0xee0ebfb0 to 0xee0ebff8) [ 1.834369] bfa0: 00000000 00000000 00000000 00000000 [ 1.842534] bfc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 [ 1.850695] bfe0: 00000000 00000000 00000000 00000000 00000013 00000000 [ 1.857311] ---[ end trace e28bbc26874282a4 ]--- [ 1.861984] ------------[ cut here ]------------ [ 1.866524] WARNING: CPU: 0 PID: 29 at drivers/regulator/core.c:2054 _regulator_put.part.8+0xf8/0xfc [ 1.875629] Modules linked in: [ 1.878658] CPU: 0 PID: 29 Comm: kworker/0:1 Tainted: GW 4.20.0-xc1ml #11 [ 1.886817] Hardware name: Amlogic Meson platform [ 1.891513] Workqueue: events deferred_probe_work_func [ 1.896641] [] (unwind_backtrace) from [] (show_stack+0x10/0x14) [ 1.904366] [] (show_stack) from [] (dump_stack+0x8c/0xa0) [ 1.911573] [] (dump_stack) from [] (__warn.part.3+0xbc/0xd8) [ 1.919041] [] (__warn.part.3) from [] (warn_slowpath_null+0x44/0x4c) [ 1.927203] [] (warn_slowpath_null) from [] (_regulator_put.part.8+0xf8/0xfc) [ 1.936060] [] (_regulator_put.part.8) from [] (regulator_put+0x28/0x38) [ 1.944483] [] (regulator_put) from [] (regulator_bulk_free+0x28/0x38) [ 1.952734] [] (regulator_bulk_free) from [] (release_nodes+0x1bc/0x200) [ 1.961159] [] (release_nodes) from [] (really_probe+0x110/0x2cc) [ 1.968974] [] (really_probe) from [] (driver_probe_device+0x60/0x16c) [ 1.977224] [] (driver_probe_device) from [] (bus_for_each_drv+0x80/0xc4) [ 1.985734] [] (bus_for_each_drv) from [] (__device_attach+0xd0/0x138) [ 1.993984] [] (__device_attach) from [] (bus_probe_device+0x84/0x8c) [ 2.002147] [] (bus_probe_device) from [] (deferred_probe_work_func+0x60/0x8c) [ 2.011092] [] (deferred_probe_work_func) from [] (process_one_work+0x218/0x504) [ 2.020209] [] (process_one_work) from [] (worker_thread+0x2a8/0x5bc) [ 2.028371] [] (worker_thread) from [] (kthread+0x14c/0x154) [ 2.035752] [] (kthread) from [] (ret_from_fork+0x14/0x2c) [ 2.042955] Exception stack(0xee0ebfb0 to 0xee0ebff8) [ 2.047993] bfa0: 00000000 00000000 00000000 00000000 [ 2.056158] bfc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 [ 2.064320] bfe0: 00000000 00000000 00000000 00000000 00000013 00000000 [ 2.070934] ---[ end trace e28bbc26874282a5 ]--- Cc: Martin Blumenstingl Cc: Jerome Brunet Cc: Neil Armstrong Signed-off-by: Anand Moon --- Rebased on Kevin's amlogic/v5.0/fixes branch Note the warning is not getting produced on the latest kernel. --- arch/arm/boot/dts/meson8b-odroidc1.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/meson8b-odroidc1.dts b/arch/arm/boot/dts/meson8b-odroidc1.dts index a49a8509b288..9d7f725cfe35 100644 --- a/arch/arm/boot/dts/meson8b-odroidc1.dts +++ b/arch/arm/boot/dts/meson8b-odroidc1.dts @@ -318,6 +318,7 @@ &usb0 { status = "okay"; + dr_mode = "peripheral"; }; &usb1 {