| Message ID | 20190527132200.17377-2-narmstrong@baylibre.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 0afd24c2fb61bd5163bab08ea1ee54d60d3ea37e |
| Headers | show |
| Series | arm64: meson-gx: misc fixes | expand |
On Mon, May 27, 2019 at 3:22 PM Neil Armstrong <narmstrong@baylibre.com> wrote: > > From: Christian Hewitt <christianshewitt@gmail.com> > > Fix DTC warnings: > > meson-gxm-khadas-vim2.dtb: Warning (avoid_unnecessary_addr_size): > /gpio-keys-polled: unnecessary #address-cells/#size-cells > without "ranges" or child "reg" property > > Fixes: b8b74dda3908 ("ARM64: dts: meson-gxm: Add support for Khadas VIM2") > Suggested-by: Christian Hewitt <christianshewitt@gmail.com> > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> as well as: Tested-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > --- > arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 4 +--- there are more boards with the same "problem" out there we should clean these up at some point as well Martin
Neil Armstrong <narmstrong@baylibre.com> writes: > From: Christian Hewitt <christianshewitt@gmail.com> > > Fix DTC warnings: > > meson-gxm-khadas-vim2.dtb: Warning (avoid_unnecessary_addr_size): > /gpio-keys-polled: unnecessary #address-cells/#size-cells > without "ranges" or child "reg" property > > Fixes: b8b74dda3908 ("ARM64: dts: meson-gxm: Add support for Khadas VIM2") > Suggested-by: Christian Hewitt <christianshewitt@gmail.com> > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> This patch is missing a S-o-B from the author (Christian?) The From, Suggested-by and Signed-off-by send mixed messages. Please clarify if if this is missing a signoff from Christian or if the author is Neil. Thanks, Kevin
On 06/06/2019 22:00, Kevin Hilman wrote: > Neil Armstrong <narmstrong@baylibre.com> writes: > >> From: Christian Hewitt <christianshewitt@gmail.com> >> >> Fix DTC warnings: >> >> meson-gxm-khadas-vim2.dtb: Warning (avoid_unnecessary_addr_size): >> /gpio-keys-polled: unnecessary #address-cells/#size-cells >> without "ranges" or child "reg" property >> >> Fixes: b8b74dda3908 ("ARM64: dts: meson-gxm: Add support for Khadas VIM2") >> Suggested-by: Christian Hewitt <christianshewitt@gmail.com> >> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > > This patch is missing a S-o-B from the author (Christian?) > > The From, Suggested-by and Signed-off-by send mixed messages. Please > clarify if if this is missing a signoff from Christian or if the author > is Neil. > > Thanks, > > Kevin > The author is Christian Hewitt <christianshewitt@gmail.com> so s/Suggested-by/Signed-off-by/ Do you need a resend ? Neil
Neil Armstrong <narmstrong@baylibre.com> writes: > On 06/06/2019 22:00, Kevin Hilman wrote: >> Neil Armstrong <narmstrong@baylibre.com> writes: >> >>> From: Christian Hewitt <christianshewitt@gmail.com> >>> >>> Fix DTC warnings: >>> >>> meson-gxm-khadas-vim2.dtb: Warning (avoid_unnecessary_addr_size): >>> /gpio-keys-polled: unnecessary #address-cells/#size-cells >>> without "ranges" or child "reg" property >>> >>> Fixes: b8b74dda3908 ("ARM64: dts: meson-gxm: Add support for Khadas VIM2") >>> Suggested-by: Christian Hewitt <christianshewitt@gmail.com> >>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> >> >> This patch is missing a S-o-B from the author (Christian?) >> >> The From, Suggested-by and Signed-off-by send mixed messages. Please >> clarify if if this is missing a signoff from Christian or if the author >> is Neil. >> >> Thanks, >> >> Kevin >> > > The author is Christian Hewitt <christianshewitt@gmail.com> > > so s/Suggested-by/Signed-off-by/ > > Do you need a resend ? No need, I'll fix up locally. Thanks for clarifying, Kevin
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts index c5f3f90a42ae..25079501f2bb 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts @@ -63,11 +63,9 @@ gpio-keys-polled { compatible = "gpio-keys-polled"; - #address-cells = <1>; - #size-cells = <0>; poll-interval = <100>; - button@0 { + power-button { label = "power"; linux,code = <KEY_POWER>; gpios = <&gpio_ao GPIOAO_2 GPIO_ACTIVE_LOW>;