| Message ID | 20190828202723.1145-2-linux.amoon@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Odroid c2 missing regulator linking | expand |
On Wed, Aug 28, 2019 at 10:27 PM Anand Moon <linux.amoon@gmail.com> wrote: > > As per shematics VDDIO_AO18, VDDIO_AO3V3/VDD3V3 DDR3_1V5/DDR_VDDC: typo: "schematics" > fixed regulator output which is supplied by P5V0. > > Rename vcc3v3 regulator node to vddio_ao3v3 as per shematics. typo: "schematics" according to the schematics there's both: - VDDIO_AO3V3 - VCC3V3 (which is turned on by VDDIO_AO3V3, see [0]) > Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > Cc: Jerome Brunet <jbrunet@baylibre.com> > Cc: Neil Armstrong <narmstrong@baylibre.com> > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > --- > .../boot/dts/amlogic/meson-gxbb-odroidc2.dts | 29 +++++++++++++++++-- > 1 file changed, 26 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts > index 792698a60a12..98e742bf44c1 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts > +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts > @@ -104,11 +104,34 @@ > regulator-max-microvolt = <1800000>; > }; > > - vcc3v3: regulator-vcc3v3 { > + vddio_ao1v8: regulator-vddio-ao1v8 { > compatible = "regulator-fixed"; > - regulator-name = "VCC3V3"; > + regulator-name = "VDDIO_AO1V8"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-always-on; > + /* U17 RT9179GB */ > + vin-supply = <&p5v0>; > + }; > + > + vddio_ao3v3: regulator-vddio-ao3v3 { > + compatible = "regulator-fixed"; > + regulator-name = "VDDIO_AO3V3"; > regulator-min-microvolt = <3300000>; > regulator-max-microvolt = <3300000>; > + regulator-always-on; > + /* U11 MP2161GJ-C499 */ > + vin-supply = <&p5v0>; > + }; > + > + vddc_ddr: regulator-vddc-ddr { > + compatible = "regulator-fixed"; > + regulator-name = "DDR_VDDC"; personally I would call this (along with the node name and alias) DDR3_1V5 odroid-c2_rev0.1_20150930.pdf shows that DDR3_1V5 and DDR_VDDC are both the same. however, the DDR_VDDC signal name is not used by any component in the datasheet > + regulator-min-microvolt = <1500000>; > + regulator-max-microvolt = <1500000>; > + regulator-always-on; > + /* U15 MP2161GJ-C499 */ > + vin-supply = <&p5v0>; > }; > > emmc_pwrseq: emmc-pwrseq { > @@ -301,7 +324,7 @@ > mmc-hs200-1_8v; > > mmc-pwrseq = <&emmc_pwrseq>; > - vmmc-supply = <&vcc3v3>; > + vmmc-supply = <&vddio_ao3v3>; odroid-c2_rev0.1_20150930.pdf uses VCC3V3 as supply Martin
Hi Martin, Thanks for your review comments. Their have been some revision changes in S905 Odroid Schematics. [0] https://dn.odroid.com/S905/Schematic/ Well I have make my changes based on old odroid-c2_rev0.2_20151218.pdf On Sun, 1 Sep 2019 at 17:07, Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote: > > On Wed, Aug 28, 2019 at 10:27 PM Anand Moon <linux.amoon@gmail.com> wrote: > > > > As per shematics VDDIO_AO18, VDDIO_AO3V3/VDD3V3 DDR3_1V5/DDR_VDDC: > typo: "schematics" > OK. next time will run spell check before I send these changes. > > fixed regulator output which is supplied by P5V0. > > > > Rename vcc3v3 regulator node to vddio_ao3v3 as per shematics. > typo: "schematics" Ok. > > according to the schematics there's both: > - VDDIO_AO3V3 > - VCC3V3 (which is turned on by VDDIO_AO3V3, see [0]) > From the schematics it seams same. VDDIO_AO3V3---DMG340LSQN4 (Q4)---VCC3V3 But this name change was done to link TFLASH_VDD_EN to TFLASH_VDD for eMMC VDDIO_AO3V3-----TFLASH_VDD using TFLASH_VDD_EN gpio pin. Well I have tested this changes on eMMC module. > > Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > > Cc: Jerome Brunet <jbrunet@baylibre.com> > > Cc: Neil Armstrong <narmstrong@baylibre.com> > > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > > --- > > .../boot/dts/amlogic/meson-gxbb-odroidc2.dts | 29 +++++++++++++++++-- > > 1 file changed, 26 insertions(+), 3 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts > > index 792698a60a12..98e742bf44c1 100644 > > --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts > > +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts > > @@ -104,11 +104,34 @@ > > regulator-max-microvolt = <1800000>; > > }; > > > > - vcc3v3: regulator-vcc3v3 { > > + vddio_ao1v8: regulator-vddio-ao1v8 { > > compatible = "regulator-fixed"; > > - regulator-name = "VCC3V3"; > > + regulator-name = "VDDIO_AO1V8"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <1800000>; > > + regulator-always-on; > > + /* U17 RT9179GB */ > > + vin-supply = <&p5v0>; > > + }; > > + > > + vddio_ao3v3: regulator-vddio-ao3v3 { > > + compatible = "regulator-fixed"; > > + regulator-name = "VDDIO_AO3V3"; > > regulator-min-microvolt = <3300000>; > > regulator-max-microvolt = <3300000>; > > + regulator-always-on; > > + /* U11 MP2161GJ-C499 */ > > + vin-supply = <&p5v0>; > > + }; > > + > > + vddc_ddr: regulator-vddc-ddr { > > + compatible = "regulator-fixed"; > > + regulator-name = "DDR_VDDC"; > personally I would call this (along with the node name and alias) DDR3_1V5 > odroid-c2_rev0.1_20150930.pdf shows that DDR3_1V5 and DDR_VDDC are > both the same. however, the DDR_VDDC signal name is not used by any > component in the datasheet Ok Thanks I will change this to DDR3_1V5 as per the datasheet. > > > + regulator-min-microvolt = <1500000>; > > + regulator-max-microvolt = <1500000>; > > + regulator-always-on; > > + /* U15 MP2161GJ-C499 */ > > + vin-supply = <&p5v0>; > > }; > > > > emmc_pwrseq: emmc-pwrseq { > > @@ -301,7 +324,7 @@ > > mmc-hs200-1_8v; > > > > mmc-pwrseq = <&emmc_pwrseq>; > > - vmmc-supply = <&vcc3v3>; > > + vmmc-supply = <&vddio_ao3v3>; > odroid-c2_rev0.1_20150930.pdf uses VCC3V3 as supply > > > Martin Best Regards -Anand
Hi Anand, On Sun, Sep 1, 2019 at 3:58 PM Anand Moon <linux.amoon@gmail.com> wrote: > > Hi Martin, > > Thanks for your review comments. > > Their have been some revision changes in S905 Odroid Schematics. > [0] https://dn.odroid.com/S905/Schematic/ > > Well I have make my changes based on old odroid-c2_rev0.2_20151218.pdf [...] > > > > according to the schematics there's both: > > - VDDIO_AO3V3 > > - VCC3V3 (which is turned on by VDDIO_AO3V3, see [0]) > > > > From the schematics it seams same. > > VDDIO_AO3V3---DMG340LSQN4 (Q4)---VCC3V3 yes, they are the same signal. the only difference is that VCC3V3 is turned on later in the power-up sequence > But this name change was done to link TFLASH_VDD_EN to TFLASH_VDD for eMMC > > VDDIO_AO3V3-----TFLASH_VDD using TFLASH_VDD_EN gpio pin. > > Well I have tested this changes on eMMC module. I cannot see any of the TFLASH_* regulators being linked to eMMC (they are only linked to the SD card slot, I also checked odroid-c2_rev0.2_20151218.pdf and odroid-c2_rev0.2_20171114.pdf). which page of the odroid-c2_rev0.2_20151218.pdf schematics shows how TFLASH_VDD is linked to eMMC? please note that I don't have an Odroid-C2 board myself (so I cannot test any of this). Martin
Hi Martin, On Mon, 2 Sep 2019 at 03:23, Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote: > > Hi Anand, > > On Sun, Sep 1, 2019 at 3:58 PM Anand Moon <linux.amoon@gmail.com> wrote: > > > > Hi Martin, > > > > Thanks for your review comments. > > > > Their have been some revision changes in S905 Odroid Schematics. > > [0] https://dn.odroid.com/S905/Schematic/ > > > > Well I have make my changes based on old odroid-c2_rev0.2_20151218.pdf > > [...] > > > > > > according to the schematics there's both: > > > - VDDIO_AO3V3 > > > - VCC3V3 (which is turned on by VDDIO_AO3V3, see [0]) > > > > > > > From the schematics it seams same. > > > > VDDIO_AO3V3---DMG340LSQN4 (Q4)---VCC3V3 > yes, they are the same signal. the only difference is that VCC3V3 is > turned on later in the power-up sequence > > > But this name change was done to link TFLASH_VDD_EN to TFLASH_VDD for eMMC > > > > VDDIO_AO3V3-----TFLASH_VDD using TFLASH_VDD_EN gpio pin. > > > > Well I have tested this changes on eMMC module. > I cannot see any of the TFLASH_* regulators being linked to eMMC (they > are only linked to the SD card slot, I also checked > odroid-c2_rev0.2_20151218.pdf and odroid-c2_rev0.2_20171114.pdf). > which page of the odroid-c2_rev0.2_20151218.pdf schematics shows how > TFLASH_VDD is linked to eMMC? > > please note that I don't have an Odroid-C2 board myself (so I cannot > test any of this). > > > Martin Thanks I will double check again and re-post then with correction again. Best Regards -Anand
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts index 792698a60a12..98e742bf44c1 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts @@ -104,11 +104,34 @@ regulator-max-microvolt = <1800000>; }; - vcc3v3: regulator-vcc3v3 { + vddio_ao1v8: regulator-vddio-ao1v8 { compatible = "regulator-fixed"; - regulator-name = "VCC3V3"; + regulator-name = "VDDIO_AO1V8"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-always-on; + /* U17 RT9179GB */ + vin-supply = <&p5v0>; + }; + + vddio_ao3v3: regulator-vddio-ao3v3 { + compatible = "regulator-fixed"; + regulator-name = "VDDIO_AO3V3"; regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; + regulator-always-on; + /* U11 MP2161GJ-C499 */ + vin-supply = <&p5v0>; + }; + + vddc_ddr: regulator-vddc-ddr { + compatible = "regulator-fixed"; + regulator-name = "DDR_VDDC"; + regulator-min-microvolt = <1500000>; + regulator-max-microvolt = <1500000>; + regulator-always-on; + /* U15 MP2161GJ-C499 */ + vin-supply = <&p5v0>; }; emmc_pwrseq: emmc-pwrseq { @@ -301,7 +324,7 @@ mmc-hs200-1_8v; mmc-pwrseq = <&emmc_pwrseq>; - vmmc-supply = <&vcc3v3>; + vmmc-supply = <&vddio_ao3v3>; vqmmc-supply = <&vcc1v8>; };
As per shematics VDDIO_AO18, VDDIO_AO3V3/VDD3V3 DDR3_1V5/DDR_VDDC: fixed regulator output which is supplied by P5V0. Rename vcc3v3 regulator node to vddio_ao3v3 as per shematics. Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Cc: Jerome Brunet <jbrunet@baylibre.com> Cc: Neil Armstrong <narmstrong@baylibre.com> Signed-off-by: Anand Moon <linux.amoon@gmail.com> --- .../boot/dts/amlogic/meson-gxbb-odroidc2.dts | 29 +++++++++++++++++-- 1 file changed, 26 insertions(+), 3 deletions(-)