| Message ID | 20190828202723.1145-4-linux.amoon@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Odroid c2 missing regulator linking | expand |
Hi Anand, On Wed, Aug 28, 2019 at 10:27 PM Anand Moon <linux.amoon@gmail.com> wrote: > > As per shematics HDMI_P5V0 is supplied by P5V0 so add missing link. typo: "schematics" > Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > Cc: Jerome Brunet <jbrunet@baylibre.com> > Cc: Neil Armstrong <narmstrong@baylibre.com> > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > --- > arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts > index a078a1ee5004..47789fd50415 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts > +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts > @@ -213,6 +213,8 @@ > status = "okay"; > pinctrl-0 = <&hdmi_hpd_pins>, <&hdmi_i2c_pins>; > pinctrl-names = "default"; > + /* AP2331SA-7 */ > + hdmi-supply = <&p5v0>; > }; my understanding based on odroid-c2_rev0.1_20150930.pdf is that: - there's a (fixed) hdmi_p5v0 regulator using p5v0 as input - the hdmi_p5v0 is the hdmi-supply it doesn't change the functionality of this patch (since both supplies are fixed regulators anyways) you are already doing a nice cleanup with this series, so it would be a shame to take a shortcut here Martin
Hi Martin, On Sun, 1 Sep 2019 at 17:14, Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote: > > Hi Anand, > > On Wed, Aug 28, 2019 at 10:27 PM Anand Moon <linux.amoon@gmail.com> wrote: > > > > As per shematics HDMI_P5V0 is supplied by P5V0 so add missing link. > typo: "schematics" > > > Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > > Cc: Jerome Brunet <jbrunet@baylibre.com> > > Cc: Neil Armstrong <narmstrong@baylibre.com> > > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > > --- > > arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts > > index a078a1ee5004..47789fd50415 100644 > > --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts > > +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts > > @@ -213,6 +213,8 @@ > > status = "okay"; > > pinctrl-0 = <&hdmi_hpd_pins>, <&hdmi_i2c_pins>; > > pinctrl-names = "default"; > > + /* AP2331SA-7 */ > > + hdmi-supply = <&p5v0>; > > }; > my understanding based on odroid-c2_rev0.1_20150930.pdf is that: > - there's a (fixed) hdmi_p5v0 regulator using p5v0 as input > - the hdmi_p5v0 is the hdmi-supply > > it doesn't change the functionality of this patch (since both supplies > are fixed regulators anyways) > you are already doing a nice cleanup with this series, so it would be > a shame to take a shortcut here > I could not find gpio control pin which could be used to enable hdmi-supply node. So that the reason for direct linking this to p5v0 node. But looking back at the schematics it and datasheet their are two more regulator supplies to HDMI. HDMITX_AVDD33-1 ---- VDDIO_AO3V3 HDMITX_AVDD18-1 ---- VCC1V8 Need to check the hdmi driver if these need to enable. Best Regards -Anand > > Martin
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts index a078a1ee5004..47789fd50415 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts @@ -213,6 +213,8 @@ status = "okay"; pinctrl-0 = <&hdmi_hpd_pins>, <&hdmi_i2c_pins>; pinctrl-names = "default"; + /* AP2331SA-7 */ + hdmi-supply = <&p5v0>; }; &hdmi_tx_tmds_port {
As per shematics HDMI_P5V0 is supplied by P5V0 so add missing link. Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Cc: Jerome Brunet <jbrunet@baylibre.com> Cc: Neil Armstrong <narmstrong@baylibre.com> Signed-off-by: Anand Moon <linux.amoon@gmail.com> --- arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 2 ++ 1 file changed, 2 insertions(+)