| Message ID | 20191122225210.109172-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 60bd22fc90630e19b616a3f329ae3958f0878ac6 |
| Headers | show |
| Series | rtc: meson: remove redundant assignment to variable retries | expand |
Hi Colin, On Fri, Nov 22, 2019 at 11:52 PM Colin King <colin.king@canonical.com> wrote: > > From: Colin Ian King <colin.king@canonical.com> > > The variable retries is being initialized with a value that is never > read and it is being updated later with a new value in a for-loop. > The initialization is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <colin.king@canonical.com> thank you for addressing this! Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Martin
On 22/11/2019 22:52:10+0000, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The variable retries is being initialized with a value that is never > read and it is being updated later with a new value in a for-loop. > The initialization is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/rtc/rtc-meson.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied, thanks.
diff --git a/drivers/rtc/rtc-meson.c b/drivers/rtc/rtc-meson.c index 9bd8478db34b..47ebcf834cc2 100644 --- a/drivers/rtc/rtc-meson.c +++ b/drivers/rtc/rtc-meson.c @@ -131,7 +131,7 @@ static u32 meson_rtc_get_data(struct meson_rtc *rtc) static int meson_rtc_get_bus(struct meson_rtc *rtc) { - int ret, retries = 3; + int ret, retries; u32 val; /* prepare bus for transfers, set all lines low */