Message ID | 20200115122908.16954-3-repk@triplefau.lt (mailing list archive) |
---|---|
State | Superseded |
Headers | show |
Series | PCI: amlogic: Make PCIe working reliably on AXG platforms | expand |
On Wed, Jan 15, 2020 at 01:29:03PM +0100, Remi Pommarel wrote: > Add documentation for the shared MIPI/PCIE PHYs found in AXG SoCs. > > Signed-off-by: Remi Pommarel <repk@triplefau.lt> > --- > .../phy/amlogic,meson-axg-mipi-pcie.yaml | 34 +++++++++++++++++++ > 1 file changed, 34 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie.yaml > > diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie.yaml b/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie.yaml > new file mode 100644 > index 000000000000..3184146318cf > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie.yaml > @@ -0,0 +1,34 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +# Copyright 2019 BayLibre, SAS > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/phy/amlogic,meson-axg-mipi-pcie.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Amlogic AXG shared MIPI/PCIE PHY > + > +maintainers: > + - Remi Pommarel <repk@triplefau.lt> > + > +properties: > + compatible: > + const: amlogic,axg-mipi-pcie-phy > + > + reg: > + maxItems: 1 > + > + "#phy-cells": > + const: 1 > + > +required: > + - compatible > + - reg > + - "#phy-cells" Add: additionalProperties: false With that, Reviewed-by: Rob Herring <robh@kernel.org> > + > +examples: > + - | > + mpphy: phy@0 { > + compatible = "amlogic,axg-mipi-pcie-phy"; > + reg = <0x0 0x0 0x0 0xc>; > + #phy-cells = <1>; > + }; > -- > 2.24.1 >
On Tue, Jan 21, 2020 at 5:05 PM Rob Herring <robh@kernel.org> wrote: > > On Wed, Jan 15, 2020 at 01:29:03PM +0100, Remi Pommarel wrote: > > Add documentation for the shared MIPI/PCIE PHYs found in AXG SoCs. > > > > Signed-off-by: Remi Pommarel <repk@triplefau.lt> > > --- > > .../phy/amlogic,meson-axg-mipi-pcie.yaml | 34 +++++++++++++++++++ > > 1 file changed, 34 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie.yaml > > > > diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie.yaml b/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie.yaml > > new file mode 100644 > > index 000000000000..3184146318cf > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie.yaml > > @@ -0,0 +1,34 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +# Copyright 2019 BayLibre, SAS > > +%YAML 1.2 > > +--- > > +$id: "http://devicetree.org/schemas/phy/amlogic,meson-axg-mipi-pcie.yaml#" > > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > > + > > +title: Amlogic AXG shared MIPI/PCIE PHY > > + > > +maintainers: > > + - Remi Pommarel <repk@triplefau.lt> > > + > > +properties: > > + compatible: > > + const: amlogic,axg-mipi-pcie-phy > > + > > + reg: > > + maxItems: 1 > > + > > + "#phy-cells": > > + const: 1 > > + > > +required: > > + - compatible > > + - reg > > + - "#phy-cells" > > Add: > > additionalProperties: false > > > With that, > > Reviewed-by: Rob Herring <robh@kernel.org> I missed that I already ack'ed v5, but looks like the same comment applies to both DT patches. Rob
diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie.yaml b/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie.yaml new file mode 100644 index 000000000000..3184146318cf --- /dev/null +++ b/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie.yaml @@ -0,0 +1,34 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +# Copyright 2019 BayLibre, SAS +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/phy/amlogic,meson-axg-mipi-pcie.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Amlogic AXG shared MIPI/PCIE PHY + +maintainers: + - Remi Pommarel <repk@triplefau.lt> + +properties: + compatible: + const: amlogic,axg-mipi-pcie-phy + + reg: + maxItems: 1 + + "#phy-cells": + const: 1 + +required: + - compatible + - reg + - "#phy-cells" + +examples: + - | + mpphy: phy@0 { + compatible = "amlogic,axg-mipi-pcie-phy"; + reg = <0x0 0x0 0x0 0xc>; + #phy-cells = <1>; + };
Add documentation for the shared MIPI/PCIE PHYs found in AXG SoCs. Signed-off-by: Remi Pommarel <repk@triplefau.lt> --- .../phy/amlogic,meson-axg-mipi-pcie.yaml | 34 +++++++++++++++++++ 1 file changed, 34 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie.yaml