diff mbox series

[01/10] clk: at91: Drop unused at91sam9g45_pcr_layout

Message ID 20200902150348.14465-1-krzk@kernel.org (mailing list archive)
State New, archived
Delegated to: Neil Armstrong
Headers show
Series [01/10] clk: at91: Drop unused at91sam9g45_pcr_layout | expand

Commit Message

Krzysztof Kozlowski Sept. 2, 2020, 3:03 p.m. UTC
The at91sam9g45_pcr_layout is not used so drop it to fix build warning:

  drivers/clk/at91/at91sam9g45.c:49:36: warning:
    'at91sam9g45_pcr_layout' defined but not used [-Wunused-const-variable=]

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 drivers/clk/at91/at91sam9g45.c | 7 -------
 1 file changed, 7 deletions(-)

Comments

Alexandre Belloni Sept. 2, 2020, 4:35 p.m. UTC | #1
On 02/09/2020 17:03:39+0200, Krzysztof Kozlowski wrote:
> The at91sam9g45_pcr_layout is not used so drop it to fix build warning:
> 
>   drivers/clk/at91/at91sam9g45.c:49:36: warning:
>     'at91sam9g45_pcr_layout' defined but not used [-Wunused-const-variable=]
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

> ---
>  drivers/clk/at91/at91sam9g45.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/clk/at91/at91sam9g45.c b/drivers/clk/at91/at91sam9g45.c
> index c88ee20bee31..cb4a406ed15d 100644
> --- a/drivers/clk/at91/at91sam9g45.c
> +++ b/drivers/clk/at91/at91sam9g45.c
> @@ -46,13 +46,6 @@ static const struct {
>  	{ .n = "pck1",  .p = "prog1",    .id = 9 },
>  };
>  
> -static const struct clk_pcr_layout at91sam9g45_pcr_layout = {
> -	.offset = 0x10c,
> -	.cmd = BIT(12),
> -	.pid_mask = GENMASK(5, 0),
> -	.div_mask = GENMASK(17, 16),
> -};
> -
>  struct pck {
>  	char *n;
>  	u8 id;
> -- 
> 2.17.1
>
Krzysztof Kozlowski Sept. 11, 2020, 3:34 p.m. UTC | #2
On Wed, Sep 02, 2020 at 06:35:58PM +0200, Alexandre Belloni wrote:
> On 02/09/2020 17:03:39+0200, Krzysztof Kozlowski wrote:
> > The at91sam9g45_pcr_layout is not used so drop it to fix build warning:
> > 
> >   drivers/clk/at91/at91sam9g45.c:49:36: warning:
> >     'at91sam9g45_pcr_layout' defined but not used [-Wunused-const-variable=]
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> 
> > ---
> >  drivers/clk/at91/at91sam9g45.c | 7 -------
> >  1 file changed, 7 deletions(-)
> > 

Hi Stephen,

If the dev_err_probe() waits/skips/goes to /dev/null, then how about the
fixes in the series? This patch and few other?

Best regards,
Krzysztof
Stephen Boyd Sept. 15, 2020, 12:01 a.m. UTC | #3
Quoting Krzysztof Kozlowski (2020-09-11 08:34:41)
> On Wed, Sep 02, 2020 at 06:35:58PM +0200, Alexandre Belloni wrote:
> > On 02/09/2020 17:03:39+0200, Krzysztof Kozlowski wrote:
> > > The at91sam9g45_pcr_layout is not used so drop it to fix build warning:
> > > 
> > >   drivers/clk/at91/at91sam9g45.c:49:36: warning:
> > >     'at91sam9g45_pcr_layout' defined but not used [-Wunused-const-variable=]
> > > 
> > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> > 
> > > ---
> > >  drivers/clk/at91/at91sam9g45.c | 7 -------
> > >  1 file changed, 7 deletions(-)
> > > 
> 
> Hi Stephen,
> 
> If the dev_err_probe() waits/skips/goes to /dev/null, then how about the
> fixes in the series? This patch and few other?

Yes if dev_err_probe() is superseded by Rob's work then the fixes should
be fine to pick up. Can you resend the fixes?
Krzysztof Kozlowski Sept. 16, 2020, 4:15 p.m. UTC | #4
On Tue, 15 Sep 2020 at 02:01, Stephen Boyd <sboyd@kernel.org> wrote:
>
> Quoting Krzysztof Kozlowski (2020-09-11 08:34:41)
> > On Wed, Sep 02, 2020 at 06:35:58PM +0200, Alexandre Belloni wrote:
> > > On 02/09/2020 17:03:39+0200, Krzysztof Kozlowski wrote:
> > > > The at91sam9g45_pcr_layout is not used so drop it to fix build warning:
> > > >
> > > >   drivers/clk/at91/at91sam9g45.c:49:36: warning:
> > > >     'at91sam9g45_pcr_layout' defined but not used [-Wunused-const-variable=]
> > > >
> > > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > > Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> > >
> > > > ---
> > > >  drivers/clk/at91/at91sam9g45.c | 7 -------
> > > >  1 file changed, 7 deletions(-)
> > > >
> >
> > Hi Stephen,
> >
> > If the dev_err_probe() waits/skips/goes to /dev/null, then how about the
> > fixes in the series? This patch and few other?
>
> Yes if dev_err_probe() is superseded by Rob's work then the fixes should
> be fine to pick up. Can you resend the fixes?

Sure, I will send the fixes only.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/drivers/clk/at91/at91sam9g45.c b/drivers/clk/at91/at91sam9g45.c
index c88ee20bee31..cb4a406ed15d 100644
--- a/drivers/clk/at91/at91sam9g45.c
+++ b/drivers/clk/at91/at91sam9g45.c
@@ -46,13 +46,6 @@  static const struct {
 	{ .n = "pck1",  .p = "prog1",    .id = 9 },
 };
 
-static const struct clk_pcr_layout at91sam9g45_pcr_layout = {
-	.offset = 0x10c,
-	.cmd = BIT(12),
-	.pid_mask = GENMASK(5, 0),
-	.div_mask = GENMASK(17, 16),
-};
-
 struct pck {
 	char *n;
 	u8 id;