Message ID | 20201120153855.3920757-1-narmstrong@baylibre.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | [v3] phy: amlogic: phy-meson-gxl-usb2: keep ID pull-up even in Host mode | expand |
On 20-11-20, 16:38, Neil Armstrong wrote: > In order to keep OTG ID detection even when in Host mode, the ID line of > the PHY (if the current phy is an OTG one) pull-up should be kept > enable in both modes. > > This fixes OTG switch on GXL, GXM & AXG platforms, otherwise once switched > to Host, the ID detection doesn't work anymore to switch back to Device. Applied, thanks
diff --git a/drivers/phy/amlogic/phy-meson-gxl-usb2.c b/drivers/phy/amlogic/phy-meson-gxl-usb2.c index 875afb2672c7..2b3c0d730f20 100644 --- a/drivers/phy/amlogic/phy-meson-gxl-usb2.c +++ b/drivers/phy/amlogic/phy-meson-gxl-usb2.c @@ -158,7 +158,8 @@ static int phy_meson_gxl_usb2_set_mode(struct phy *phy, U2P_R0_DM_PULLDOWN); regmap_update_bits(priv->regmap, U2P_R0, U2P_R0_DP_PULLDOWN, U2P_R0_DP_PULLDOWN); - regmap_update_bits(priv->regmap, U2P_R0, U2P_R0_ID_PULLUP, 0); + regmap_update_bits(priv->regmap, U2P_R0, U2P_R0_ID_PULLUP, + U2P_R0_ID_PULLUP); break; case PHY_MODE_USB_DEVICE: