diff mbox series

arm64: dts: meson: vim3: reduce cpu thermal fan trigger temperature

Message ID 20210609012849.797576-1-xieqinick@gmail.com (mailing list archive)
State New
Headers show
Series arm64: dts: meson: vim3: reduce cpu thermal fan trigger temperature | expand

Commit Message

Nick Xie June 9, 2021, 1:28 a.m. UTC
From: Nick Xie <nick@khadas.com>

Reduce the MCU FAN trigger temperature from
80 degree centigrade to 50 degree centigrade.

Signed-off-by: Nick Xie <nick@khadas.com>
---
 arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Neil Armstrong June 11, 2021, 6:44 a.m. UTC | #1
Hi Nick,

On 09/06/2021 03:28, xieqinick@gmail.com wrote:
> From: Nick Xie <nick@khadas.com>
> 
> Reduce the MCU FAN trigger temperature from
> 80 degree centigrade to 50 degree centigrade.

Can you add some more rationale to this change ?

> 
> Signed-off-by: Nick Xie <nick@khadas.com>
> ---
>  arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi b/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi
> index 66d67524b031..a9c34fee91f4 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi
> @@ -256,7 +256,7 @@ &cecb_AO {
>  &cpu_thermal {
>  	trips {
>  		cpu_active: cpu-active {
> -			temperature = <80000>; /* millicelsius */
> +			temperature = <50000>; /* millicelsius */
>  			hysteresis = <2000>; /* millicelsius */
>  			type = "active";
>  		};
> 

With that:
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
Neil Armstrong June 11, 2021, 7:15 a.m. UTC | #2
Hi,

On 11/06/2021 08:54, Nick Xie wrote:
> Hello Neil,
> 
> The MCU FAN won't work until the temperature reach to 80 degree centigrade,
> Do you think the temperature is too high?

I think 80 is tool high, but I fear 50 is way too low, but if you think 50 is OK after you ran some tests, just add it to the commit log and it's ok for me.

Neil

> 
> Thanks.
> 
> Neil Armstrong <narmstrong@baylibre.com <mailto:narmstrong@baylibre.com>> 于2021年6月11日周五 下午2:44写道:
> 
>     Hi Nick,
> 
>     On 09/06/2021 03:28, xieqinick@gmail.com <mailto:xieqinick@gmail.com> wrote:
>     > From: Nick Xie <nick@khadas.com <mailto:nick@khadas.com>>
>     >
>     > Reduce the MCU FAN trigger temperature from
>     > 80 degree centigrade to 50 degree centigrade.
> 
>     Can you add some more rationale to this change ?
> 
>     >
>     > Signed-off-by: Nick Xie <nick@khadas.com <mailto:nick@khadas.com>>
>     > ---
>     >  arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi | 2 +-
>     >  1 file changed, 1 insertion(+), 1 deletion(-)
>     >
>     > diff --git a/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi b/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi
>     > index 66d67524b031..a9c34fee91f4 100644
>     > --- a/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi
>     > +++ b/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi
>     > @@ -256,7 +256,7 @@ &cecb_AO {
>     >  &cpu_thermal {
>     >       trips {
>     >               cpu_active: cpu-active {
>     > -                     temperature = <80000>; /* millicelsius */
>     > +                     temperature = <50000>; /* millicelsius */
>     >                       hysteresis = <2000>; /* millicelsius */
>     >                       type = "active";
>     >               };
>     >
> 
>     With that:
>     Reviewed-by: Neil Armstrong <narmstrong@baylibre.com <mailto:narmstrong@baylibre.com>>
>
Nick Xie June 11, 2021, 7:30 a.m. UTC | #3
Hello Neil,


Neil Armstrong <narmstrong@baylibre.com> 于2021年6月11日周五 下午3:15写道:
>
> Hi,
>
> On 11/06/2021 08:54, Nick Xie wrote:
> > Hello Neil,
> >
> > The MCU FAN won't work until the temperature reach to 80 degree centigrade,
> > Do you think the temperature is too high?
>
> I think 80 is tool high, but I fear 50 is way too low, but if you think 50 is OK after you ran some tests, just add it to the commit log and it's ok for me.

I think it is OK, we use it for a long time.

Thanks.

>
> Neil
>
> >
> > Thanks.
> >
> > Neil Armstrong <narmstrong@baylibre.com <mailto:narmstrong@baylibre.com>> 于2021年6月11日周五 下午2:44写道:
> >
> >     Hi Nick,
> >
> >     On 09/06/2021 03:28, xieqinick@gmail.com <mailto:xieqinick@gmail.com> wrote:
> >     > From: Nick Xie <nick@khadas.com <mailto:nick@khadas.com>>
> >     >
> >     > Reduce the MCU FAN trigger temperature from
> >     > 80 degree centigrade to 50 degree centigrade.
> >
> >     Can you add some more rationale to this change ?
> >
> >     >
> >     > Signed-off-by: Nick Xie <nick@khadas.com <mailto:nick@khadas.com>>
> >     > ---
> >     >  arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi | 2 +-
> >     >  1 file changed, 1 insertion(+), 1 deletion(-)
> >     >
> >     > diff --git a/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi b/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi
> >     > index 66d67524b031..a9c34fee91f4 100644
> >     > --- a/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi
> >     > +++ b/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi
> >     > @@ -256,7 +256,7 @@ &cecb_AO {
> >     >  &cpu_thermal {
> >     >       trips {
> >     >               cpu_active: cpu-active {
> >     > -                     temperature = <80000>; /* millicelsius */
> >     > +                     temperature = <50000>; /* millicelsius */
> >     >                       hysteresis = <2000>; /* millicelsius */
> >     >                       type = "active";
> >     >               };
> >     >
> >
> >     With that:
> >     Reviewed-by: Neil Armstrong <narmstrong@baylibre.com <mailto:narmstrong@baylibre.com>>
> >
>
Daniel Lezcano June 11, 2021, 7:45 a.m. UTC | #4
On 11/06/2021 09:30, Nick Xie wrote:
> Hello Neil,
> 
> 
> Neil Armstrong <narmstrong@baylibre.com> 于2021年6月11日周五 下午3:15写道:
>>
>> Hi,
>>
>> On 11/06/2021 08:54, Nick Xie wrote:
>>> Hello Neil,
>>>
>>> The MCU FAN won't work until the temperature reach to 80 degree centigrade,
>>> Do you think the temperature is too high?
>>
>> I think 80 is tool high, but I fear 50 is way too low, but if you think 50 is OK after you ran some tests, just add it to the commit log and it's ok for me.
> 
> I think it is OK, we use it for a long time.

50°C sounds like normal temperature with regular load. That means the
fan will be switched on most of the time when the board is used.

And this change may be put in regard with the other trip points in the
common DT. For instance, enable the fan when reaching 80°C but set the
passive trip point to 75°C instead of 85°C.

All that depends on the hardware characteristics and TDP which are in
the TRM normally.
Neil Armstrong June 14, 2021, 1:17 p.m. UTC | #5
Hi,
On 11/06/2021 09:45, Daniel Lezcano wrote:
> On 11/06/2021 09:30, Nick Xie wrote:
>> Hello Neil,
>>
>>
>> Neil Armstrong <narmstrong@baylibre.com> 于2021年6月11日周五 下午3:15写道:
>>>
>>> Hi,
>>>
>>> On 11/06/2021 08:54, Nick Xie wrote:
>>>> Hello Neil,
>>>>
>>>> The MCU FAN won't work until the temperature reach to 80 degree centigrade,
>>>> Do you think the temperature is too high?
>>>
>>> I think 80 is tool high, but I fear 50 is way too low, but if you think 50 is OK after you ran some tests, just add it to the commit log and it's ok for me.
>>
>> I think it is OK, we use it for a long time.
> 
> 50°C sounds like normal temperature with regular load. That means the
> fan will be switched on most of the time when the board is used.
> 
> And this change may be put in regard with the other trip points in the
> common DT. For instance, enable the fan when reaching 80°C but set the
> passive trip point to 75°C instead of 85°C.
> 
> All that depends on the hardware characteristics and TDP which are in
> the TRM normally.
> 

I don't think such data exist in the datasheet or other public document, but the vendor source tree
sets:
- passive: 75°C
- hot 85°C
- critical 110°C

we set upstream:
- passive: 85°C
- hot 95°C
- critical 110°C

so maybe we should lower the passive & hot trip points, then the FAN 80°C trip point would be ok now according to Daniel's explanation.

Neil
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi b/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi
index 66d67524b031..a9c34fee91f4 100644
--- a/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi
@@ -256,7 +256,7 @@  &cecb_AO {
 &cpu_thermal {
 	trips {
 		cpu_active: cpu-active {
-			temperature = <80000>; /* millicelsius */
+			temperature = <50000>; /* millicelsius */
 			hysteresis = <2000>; /* millicelsius */
 			type = "active";
 		};