diff mbox series

[5/5] watchdog: meson_gxbb_wdt: add register device status notification

Message ID 20210623024429.1346349-6-art@khadas.com (mailing list archive)
State Superseded
Headers show
Series watchdog: meson_gxbb_wdt: improve | expand

Commit Message

Art Nikpal June 23, 2021, 2:44 a.m. UTC
Print watchdog success driver start status notification

Signed-off-by: Artem Lapkin <art@khadas.com>
---
 drivers/watchdog/meson_gxbb_wdt.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

Comments

Guenter Roeck June 27, 2021, 3:45 p.m. UTC | #1
On 6/22/21 7:44 PM, Artem Lapkin wrote:
> Print watchdog success driver start status notification
> 

Another personal opinion: The driver author decided that the message is
not needed (which matches my personal opinion). I'd rather see all those
messages either go away or moved to the core. Either case, this one is
misleading: The watchdog is _not_ enabled. The watchdog driver is loaded,
which is different.

Guenter

> Signed-off-by: Artem Lapkin <art@khadas.com>
> ---
>   drivers/watchdog/meson_gxbb_wdt.c | 9 ++++++++-
>   1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/meson_gxbb_wdt.c b/drivers/watchdog/meson_gxbb_wdt.c
> index 2dbe254e5122..750b304b460d 100644
> --- a/drivers/watchdog/meson_gxbb_wdt.c
> +++ b/drivers/watchdog/meson_gxbb_wdt.c
> @@ -198,7 +198,14 @@ static int meson_gxbb_wdt_probe(struct platform_device *pdev)
>   	watchdog_set_nowayout(&data->wdt_dev, nowayout);
>   	watchdog_stop_on_unregister(&data->wdt_dev);
>   
> -	return devm_watchdog_register_device(dev, &data->wdt_dev);
> +	ret = devm_watchdog_register_device(dev, &data->wdt_dev);
> +	if (ret)
> +		return ret;
> +
> +	dev_info(dev, "Watchdog enabled (timeout=%d sec, nowayout=%d)",
> +		 data->wdt_dev.timeout, nowayout);
> +
> +	return ret;
>   }
>   
>   static struct platform_driver meson_gxbb_wdt_driver = {
>
diff mbox series

Patch

diff --git a/drivers/watchdog/meson_gxbb_wdt.c b/drivers/watchdog/meson_gxbb_wdt.c
index 2dbe254e5122..750b304b460d 100644
--- a/drivers/watchdog/meson_gxbb_wdt.c
+++ b/drivers/watchdog/meson_gxbb_wdt.c
@@ -198,7 +198,14 @@  static int meson_gxbb_wdt_probe(struct platform_device *pdev)
 	watchdog_set_nowayout(&data->wdt_dev, nowayout);
 	watchdog_stop_on_unregister(&data->wdt_dev);
 
-	return devm_watchdog_register_device(dev, &data->wdt_dev);
+	ret = devm_watchdog_register_device(dev, &data->wdt_dev);
+	if (ret)
+		return ret;
+
+	dev_info(dev, "Watchdog enabled (timeout=%d sec, nowayout=%d)",
+		 data->wdt_dev.timeout, nowayout);
+
+	return ret;
 }
 
 static struct platform_driver meson_gxbb_wdt_driver = {