| Message ID | 20210707141323.20757-2-viktor.prutyanov@phystech.edu (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | media: rc: add support for Amlogic Meson IR blaster | expand |
Hi Viktor, On Wed, Jul 7, 2021 at 4:13 PM Viktor Prutyanov <viktor.prutyanov@phystech.edu> wrote: > > This patch adds binding documentation for the IR transmitter > available in Amlogic Meson SoCs. > > Signed-off-by: Viktor Prutyanov <viktor.prutyanov@phystech.edu> > --- > changes in v2: > - compatible = "amlogic,meson-g12a-irblaster" added > - clocks, clock-names and mod-clock updated thanks for updating this patch with my feedback! [...] > + mod-clock: > + maxItems: 1 in the change-log for this patch you mentioned that mod-clock is updated as well I think that mod-clock (as a whole property) should only be added if it's an external input to the IR blaster IP block Best regards, Martin
Hi Martin, On Thu, 8 Jul 2021 15:09:30 +0200 Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote: > Hi Viktor, > > On Wed, Jul 7, 2021 at 4:13 PM Viktor Prutyanov > <viktor.prutyanov@phystech.edu> wrote: > > > > This patch adds binding documentation for the IR transmitter > > available in Amlogic Meson SoCs. > > > > Signed-off-by: Viktor Prutyanov <viktor.prutyanov@phystech.edu> > > --- > > changes in v2: > > - compatible = "amlogic,meson-g12a-irblaster" added > > - clocks, clock-names and mod-clock updated > thanks for updating this patch with my feedback! > > [...] > > + mod-clock: > > + maxItems: 1 > in the change-log for this patch you mentioned that mod-clock is > updated as well I think that mod-clock (as a whole property) should > only be added if it's an external input to the IR blaster IP block There are 2 clocks connected to blaster module, and mod-clock is just a selector between them. Meson IR blaster driver should choose one of the modulation clocks. If not through a property, then how to do it? > > > Best regards, > Martin Best regards, Viktor
Hi Viktor, On Thu, Jul 8, 2021 at 3:20 PM Viktor Prutyanov <viktor.prutyanov@phystech.edu> wrote: [...] > > > + mod-clock: > > > + maxItems: 1 > > in the change-log for this patch you mentioned that mod-clock is > > updated as well I think that mod-clock (as a whole property) should > > only be added if it's an external input to the IR blaster IP block > > There are 2 clocks connected to blaster module, and mod-clock is just a > selector between them. Meson IR blaster driver should choose one of the > modulation clocks. If not through a property, then how to do it? It depends on what the requirement for this clock is I'll give you some examples as I am not sure about the inner workings of the IR blaster - in hope that you'll be able to make a conclusion for yourself. drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c: If Ethernet is configured into RGMII mode we need to configure a clock tree (which consists of a mux to select between two different input clocks, a fixed divider, a configurable divider and a gate). The output clock rate must be 125MHz (or on SoCs which don't support this directly then "as close as possible"). In this driver the clocks (and their hierarchy) are modelled using the common clock framework so in the end we can conveniently use clk_set_rate(dwmac->rgmii_tx_clk, 125 * 1000 * 1000) drivers/mmc/host/meson-mx-sdio.c: During initialization we need to inform the MMC subsystem of the minimum and maximum supported clocks - this is done in meson_mx_mmc_add_host(). The actual clock rate in the end depends on the SD/MMC card and it's passed down to use from the MMC subsystem. We then use clk_set_rate() in meson_mx_mmc_set_ios() to set the clock rate closest to what has been requested by the MMC subsystem. The IP block for this controller does not contain a mux but a fixed-divider as well as a configurable divider - both are modelled using the common clock framework. Based on my understanding of the IR blaster description in the datasheet that IP uses: - fixed divider clock: xtal / 3 - fixed divider clock or a fixed rate clock (it's hard to tell as all Amlogic boards I have use a 24MHz crystal): 1MHz (1uS) - fixed divider clock or a fixed rate clock (it's hard to tell as all Amlogic boards I have use a 24MHz crystal): 100kHz (10uS) - clk81 - a mux to choose between the four above clocks - a configurable divider (SLOW_CLOCK_DIV) - possibly a gate clock (bit 0 of IR_BLASTER_CNTL0 called ENABLE) If you only care about one specific clock setting (let's say the 1MHz/1uS). Then you can either hard-code the values and register initialization in the driver. The mod-clock property is not needed in this case. If the desired clock rate however changes (for example with the IR protocol) you can model the fixed dividers, fixed rate/divider clocks and mux using the common clock framework (similar to how it's done in dwmac-meson8b.c). Then you need to calculate the desired clock rate and finally use clk_set_rate(irb->clock, desired_clk_rate_hz); The mod-clock property is not needed in this case. Best regards, Martin
diff --git a/Documentation/devicetree/bindings/media/amlogic,meson-irblaster.yaml b/Documentation/devicetree/bindings/media/amlogic,meson-irblaster.yaml new file mode 100644 index 000000000000..711b7e029275 --- /dev/null +++ b/Documentation/devicetree/bindings/media/amlogic,meson-irblaster.yaml @@ -0,0 +1,62 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) + +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/media/amlogic,meson-irblaster.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Amlogic Meson IR blaster + +maintainers: + - Viktor Prutyanov <viktor.prutyanov@phystech.edu> + +description: | + Some Amlogic SoCs such as A311D and T950D4 have IR transmitter + (blaster) controller onboard. It is capable of sending IR signals + with arbitrary carrier frequency and duty cycle. + +properties: + compatible: + oneOf: + - const: amlogic,meson-irblaster + - items: + - const: amlogic,meson-g12a-irblaster + - const: amlogic,meson-irblaster + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + maxItems: 2 + + clock-names: + items: + - const: sysclk + - const: xtal + + mod-clock: + maxItems: 1 + +required: + - compatible + - reg + - interrupts + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + #include <dt-bindings/clock/g12a-clkc.h> + + irblaster@ff80014c { + compatible = "amlogic,meson-g12a-irblaster", "amlogic,meson-irblaster"; + reg = <0xff80014c 0x10>; + interrupts = <0 198 IRQ_TYPE_EDGE_RISING>; + clocks = <&clkc CLKID_CLK81>, <&xtal>; + clock-names = "sysclk", "xtal"; + mod-clock = "xtal"; + };
This patch adds binding documentation for the IR transmitter available in Amlogic Meson SoCs. Signed-off-by: Viktor Prutyanov <viktor.prutyanov@phystech.edu> --- changes in v2: - compatible = "amlogic,meson-g12a-irblaster" added - clocks, clock-names and mod-clock updated .../media/amlogic,meson-irblaster.yaml | 62 +++++++++++++++++++ 1 file changed, 62 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/amlogic,meson-irblaster.yaml