diff mbox series

[3/4] arm64: dts: amlogic: meson-g12: Fix GPU operating point table node name

Message ID 20211023214856.30097-3-alexander.stein@mailbox.org (mailing list archive)
State New, archived
Headers show
Series [1/4] dt-bindings: sound: amlogic: t9015: Add missing AVDD-supply property | expand

Commit Message

Alexander Stein Oct. 23, 2021, 9:48 p.m. UTC
Starting with commit 94274f20f6bf ("dt-bindings: opp: Convert to DT
schema") the opp node name has a mandatory pattern. This change
fixes the dtbs_check warning:
gpu-opp-table: $nodename:0: 'gpu-opp-table' does not match
'^opp-table(-[a-z0-9]+)?$'
Put the 'gpu' part at the end to match the pattern.

Fixes: 916a0edc43f0 ("arm64: dts: amlogic: meson-g12: add the Mali OPP table and use DVFS")
Signed-off-by: Alexander Stein <alexander.stein@mailbox.org>
---
Same as with patch 2/4 about the 'Fixes' tag: At the time when
gpu-opp-table was added there was no schema present. So there was no bug at
the time of writing. I'm ok either way.

 arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Neil Armstrong Oct. 25, 2021, 8:19 a.m. UTC | #1
On 23/10/2021 23:48, Alexander Stein wrote:
> Starting with commit 94274f20f6bf ("dt-bindings: opp: Convert to DT
> schema") the opp node name has a mandatory pattern. This change
> fixes the dtbs_check warning:
> gpu-opp-table: $nodename:0: 'gpu-opp-table' does not match
> '^opp-table(-[a-z0-9]+)?$'
> Put the 'gpu' part at the end to match the pattern.
> 
> Fixes: 916a0edc43f0 ("arm64: dts: amlogic: meson-g12: add the Mali OPP table and use DVFS")
> Signed-off-by: Alexander Stein <alexander.stein@mailbox.org>
> ---
> Same as with patch 2/4 about the 'Fixes' tag: At the time when
> gpu-opp-table was added there was no schema present. So there was no bug at
> the time of writing. I'm ok either way.
> 
>  arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> index ff987e7ccff2..517519e6e87f 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> @@ -58,7 +58,7 @@ efuse: efuse {
>  		secure-monitor = <&sm>;
>  	};
>  
> -	gpu_opp_table: gpu-opp-table {
> +	gpu_opp_table: opp-table-gpu {
>  		compatible = "operating-points-v2";
>  
>  		opp-124999998 {
> 

Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
index ff987e7ccff2..517519e6e87f 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
@@ -58,7 +58,7 @@  efuse: efuse {
 		secure-monitor = <&sm>;
 	};
 
-	gpu_opp_table: gpu-opp-table {
+	gpu_opp_table: opp-table-gpu {
 		compatible = "operating-points-v2";
 
 		opp-124999998 {