| Message ID | 20220726230329.2844101-4-jiucheng.xu@amlogic.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2,1/4] perf/amlogic: Add support for Amlogic meson G12 SoC DDR PMU driver | expand |
On Wed, 27 Jul 2022 07:03:29 +0800, Jiucheng Xu wrote: > Add binding documentation for the Amlogic G12 series DDR > performance monitor unit. > > Signed-off-by: Jiucheng Xu <jiucheng.xu@amlogic.com> > --- > Changes v1 -> v2: > - Rename file, from aml_ddr_pmu.yaml to amlogic,g12_ddr_pmu.yaml > - Delete "model", "dmc_nr", "chann_nr" new properties > - Fix compiling error > --- > .../bindings/perf/amlogic,g12_ddr_pmu.yaml | 45 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 46 insertions(+) > create mode 100644 Documentation/devicetree/bindings/perf/amlogic,g12_ddr_pmu.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: ./Documentation/devicetree/bindings/perf/amlogic,g12_ddr_pmu.yaml: $id: relative path/filename doesn't match actual path or filename expected: http://devicetree.org/schemas/perf/amlogic,g12_ddr_pmu.yaml# Documentation/devicetree/bindings/perf/amlogic,g12_ddr_pmu.example.dts:21.26-29.11: Warning (unit_address_vs_reg): /example-0/ddr_pmu: node has a reg or ranges property, but no unit name Documentation/devicetree/bindings/perf/amlogic,g12_ddr_pmu.example.dtb:0:0: /example-0/ddr_pmu: failed to match any schema with compatible: ['amlogic,g12a-ddr-pmu'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On 27/07/2022 01:03, Jiucheng Xu wrote: > Add binding documentation for the Amlogic G12 series DDR > performance monitor unit. > > Signed-off-by: Jiucheng Xu <jiucheng.xu@amlogic.com> > --- > Changes v1 -> v2: > - Rename file, from aml_ddr_pmu.yaml to amlogic,g12_ddr_pmu.yaml > - Delete "model", "dmc_nr", "chann_nr" new properties > - Fix compiling error > --- > .../bindings/perf/amlogic,g12_ddr_pmu.yaml | 45 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 46 insertions(+) > create mode 100644 Documentation/devicetree/bindings/perf/amlogic,g12_ddr_pmu.yaml Does not look like you tested the bindings. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). > > diff --git a/Documentation/devicetree/bindings/perf/amlogic,g12_ddr_pmu.yaml b/Documentation/devicetree/bindings/perf/amlogic,g12_ddr_pmu.yaml > new file mode 100644 > index 000000000000..46ef52b61492 > --- /dev/null > +++ b/Documentation/devicetree/bindings/perf/amlogic,g12_ddr_pmu.yaml > @@ -0,0 +1,45 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/perf/amlogic,g12-ddr-pmu.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Amlogic G12 DDR performance monitor > + > +maintainers: > + - Jiucheng Xu <jiucheng.xu@amlogic.com> > + > +properties: > + compatible: > + oneOf: That's not oneOf... > + - items: > + - enum: > + - amlogic,g12b-ddr-pmu > + amlogic,g12a-ddr-pmu > + amlogic,sm1-ddr-pmu > + - const: amlogic,g12-ddr-pmu > + > + reg: > + maxItems: 2 You need to list and describe the items. > + > + interrupts: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + > +additionalProperties: false > + > +examples: > + - | > + ddr_pmu: ddr_pmu { > + > + #include <dt-bindings/interrupt-controller/arm-gic.h> Code looks terrible... > + > + compatible = "amlogic,g12a-ddr-pmu"; > + reg = <0x0 0xff638000 0x0 0x100 > + 0x0 0xff638c00 0x0 0x100>; That's one item. You need to separate regs. Best regards, Krzysztof
On 2022/7/27 15:09, Krzysztof Kozlowski wrote: > [ EXTERNAL EMAIL ] > > On 27/07/2022 01:03, Jiucheng Xu wrote: >> Add binding documentation for the Amlogic G12 series DDR >> performance monitor unit. >> >> Signed-off-by: Jiucheng Xu <jiucheng.xu@amlogic.com> >> --- >> Changes v1 -> v2: >> - Rename file, from aml_ddr_pmu.yaml to amlogic,g12_ddr_pmu.yaml >> - Delete "model", "dmc_nr", "chann_nr" new properties >> - Fix compiling error >> --- >> .../bindings/perf/amlogic,g12_ddr_pmu.yaml | 45 +++++++++++++++++++ >> MAINTAINERS | 1 + >> 2 files changed, 46 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/perf/amlogic,g12_ddr_pmu.yaml > Does not look like you tested the bindings. Please run `make > dt_binding_check` (see > Documentation/devicetree/bindings/writing-schema.rst for instructions). > >> diff --git a/Documentation/devicetree/bindings/perf/amlogic,g12_ddr_pmu.yaml b/Documentation/devicetree/bindings/perf/amlogic,g12_ddr_pmu.yaml >> new file mode 100644 >> index 000000000000..46ef52b61492 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/perf/amlogic,g12_ddr_pmu.yaml >> @@ -0,0 +1,45 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/perf/amlogic,g12-ddr-pmu.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Amlogic G12 DDR performance monitor >> + >> +maintainers: >> + - Jiucheng Xu <jiucheng.xu@amlogic.com> >> + >> +properties: >> + compatible: >> + oneOf: > That's not oneOf... > >> + - items: >> + - enum: >> + - amlogic,g12b-ddr-pmu >> + amlogic,g12a-ddr-pmu >> + amlogic,sm1-ddr-pmu >> + - const: amlogic,g12-ddr-pmu >> + >> + reg: >> + maxItems: 2 > You need to list and describe the items. > >> + >> + interrupts: >> + maxItems: 1 >> + >> +required: >> + - compatible >> + - reg >> + - interrupts >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + ddr_pmu: ddr_pmu { >> + >> + #include <dt-bindings/interrupt-controller/arm-gic.h> > Code looks terrible... > >> + >> + compatible = "amlogic,g12a-ddr-pmu"; >> + reg = <0x0 0xff638000 0x0 0x100 >> + 0x0 0xff638c00 0x0 0x100>; > That's one item. You need to separate regs. > > > > Best regards, > Krzysztof Thanks for your comments. Once I thought the example DTB got generated means the yaml file is ok. I will learn the writing-schema. rst doc and modify the binding doc as your comments.
diff --git a/Documentation/devicetree/bindings/perf/amlogic,g12_ddr_pmu.yaml b/Documentation/devicetree/bindings/perf/amlogic,g12_ddr_pmu.yaml new file mode 100644 index 000000000000..46ef52b61492 --- /dev/null +++ b/Documentation/devicetree/bindings/perf/amlogic,g12_ddr_pmu.yaml @@ -0,0 +1,45 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/perf/amlogic,g12-ddr-pmu.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Amlogic G12 DDR performance monitor + +maintainers: + - Jiucheng Xu <jiucheng.xu@amlogic.com> + +properties: + compatible: + oneOf: + - items: + - enum: + - amlogic,g12b-ddr-pmu + amlogic,g12a-ddr-pmu + amlogic,sm1-ddr-pmu + - const: amlogic,g12-ddr-pmu + + reg: + maxItems: 2 + + interrupts: + maxItems: 1 + +required: + - compatible + - reg + - interrupts + +additionalProperties: false + +examples: + - | + ddr_pmu: ddr_pmu { + + #include <dt-bindings/interrupt-controller/arm-gic.h> + + compatible = "amlogic,g12a-ddr-pmu"; + reg = <0x0 0xff638000 0x0 0x100 + 0x0 0xff638c00 0x0 0x100>; + interrupts = <GIC_SPI 52 IRQ_TYPE_EDGE_RISING>; + }; diff --git a/MAINTAINERS b/MAINTAINERS index fd2a56a339b4..e358ee0a5c72 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1055,6 +1055,7 @@ M: Jiucheng Xu <jiucheng.xu@amlogic.com> S: Supported W: http://www.amlogic.com F: Documentation/admin-guide/perf/aml-ddr-pmu.rst +F: Documentation/devicetree/bindings/perf/amlogic,g12-ddr-pmu.yaml F: drivers/perf/amlogic/ F: include/soc/amlogic/
Add binding documentation for the Amlogic G12 series DDR performance monitor unit. Signed-off-by: Jiucheng Xu <jiucheng.xu@amlogic.com> --- Changes v1 -> v2: - Rename file, from aml_ddr_pmu.yaml to amlogic,g12_ddr_pmu.yaml - Delete "model", "dmc_nr", "chann_nr" new properties - Fix compiling error --- .../bindings/perf/amlogic,g12_ddr_pmu.yaml | 45 +++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 46 insertions(+) create mode 100644 Documentation/devicetree/bindings/perf/amlogic,g12_ddr_pmu.yaml