| Message ID | 20220817140539.150013-1-juerg.haefliger@canonical.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | media: meson: vdec: Add MODULE_FIRMWARE macro | expand |
On 17/08/2022 16:05, Juerg Haefliger wrote: > The meson-vdec module loads firmware so add MODULE_FIRMWARE macros to > provide that information via modinfo. > > Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com> > --- > .../staging/media/meson/vdec/vdec_platform.c | 20 +++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/drivers/staging/media/meson/vdec/vdec_platform.c b/drivers/staging/media/meson/vdec/vdec_platform.c > index 88c9d72e1c83..c7750d4be848 100644 > --- a/drivers/staging/media/meson/vdec/vdec_platform.c > +++ b/drivers/staging/media/meson/vdec/vdec_platform.c > @@ -280,3 +280,23 @@ const struct vdec_platform vdec_platform_sm1 = { > .num_formats = ARRAY_SIZE(vdec_formats_sm1), > .revision = VDEC_REVISION_SM1, > }; > + > +MODULE_FIRMWARE("meson/vdec/g12a_h264.bin"); > +MODULE_FIRMWARE("meson/vdec/g12a_h264.bin"); Duplicate > +MODULE_FIRMWARE("meson/vdec/g12a_vp9.bin"); > +MODULE_FIRMWARE("meson/vdec/gxbb_h264.bin"); > +MODULE_FIRMWARE("meson/vdec/gxl_h264.bin"); > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin"); > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin"); > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin"); > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin"); > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin"); > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin"); > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin"); > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin"); > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin"); > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin"); DDDDDDDuplicate > +MODULE_FIRMWARE("meson/vdec/gxl_vp9.bin"); > +MODULE_FIRMWARE("meson/vdec/gxl_vp9.bin"); Duplicate > +MODULE_FIRMWARE("meson/vdec/gxm_h264.bin"); > +MODULE_FIRMWARE("meson/vdec/sm1_vp9_mmu.bin"); With the duplicate entries removed, please add my: Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
On Wed, 17 Aug 2022 18:08:19 +0200 Neil Armstrong <narmstrong@baylibre.com> wrote: > On 17/08/2022 16:05, Juerg Haefliger wrote: > > The meson-vdec module loads firmware so add MODULE_FIRMWARE macros to > > provide that information via modinfo. > > > > Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com> > > --- > > .../staging/media/meson/vdec/vdec_platform.c | 20 +++++++++++++++++++ > > 1 file changed, 20 insertions(+) > > > > diff --git a/drivers/staging/media/meson/vdec/vdec_platform.c b/drivers/staging/media/meson/vdec/vdec_platform.c > > index 88c9d72e1c83..c7750d4be848 100644 > > --- a/drivers/staging/media/meson/vdec/vdec_platform.c > > +++ b/drivers/staging/media/meson/vdec/vdec_platform.c > > @@ -280,3 +280,23 @@ const struct vdec_platform vdec_platform_sm1 = { > > .num_formats = ARRAY_SIZE(vdec_formats_sm1), > > .revision = VDEC_REVISION_SM1, > > }; > > + > > +MODULE_FIRMWARE("meson/vdec/g12a_h264.bin"); > > +MODULE_FIRMWARE("meson/vdec/g12a_h264.bin"); > > Duplicate Oh this is embarrassing :-( > > +MODULE_FIRMWARE("meson/vdec/g12a_vp9.bin"); > > +MODULE_FIRMWARE("meson/vdec/gxbb_h264.bin"); > > +MODULE_FIRMWARE("meson/vdec/gxl_h264.bin"); > > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin"); > > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin"); > > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin"); > > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin"); > > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin"); > > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin"); > > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin"); > > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin"); > > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin"); > > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin"); > > DDDDDDDuplicate > > > +MODULE_FIRMWARE("meson/vdec/gxl_vp9.bin"); > > +MODULE_FIRMWARE("meson/vdec/gxl_vp9.bin"); > > Duplicate > > > +MODULE_FIRMWARE("meson/vdec/gxm_h264.bin"); > > +MODULE_FIRMWARE("meson/vdec/sm1_vp9_mmu.bin"); > > With the duplicate entries removed, please add my: > Reviewed-by: Neil Armstrong <narmstrong@baylibre.com> Will do. Thanks for the review. ...Juerg
diff --git a/drivers/staging/media/meson/vdec/vdec_platform.c b/drivers/staging/media/meson/vdec/vdec_platform.c index 88c9d72e1c83..c7750d4be848 100644 --- a/drivers/staging/media/meson/vdec/vdec_platform.c +++ b/drivers/staging/media/meson/vdec/vdec_platform.c @@ -280,3 +280,23 @@ const struct vdec_platform vdec_platform_sm1 = { .num_formats = ARRAY_SIZE(vdec_formats_sm1), .revision = VDEC_REVISION_SM1, }; + +MODULE_FIRMWARE("meson/vdec/g12a_h264.bin"); +MODULE_FIRMWARE("meson/vdec/g12a_h264.bin"); +MODULE_FIRMWARE("meson/vdec/g12a_vp9.bin"); +MODULE_FIRMWARE("meson/vdec/gxbb_h264.bin"); +MODULE_FIRMWARE("meson/vdec/gxl_h264.bin"); +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin"); +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin"); +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin"); +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin"); +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin"); +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin"); +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin"); +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin"); +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin"); +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin"); +MODULE_FIRMWARE("meson/vdec/gxl_vp9.bin"); +MODULE_FIRMWARE("meson/vdec/gxl_vp9.bin"); +MODULE_FIRMWARE("meson/vdec/gxm_h264.bin"); +MODULE_FIRMWARE("meson/vdec/sm1_vp9_mmu.bin");
The meson-vdec module loads firmware so add MODULE_FIRMWARE macros to provide that information via modinfo. Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com> --- .../staging/media/meson/vdec/vdec_platform.c | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+)