| Message ID | 20230110215926.1296650-1-martin.blumenstingl@googlemail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: meson-gxl: jethub-j80: Fix WiFi MAC unit address | expand |
On 11/01/2023 00.59, Martin Blumenstingl wrote: > Unit addresses should be written using lower-case hex characters. Use > wifi_mac@c to fix a yaml schema validation error once the eFuse > dt-bindings have been converted to a yaml schema: > efuse: Unevaluated properties are not allowed ('wifi_mac@C' was > unexpected) > > Fixes: abfaae24ecf3 ("arm64: dts: meson-gxl: add support for JetHub H1") > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > --- > .../boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts > index 6831137c5c10..4f742e1b9301 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts > +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts > @@ -90,7 +90,7 @@ bt_mac: bt_mac@6 { > reg = <0x6 0x6>; > }; > > - wifi_mac: wifi_mac@C { > + wifi_mac: wifi_mac@c { > reg = <0xc 0x6>; > }; > }; Acked-by: Vyachesav Bocharov <adeep@lexina.in>
On 10/01/2023 22:59, Martin Blumenstingl wrote: > Unit addresses should be written using lower-case hex characters. Use > wifi_mac@c to fix a yaml schema validation error once the eFuse > dt-bindings have been converted to a yaml schema: > efuse: Unevaluated properties are not allowed ('wifi_mac@C' was > unexpected) > > Fixes: abfaae24ecf3 ("arm64: dts: meson-gxl: add support for JetHub H1") > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > --- > .../boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts > index 6831137c5c10..4f742e1b9301 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts > +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts > @@ -90,7 +90,7 @@ bt_mac: bt_mac@6 { > reg = <0x6 0x6>; > }; > > - wifi_mac: wifi_mac@C { > + wifi_mac: wifi_mac@c { While fixing the unit address, maybe also fix the node name - underscores are cause warnings and should be replaced with hyphens. Best regards, Krzysztof
On 11/01/2023 14:20, Vyacheslav wrote: > Hi. > > arch/arm64/boot/dts/amlogic/meson-gx.dtsi > > line 236 has eth_mac: eth_mac@34 > > * Should that be fixed too? In general all incorrect namings should be fixed, but I proposed to combined it here since this was touching this line anyway. Change of case in address is same as other style cleanups (like underscores), so just do it once. Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts index 6831137c5c10..4f742e1b9301 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts @@ -90,7 +90,7 @@ bt_mac: bt_mac@6 { reg = <0x6 0x6>; }; - wifi_mac: wifi_mac@C { + wifi_mac: wifi_mac@c { reg = <0xc 0x6>; }; };
Unit addresses should be written using lower-case hex characters. Use wifi_mac@c to fix a yaml schema validation error once the eFuse dt-bindings have been converted to a yaml schema: efuse: Unevaluated properties are not allowed ('wifi_mac@C' was unexpected) Fixes: abfaae24ecf3 ("arm64: dts: meson-gxl: add support for JetHub H1") Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> --- .../boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)