| Message ID | 20230125072605.1121-5-linux.amoon@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Used onboard HUB to reset and add power to hub | expand |
On 25/01/2023 08:26, Anand Moon wrote: > Cleanup by removing unneeded quotes from refs and > add maxItems to reset-gpios and fix the required list. > > Fixes: 31360c28dfdd ("dt-bindings: usb: Add binding for Via lab VL817 hub controller") > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> NAK. You ignored my feedback. Please help me understand how my tag appeared here. Best regards, Krzysztof
Hi Krzysztof, On Wed, 25 Jan 2023 at 13:10, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 25/01/2023 08:26, Anand Moon wrote: > > Cleanup by removing unneeded quotes from refs and > > add maxItems to reset-gpios and fix the required list. > > > > Fixes: 31360c28dfdd ("dt-bindings: usb: Add binding for Via lab VL817 hub controller") > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > NAK. > > You ignored my feedback. Please help me understand how my tag appeared here. > I have followed your feedback and modified the below patch I thought you review these changes see below. [0] https://lore.kernel.org/all/df1c8545-01d0-3821-0c19-07a369e40472@linaro.org/ > Best regards, > Krzysztof > Thanks -Anand
On 25/01/2023 10:43, Anand Moon wrote: > Hi Krzysztof, > > On Wed, 25 Jan 2023 at 13:10, Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> On 25/01/2023 08:26, Anand Moon wrote: >>> Cleanup by removing unneeded quotes from refs and >>> add maxItems to reset-gpios and fix the required list. >>> >>> Fixes: 31360c28dfdd ("dt-bindings: usb: Add binding for Via lab VL817 hub controller") >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> >> NAK. >> >> You ignored my feedback. Please help me understand how my tag appeared here. >> > I have followed your feedback and modified the below patch > I thought you review these changes see below. > > [0] https://lore.kernel.org/all/df1c8545-01d0-3821-0c19-07a369e40472@linaro.org/ This was entirely different patch. You cannot take reviews from something else and apply to other patch. Best regards, Krzysztof
Hi Krzysztof, On Wed, 25 Jan 2023 at 15:27, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 25/01/2023 10:43, Anand Moon wrote: > > Hi Krzysztof, > > > > On Wed, 25 Jan 2023 at 13:10, Krzysztof Kozlowski > > <krzysztof.kozlowski@linaro.org> wrote: > >> > >> On 25/01/2023 08:26, Anand Moon wrote: > >>> Cleanup by removing unneeded quotes from refs and > >>> add maxItems to reset-gpios and fix the required list. > >>> > >>> Fixes: 31360c28dfdd ("dt-bindings: usb: Add binding for Via lab VL817 hub controller") > >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >> > >> NAK. > >> > >> You ignored my feedback. Please help me understand how my tag appeared here. > >> > > I have followed your feedback and modified the below patch > > I thought you review these changes see below. > > > > [0] https://lore.kernel.org/all/df1c8545-01d0-3821-0c19-07a369e40472@linaro.org/ > > This was entirely different patch. You cannot take reviews from > something else and apply to other patch. > > Best regards, > Krzysztof > ok, I will keep this in my mind. Thanks -Anand
diff --git a/Documentation/devicetree/bindings/usb/vialab,vl817.yaml b/Documentation/devicetree/bindings/usb/vialab,vl817.yaml index 5f9771e22058..23a13e1d5c7a 100644 --- a/Documentation/devicetree/bindings/usb/vialab,vl817.yaml +++ b/Documentation/devicetree/bindings/usb/vialab,vl817.yaml @@ -14,29 +14,32 @@ allOf: properties: compatible: - items: - - enum: - - usb2109,2817 - - usb2109,817 + enum: + - usb2109,2817 + - usb2109,817 reg: true reset-gpios: - description: GPIO controlling the RESET# pin. + maxItems: 1 + description: + GPIO controlling the RESET# pin. vdd-supply: description: phandle to the regulator that provides power to the hub. peer-hub: - $ref: '/schemas/types.yaml#/definitions/phandle' + $ref: /schemas/types.yaml#/definitions/phandle description: phandle to the peer hub on the controller. required: - - peer-hub - compatible - reg + - reset-gpios + - vdd-supply + - peer-hub additionalProperties: false @@ -45,7 +48,6 @@ examples: #include <dt-bindings/gpio/gpio.h> usb { - dr_mode = "host"; #address-cells = <1>; #size-cells = <0>;
Cleanup by removing unneeded quotes from refs and add maxItems to reset-gpios and fix the required list. Fixes: 31360c28dfdd ("dt-bindings: usb: Add binding for Via lab VL817 hub controller") Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Signed-off-by: Anand Moon <linux.amoon@gmail.com> --- .../devicetree/bindings/usb/vialab,vl817.yaml | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-)