diff mbox series

pinctrl: meson-axg: add missing GPIOA_18 gpio group

Message ID 20230510141934.112994-1-martin@geanix.com (mailing list archive)
State Superseded
Headers show
Series pinctrl: meson-axg: add missing GPIOA_18 gpio group | expand

Commit Message

Martin Hundebøll May 10, 2023, 2:19 p.m. UTC
Without this, the gpio cannot be explicitly mux'ed to its gpio function.

Fixes: 83c566806a68a ("pinctrl: meson-axg: Add new pinctrl driver for Meson AXG SoC")
Signed-off-by: Martin Hundebøll <martin@geanix.com>
---
 drivers/pinctrl/meson/pinctrl-meson-axg.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Greg KH May 10, 2023, 2:40 p.m. UTC | #1
On Wed, May 10, 2023 at 04:19:34PM +0200, Martin Hundebøll wrote:
> Without this, the gpio cannot be explicitly mux'ed to its gpio function.
> 
> Fixes: 83c566806a68a ("pinctrl: meson-axg: Add new pinctrl driver for Meson AXG SoC")
> Signed-off-by: Martin Hundebøll <martin@geanix.com>
> ---
>  drivers/pinctrl/meson/pinctrl-meson-axg.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pinctrl/meson/pinctrl-meson-axg.c b/drivers/pinctrl/meson/pinctrl-meson-axg.c
> index 7bfecdfba177..d249a035c2b9 100644
> --- a/drivers/pinctrl/meson/pinctrl-meson-axg.c
> +++ b/drivers/pinctrl/meson/pinctrl-meson-axg.c
> @@ -400,6 +400,7 @@ static struct meson_pmx_group meson_axg_periphs_groups[] = {
>  	GPIO_GROUP(GPIOA_15),
>  	GPIO_GROUP(GPIOA_16),
>  	GPIO_GROUP(GPIOA_17),
> +	GPIO_GROUP(GPIOA_18),
>  	GPIO_GROUP(GPIOA_19),
>  	GPIO_GROUP(GPIOA_20),
>  
> -- 
> 2.34.1
> 

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>
Neil Armstrong May 10, 2023, 2:58 p.m. UTC | #2
Hi,

On 10/05/2023 16:19, Martin Hundebøll wrote:
> Without this, the gpio cannot be explicitly mux'ed to its gpio function.
> 
> Fixes: 83c566806a68a ("pinctrl: meson-axg: Add new pinctrl driver for Meson AXG SoC")
> Signed-off-by: Martin Hundebøll <martin@geanix.com>
> ---
>   drivers/pinctrl/meson/pinctrl-meson-axg.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pinctrl/meson/pinctrl-meson-axg.c b/drivers/pinctrl/meson/pinctrl-meson-axg.c
> index 7bfecdfba177..d249a035c2b9 100644
> --- a/drivers/pinctrl/meson/pinctrl-meson-axg.c
> +++ b/drivers/pinctrl/meson/pinctrl-meson-axg.c
> @@ -400,6 +400,7 @@ static struct meson_pmx_group meson_axg_periphs_groups[] = {
>   	GPIO_GROUP(GPIOA_15),
>   	GPIO_GROUP(GPIOA_16),
>   	GPIO_GROUP(GPIOA_17),
> +	GPIO_GROUP(GPIOA_18),
>   	GPIO_GROUP(GPIOA_19),
>   	GPIO_GROUP(GPIOA_20),
>   

You're missing some mailing-lists and maintainers in CC, please see output of get_maintainers.

Neil
diff mbox series

Patch

diff --git a/drivers/pinctrl/meson/pinctrl-meson-axg.c b/drivers/pinctrl/meson/pinctrl-meson-axg.c
index 7bfecdfba177..d249a035c2b9 100644
--- a/drivers/pinctrl/meson/pinctrl-meson-axg.c
+++ b/drivers/pinctrl/meson/pinctrl-meson-axg.c
@@ -400,6 +400,7 @@  static struct meson_pmx_group meson_axg_periphs_groups[] = {
 	GPIO_GROUP(GPIOA_15),
 	GPIO_GROUP(GPIOA_16),
 	GPIO_GROUP(GPIOA_17),
+	GPIO_GROUP(GPIOA_18),
 	GPIO_GROUP(GPIOA_19),
 	GPIO_GROUP(GPIOA_20),