diff mbox series

tty: serial: meson: Add a earlycon for the S4 SoC

Message ID 20230828121053.60838-1-tanure@linux.com (mailing list archive)
State Superseded
Headers show
Series tty: serial: meson: Add a earlycon for the S4 SoC | expand

Commit Message

Lucas Tanure Aug. 28, 2023, 12:10 p.m. UTC
The new Amlogic S4 SoC does not have a always-on uart, so add
OF_EARLYCON_DECLARE for it.

Signed-off-by: Lucas Tanure <tanure@linux.com>
---
 drivers/tty/serial/meson_uart.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Neil Armstrong Aug. 28, 2023, 12:16 p.m. UTC | #1
Hi,

On 28/08/2023 14:10, Lucas Tanure wrote:
> The new Amlogic S4 SoC does not have a always-on uart, so add
> OF_EARLYCON_DECLARE for it.
> 
> Signed-off-by: Lucas Tanure <tanure@linux.com>
> ---
>   drivers/tty/serial/meson_uart.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c
> index 790d910dafa5..8dfaa260e545 100644
> --- a/drivers/tty/serial/meson_uart.c
> +++ b/drivers/tty/serial/meson_uart.c
> @@ -646,8 +646,8 @@ meson_serial_early_console_setup(struct earlycon_device *device, const char *opt
>   	return 0;
>   }
>   
> -OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart",
> -		    meson_serial_early_console_setup);
> +OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart", meson_serial_early_console_setup);
> +OF_EARLYCON_DECLARE(meson, "amlogic,meson-s4-uart", meson_serial_early_console_setup);

Not sure why you would change both lines, and where's the t7 entry ?

Neil

>   
>   #define MESON_SERIAL_CONSOLE_PTR(_devname) (&meson_serial_console_##_devname)
>   #else
Lucas Tanure Aug. 28, 2023, 12:26 p.m. UTC | #2
On Mon, Aug 28, 2023 at 1:16 PM Neil Armstrong
<neil.armstrong@linaro.org> wrote:
>
> Hi,
>
> On 28/08/2023 14:10, Lucas Tanure wrote:
> > The new Amlogic S4 SoC does not have a always-on uart, so add
> > OF_EARLYCON_DECLARE for it.
> >
> > Signed-off-by: Lucas Tanure <tanure@linux.com>
> > ---
> >   drivers/tty/serial/meson_uart.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c
> > index 790d910dafa5..8dfaa260e545 100644
> > --- a/drivers/tty/serial/meson_uart.c
> > +++ b/drivers/tty/serial/meson_uart.c
> > @@ -646,8 +646,8 @@ meson_serial_early_console_setup(struct earlycon_device *device, const char *opt
> >       return 0;
> >   }
> >
> > -OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart",
> > -                 meson_serial_early_console_setup);
> > +OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart", meson_serial_early_console_setup);
> > +OF_EARLYCON_DECLARE(meson, "amlogic,meson-s4-uart", meson_serial_early_console_setup);
>
> Not sure why you would change both lines, and where's the t7 entry ?
ok, but we don't need t7, right? T7 will use S4 compatible line.
>
> Neil
>
> >
> >   #define MESON_SERIAL_CONSOLE_PTR(_devname) (&meson_serial_console_##_devname)
> >   #else
>
Neil Armstrong Aug. 28, 2023, 12:30 p.m. UTC | #3
Hi,

On 28/08/2023 14:26, Lucas Tanure wrote:
> On Mon, Aug 28, 2023 at 1:16 PM Neil Armstrong
> <neil.armstrong@linaro.org> wrote:
>>
>> Hi,
>>
>> On 28/08/2023 14:10, Lucas Tanure wrote:
>>> The new Amlogic S4 SoC does not have a always-on uart, so add
>>> OF_EARLYCON_DECLARE for it.
>>>
>>> Signed-off-by: Lucas Tanure <tanure@linux.com>
>>> ---
>>>    drivers/tty/serial/meson_uart.c | 4 ++--
>>>    1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c
>>> index 790d910dafa5..8dfaa260e545 100644
>>> --- a/drivers/tty/serial/meson_uart.c
>>> +++ b/drivers/tty/serial/meson_uart.c
>>> @@ -646,8 +646,8 @@ meson_serial_early_console_setup(struct earlycon_device *device, const char *opt
>>>        return 0;
>>>    }
>>>
>>> -OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart",
>>> -                 meson_serial_early_console_setup);
>>> +OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart", meson_serial_early_console_setup);
>>> +OF_EARLYCON_DECLARE(meson, "amlogic,meson-s4-uart", meson_serial_early_console_setup);
>>
>> Not sure why you would change both lines, and where's the t7 entry ?
> ok, but we don't need t7, right? T7 will use S4 compatible line.

Indeed, I forget you finally used amlogic,meson-s4-uart as fallback.

Please indicate this in the commit message.

I'll ack the revert then,

Thanks,
Neil

>>
>> Neil
>>
>>>
>>>    #define MESON_SERIAL_CONSOLE_PTR(_devname) (&meson_serial_console_##_devname)
>>>    #else
>>
diff mbox series

Patch

diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c
index 790d910dafa5..8dfaa260e545 100644
--- a/drivers/tty/serial/meson_uart.c
+++ b/drivers/tty/serial/meson_uart.c
@@ -646,8 +646,8 @@  meson_serial_early_console_setup(struct earlycon_device *device, const char *opt
 	return 0;
 }
 
-OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart",
-		    meson_serial_early_console_setup);
+OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart", meson_serial_early_console_setup);
+OF_EARLYCON_DECLARE(meson, "amlogic,meson-s4-uart", meson_serial_early_console_setup);
 
 #define MESON_SERIAL_CONSOLE_PTR(_devname) (&meson_serial_console_##_devname)
 #else