| Message ID | 20240130150340.687871-4-vignesh.raman@collabora.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | drm/ci: Add support for GPU and display testing | expand |
On 30/01/2024 12:03, Vignesh Raman wrote: > For mediatek mt8173, the GPU driver is powervr and for mediatek > mt8183, the GPU driver is panfrost. So add support in drm-ci to > test panfrost and powervr GPU driver for mediatek SOCs and update > xfails. Powervr driver was merged in linux kernel, but there's no > mediatek support yet. So disable the mt8173-gpu job which uses > powervr driver. > > Add panfrost specific tests to testlist and skip KMS tests for > panfrost driver since it is not a not a KMS driver. Also update > the MAINTAINERS file to include xfails for panfrost driver. > > Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com> Hi Vignesh, thanks for your work. I'm still wondering about a few things, please check below. > --- > > v2: > - Add panfrost and PVR GPU jobs for mediatek SOC with new xfails, add xfail > entry to MAINTAINERS. Maybe we should review how the xfails failes are named. I think they should start with the DRIVER_NAME instead of GPU_VERSION. For instance, consider the following job: mediatek:mt8183-gpu: extends: - .mt8183 variables: GPU_VERSION: mediatek-mt8183-gpu DRIVER_NAME: panfrost And we have mediatek-mt8183-gpu-skips.txt If there is an error, we want to notify the panfrost driver maintainers (and maybe not the mediatek driver maintainers), so MAINTAINERS file doesn't correspond to this. How about a naming <driver name>_<hardware/gpu>_<type: gpu/display> ? powervr_mediatek-mt8173_gpu-skipts.txt mediatek_mediatek-mt8173_display-skipts.txt panfrost_mediatek-mt8183_gpu-skips.txt mediatek_mediatek-mt8183_display-skips.txt ... What do you think? Thanks Helen > > v3: > - Add panfrost specific tests to testlist and skip KMS tests for > panfrost driver since it is not a not a KMS driver and update xfails. > Update the MAINTAINERS file to include xfails for panfrost driver. > Add the job name in GPU_VERSION and use it for xfail file names instead > of using DRIVER_NAME. > > --- > MAINTAINERS | 1 + > drivers/gpu/drm/ci/test.yml | 18 ++++++++++++++++++ > drivers/gpu/drm/ci/testlist.txt | 16 ++++++++++++++++ > .../ci/xfails/mediatek-mt8183-gpu-skips.txt | 2 ++ > 4 files changed, 37 insertions(+) > create mode 100644 drivers/gpu/drm/ci/xfails/mediatek-mt8183-gpu-skips.txt > > diff --git a/MAINTAINERS b/MAINTAINERS > index 9d959a6881f7..bcdc17d1aa26 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1645,6 +1645,7 @@ L: dri-devel@lists.freedesktop.org > S: Supported > T: git git://anongit.freedesktop.org/drm/drm-misc > F: Documentation/gpu/panfrost.rst > +F: drivers/gpu/drm/ci/xfails/panfrost* > F: drivers/gpu/drm/panfrost/ > F: include/uapi/drm/panfrost_drm.h > > diff --git a/drivers/gpu/drm/ci/test.yml b/drivers/gpu/drm/ci/test.yml > index 0cd44e6ea18b..e153c5a7ad80 100644 > --- a/drivers/gpu/drm/ci/test.yml > +++ b/drivers/gpu/drm/ci/test.yml > @@ -299,6 +299,17 @@ amdgpu:stoney: > DEVICE_TYPE: mt8183-kukui-jacuzzi-juniper-sku16 > RUNNER_TAG: mesa-ci-x86-64-lava-mt8183-kukui-jacuzzi-juniper-sku16 > > +mediatek:mt8173-gpu: > + extends: > + - .mt8173 > + variables: > + GPU_VERSION: mediatek-mt8173-gpu > + DRIVER_NAME: powervr > + rules: > + # TODO: powervr driver was merged in linux kernel, but there's no mediatek support yet > + # Remove the rule once mediatek support is added for powervr > + - when: never > + > mediatek:mt8173-display: > extends: > - .mt8173 > @@ -306,6 +317,13 @@ mediatek:mt8173-display: > GPU_VERSION: mediatek-mt8173-display > DRIVER_NAME: mediatek > > +mediatek:mt8183-gpu: > + extends: > + - .mt8183 > + variables: > + GPU_VERSION: mediatek-mt8183-gpu > + DRIVER_NAME: panfrost > + > mediatek:mt8183-display: > extends: > - .mt8183 > diff --git a/drivers/gpu/drm/ci/testlist.txt b/drivers/gpu/drm/ci/testlist.txt > index eaeb751bb0ad..772fc025b1f8 100644 > --- a/drivers/gpu/drm/ci/testlist.txt > +++ b/drivers/gpu/drm/ci/testlist.txt > @@ -2959,3 +2959,19 @@ msm_submit@invalid-duplicate-bo-submit > msm_submit@invalid-cmd-idx-submit > msm_submit@invalid-cmd-type-submit > msm_submit@valid-submit > +panfrost_get_param@base-params > +panfrost_get_param@get-bad-param > +panfrost_get_param@get-bad-padding > +panfrost_gem_new@gem-new-4096 > +panfrost_gem_new@gem-new-0 > +panfrost_gem_new@gem-new-zeroed > +panfrost_prime@gem-prime-import > +panfrost_submit@pan-submit > +panfrost_submit@pan-submit-error-no-jc > +panfrost_submit@pan-submit-error-bad-in-syncs > +panfrost_submit@pan-submit-error-bad-bo-handles > +panfrost_submit@pan-submit-error-bad-requirements > +panfrost_submit@pan-submit-error-bad-out-sync > +panfrost_submit@pan-reset > +panfrost_submit@pan-submit-and-close > +panfrost_submit@pan-unhandled-pagefault > diff --git a/drivers/gpu/drm/ci/xfails/mediatek-mt8183-gpu-skips.txt b/drivers/gpu/drm/ci/xfails/mediatek-mt8183-gpu-skips.txt > new file mode 100644 > index 000000000000..2ea09d1648bc > --- /dev/null > +++ b/drivers/gpu/drm/ci/xfails/mediatek-mt8183-gpu-skips.txt > @@ -0,0 +1,2 @@ > +# Panfrost is not a KMS driver, so skip the KMS tests > +kms_.*
Hi Helen, On 09/02/24 23:51, Helen Koike wrote: > > > On 30/01/2024 12:03, Vignesh Raman wrote: >> For mediatek mt8173, the GPU driver is powervr and for mediatek >> mt8183, the GPU driver is panfrost. So add support in drm-ci to >> test panfrost and powervr GPU driver for mediatek SOCs and update >> xfails. Powervr driver was merged in linux kernel, but there's no >> mediatek support yet. So disable the mt8173-gpu job which uses >> powervr driver. >> >> Add panfrost specific tests to testlist and skip KMS tests for >> panfrost driver since it is not a not a KMS driver. Also update >> the MAINTAINERS file to include xfails for panfrost driver. >> >> Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com> > > Hi Vignesh, thanks for your work. > > I'm still wondering about a few things, please check below. > >> --- >> >> v2: >> - Add panfrost and PVR GPU jobs for mediatek SOC with new xfails, >> add xfail >> entry to MAINTAINERS. > > Maybe we should review how the xfails failes are named. I think they > should start with the DRIVER_NAME instead of GPU_VERSION. > > For instance, consider the following job: > > mediatek:mt8183-gpu: > extends: > - .mt8183 > variables: > GPU_VERSION: mediatek-mt8183-gpu > DRIVER_NAME: panfrost > > And we have mediatek-mt8183-gpu-skips.txt > > If there is an error, we want to notify the panfrost driver maintainers > (and maybe not the mediatek driver maintainers), so MAINTAINERS file > doesn't correspond to this. Agree. > > How about a naming <driver name>_<hardware/gpu>_<type: gpu/display> ? > > powervr_mediatek-mt8173_gpu-skipts.txt > mediatek_mediatek-mt8173_display-skipts.txt > panfrost_mediatek-mt8183_gpu-skips.txt > mediatek_mediatek-mt8183_display-skips.txt > ... > > What do you think? Yes we can keep this naming. In this case do we still need gpu/display in the xfails file name? Regards, Vignesh
On 19/02/2024 06:39, Vignesh Raman wrote: > Hi Helen, > > On 09/02/24 23:51, Helen Koike wrote: >> >> >> On 30/01/2024 12:03, Vignesh Raman wrote: >>> For mediatek mt8173, the GPU driver is powervr and for mediatek >>> mt8183, the GPU driver is panfrost. So add support in drm-ci to >>> test panfrost and powervr GPU driver for mediatek SOCs and update >>> xfails. Powervr driver was merged in linux kernel, but there's no >>> mediatek support yet. So disable the mt8173-gpu job which uses >>> powervr driver. >>> >>> Add panfrost specific tests to testlist and skip KMS tests for >>> panfrost driver since it is not a not a KMS driver. Also update >>> the MAINTAINERS file to include xfails for panfrost driver. >>> >>> Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com> >> >> Hi Vignesh, thanks for your work. >> >> I'm still wondering about a few things, please check below. >> >>> --- >>> >>> v2: >>> - Add panfrost and PVR GPU jobs for mediatek SOC with new xfails, >>> add xfail >>> entry to MAINTAINERS. >> >> Maybe we should review how the xfails failes are named. I think they >> should start with the DRIVER_NAME instead of GPU_VERSION. >> >> For instance, consider the following job: >> >> mediatek:mt8183-gpu: >> extends: >> - .mt8183 >> variables: >> GPU_VERSION: mediatek-mt8183-gpu >> DRIVER_NAME: panfrost >> >> And we have mediatek-mt8183-gpu-skips.txt >> >> If there is an error, we want to notify the panfrost driver >> maintainers (and maybe not the mediatek driver maintainers), so >> MAINTAINERS file doesn't correspond to this. > > Agree. > >> >> How about a naming <driver name>_<hardware/gpu>_<type: gpu/display> ? >> >> powervr_mediatek-mt8173_gpu-skipts.txt >> mediatek_mediatek-mt8173_display-skipts.txt >> panfrost_mediatek-mt8183_gpu-skips.txt >> mediatek_mediatek-mt8183_display-skips.txt >> ... >> >> What do you think? > > Yes we can keep this naming. In this case do we still need gpu/display > in the xfails file name? If you think this split is not required, then I'm fine dropping it. Regards, Helen > > Regards, > Vignesh
diff --git a/MAINTAINERS b/MAINTAINERS index 9d959a6881f7..bcdc17d1aa26 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1645,6 +1645,7 @@ L: dri-devel@lists.freedesktop.org S: Supported T: git git://anongit.freedesktop.org/drm/drm-misc F: Documentation/gpu/panfrost.rst +F: drivers/gpu/drm/ci/xfails/panfrost* F: drivers/gpu/drm/panfrost/ F: include/uapi/drm/panfrost_drm.h diff --git a/drivers/gpu/drm/ci/test.yml b/drivers/gpu/drm/ci/test.yml index 0cd44e6ea18b..e153c5a7ad80 100644 --- a/drivers/gpu/drm/ci/test.yml +++ b/drivers/gpu/drm/ci/test.yml @@ -299,6 +299,17 @@ amdgpu:stoney: DEVICE_TYPE: mt8183-kukui-jacuzzi-juniper-sku16 RUNNER_TAG: mesa-ci-x86-64-lava-mt8183-kukui-jacuzzi-juniper-sku16 +mediatek:mt8173-gpu: + extends: + - .mt8173 + variables: + GPU_VERSION: mediatek-mt8173-gpu + DRIVER_NAME: powervr + rules: + # TODO: powervr driver was merged in linux kernel, but there's no mediatek support yet + # Remove the rule once mediatek support is added for powervr + - when: never + mediatek:mt8173-display: extends: - .mt8173 @@ -306,6 +317,13 @@ mediatek:mt8173-display: GPU_VERSION: mediatek-mt8173-display DRIVER_NAME: mediatek +mediatek:mt8183-gpu: + extends: + - .mt8183 + variables: + GPU_VERSION: mediatek-mt8183-gpu + DRIVER_NAME: panfrost + mediatek:mt8183-display: extends: - .mt8183 diff --git a/drivers/gpu/drm/ci/testlist.txt b/drivers/gpu/drm/ci/testlist.txt index eaeb751bb0ad..772fc025b1f8 100644 --- a/drivers/gpu/drm/ci/testlist.txt +++ b/drivers/gpu/drm/ci/testlist.txt @@ -2959,3 +2959,19 @@ msm_submit@invalid-duplicate-bo-submit msm_submit@invalid-cmd-idx-submit msm_submit@invalid-cmd-type-submit msm_submit@valid-submit +panfrost_get_param@base-params +panfrost_get_param@get-bad-param +panfrost_get_param@get-bad-padding +panfrost_gem_new@gem-new-4096 +panfrost_gem_new@gem-new-0 +panfrost_gem_new@gem-new-zeroed +panfrost_prime@gem-prime-import +panfrost_submit@pan-submit +panfrost_submit@pan-submit-error-no-jc +panfrost_submit@pan-submit-error-bad-in-syncs +panfrost_submit@pan-submit-error-bad-bo-handles +panfrost_submit@pan-submit-error-bad-requirements +panfrost_submit@pan-submit-error-bad-out-sync +panfrost_submit@pan-reset +panfrost_submit@pan-submit-and-close +panfrost_submit@pan-unhandled-pagefault diff --git a/drivers/gpu/drm/ci/xfails/mediatek-mt8183-gpu-skips.txt b/drivers/gpu/drm/ci/xfails/mediatek-mt8183-gpu-skips.txt new file mode 100644 index 000000000000..2ea09d1648bc --- /dev/null +++ b/drivers/gpu/drm/ci/xfails/mediatek-mt8183-gpu-skips.txt @@ -0,0 +1,2 @@ +# Panfrost is not a KMS driver, so skip the KMS tests +kms_.*
For mediatek mt8173, the GPU driver is powervr and for mediatek mt8183, the GPU driver is panfrost. So add support in drm-ci to test panfrost and powervr GPU driver for mediatek SOCs and update xfails. Powervr driver was merged in linux kernel, but there's no mediatek support yet. So disable the mt8173-gpu job which uses powervr driver. Add panfrost specific tests to testlist and skip KMS tests for panfrost driver since it is not a not a KMS driver. Also update the MAINTAINERS file to include xfails for panfrost driver. Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com> --- v2: - Add panfrost and PVR GPU jobs for mediatek SOC with new xfails, add xfail entry to MAINTAINERS. v3: - Add panfrost specific tests to testlist and skip KMS tests for panfrost driver since it is not a not a KMS driver and update xfails. Update the MAINTAINERS file to include xfails for panfrost driver. Add the job name in GPU_VERSION and use it for xfail file names instead of using DRIVER_NAME. --- MAINTAINERS | 1 + drivers/gpu/drm/ci/test.yml | 18 ++++++++++++++++++ drivers/gpu/drm/ci/testlist.txt | 16 ++++++++++++++++ .../ci/xfails/mediatek-mt8183-gpu-skips.txt | 2 ++ 4 files changed, 37 insertions(+) create mode 100644 drivers/gpu/drm/ci/xfails/mediatek-mt8183-gpu-skips.txt