From patchwork Mon Jun 17 13:50:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Trevor Gamblin X-Patchwork-Id: 13700784 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9169BC27C79 for ; Mon, 17 Jun 2024 13:52:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=B0DHYaBhSJ4cvW7/FSy6BQFoUs4R+i7l2xsOgRmhapI=; b=cVtw17OoJazxVS Wd7jbB1qYjuu7fjoRQKTbuYNLn+WrojeJheCWpDVNNZbisfY0v/FwpYev1zLm1/IvqhYVJWRg+Czd nLGo3VJfjEnBRsY2g0jJXQZHT3h3gqCo24o6dqpYgWsKzZKs33ONR3hO7ucl0cZTGnfMYOEAfCzFO rFBheuJN0epcoyk0VbUULaS8ziYnYB2ZtUlKQ0S7804B913dHElaAoBoUQ1ISaAkiT3oYbQzkGALO KEkIkyGwSkAFDdVgVmtS+S7GCLihw2CfY7GVCRolUvo9y0R0TL7gD6967pb0XcdS/RWVME+bqhobV em+pg+7yQqS8nQQHDupA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJCmU-0000000Ayd4-0hjS; Mon, 17 Jun 2024 13:52:22 +0000 Received: from mail-qk1-x733.google.com ([2607:f8b0:4864:20::733]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJCke-0000000AxFj-3wxP for linux-amlogic@lists.infradead.org; Mon, 17 Jun 2024 13:50:41 +0000 Received: by mail-qk1-x733.google.com with SMTP id af79cd13be357-79767180a15so302145885a.1 for ; Mon, 17 Jun 2024 06:50:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1718632228; x=1719237028; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=/XakTIALlxEv0HYj2MxlbOtZFxZOxjUYZWhXJH4zlh0=; b=Y4kbC2qzRBRLdhdJRHO7JuMrWj2eL27tKZfHfvBlxnaTKV+i7BQfnBszyAgu3ZBsaJ tLpTGCz7yzxXCl+nT2MYfFM7agRM4fvdn+cKwGU6FCgrU6xEHylj7us2IBIy0L8WYqvo //YIE5B8aOm8UJmASb6FlvwqR5vuJX9Y/kDG4yXLLTfHPldY+gSpe/ojMjWNipIdlwKB kTrsBArDKrGbqtK3va48rPcwgX/8mc8fkgMFhwWvEc9JmKIKneK7nezplPlRsjjkfhDK /uiV9N8IWrj7FvZoCluKEjxU8+PhrwnTFCBGTKqbL1aUREqOeAn738MmNler6n4bZcsK VkAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718632228; x=1719237028; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/XakTIALlxEv0HYj2MxlbOtZFxZOxjUYZWhXJH4zlh0=; b=vejyEOsDU+k5TUQDbKbyGkLFgEbvDxtrALAPWDhIvxyqZ58XYi3tANIMkdwZm2Ifzd 1OgchVYeS64qEwyexuNVhdPl39lJI8zttIs3rSx/iSpdPo3jq48w+i4BwDzO3SFJ8XPL tPot9MDFmV7ViICV7PNXrJ3mF2dEoFv00ZcyP1iRURVKHqg4gjKeNcOz69gzY4tJmQNC ANY6eSpx6vo4iMFwEjD//khBwmBnHWV+IvMySrsprxJXHOCoCtL0gCG4pOUBZ6mfZNQE C9SzoS759/K0Gi/0VW5ZFy5+hGanNCzhYCa+qf770sgx19PxH0mfZomMMzDUNNReDuv+ ESBw== X-Forwarded-Encrypted: i=1; AJvYcCXmi3LuakkKPWM6AdpbQdr3/2oaQzvY1AToH9Vz+ciHQkqv/UYba4VNH/XiGjJwApYoOj87d4FH/IQtJjfIdw10WoYha5NtezjSgYuAlr/O7dM= X-Gm-Message-State: AOJu0Yz5EkQaNXzjR8wpFhir0q726yLGxFyV+wXR8r/m5/zXPiDcrlx0 iZPSeHW5i6km+LUk14+bmp+vg6r1DHTnlHaFPG1kfwtyXNoyfODwaRAtov7jnbU= X-Google-Smtp-Source: AGHT+IG8ABD9tEwAKr1/xa6bdVCx92iQnTrVgELPE/Lymo3q9zF8m5xvFoyu+g0K7+PoHeaETQDP6g== X-Received: by 2002:a05:620a:29d1:b0:795:967d:b1f4 with SMTP id af79cd13be357-798d26b5261mr1162014985a.70.1718632227786; Mon, 17 Jun 2024 06:50:27 -0700 (PDT) Received: from megalith.oryx-coho.ts.net (d24-150-219-207.home.cgocable.net. [24.150.219.207]) by smtp.gmail.com with ESMTPSA id af79cd13be357-798aaecc004sm432892285a.31.2024.06.17.06.50.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jun 2024 06:50:27 -0700 (PDT) From: Trevor Gamblin Date: Mon, 17 Jun 2024 09:50:00 -0400 Subject: [PATCH v3 20/41] iio: dac: stm32-dac-core: make use of regmap_set_bits() MIME-Version: 1.0 Message-Id: <20240617-review-v3-20-88d1338c4cca@baylibre.com> References: <20240617-review-v3-0-88d1338c4cca@baylibre.com> In-Reply-To: <20240617-review-v3-0-88d1338c4cca@baylibre.com> To: Jonathan Cameron , Lars-Peter Clausen , Dmitry Rokosov , Michael Hennerich , Cosmin Tanislav , Chen-Yu Tsai , Hans de Goede , Ray Jui , Scott Branden , Broadcom internal kernel review list , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Saravanan Sekar , Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , =?utf-8?q?Nuno_S=C3=A1?= , Linus Walleij , Jean-Baptiste Maneyrol , Crt Mori Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Trevor Gamblin X-Mailer: b4 0.13.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240617_065029_431937_D81B257B X-CRM114-Status: UNSURE ( 9.93 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Instead of using regmap_update_bits() and passing the mask twice, use regmap_set_bits(). Suggested-by: Uwe Kleine-König Signed-off-by: Trevor Gamblin --- drivers/iio/dac/stm32-dac-core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/iio/dac/stm32-dac-core.c b/drivers/iio/dac/stm32-dac-core.c index e150ac729154..2d567073996b 100644 --- a/drivers/iio/dac/stm32-dac-core.c +++ b/drivers/iio/dac/stm32-dac-core.c @@ -200,9 +200,8 @@ static int stm32_dac_core_resume(struct device *dev) if (priv->common.hfsel) { /* restore hfsel (maybe lost under low power state) */ - ret = regmap_update_bits(priv->common.regmap, STM32_DAC_CR, - STM32H7_DAC_CR_HFSEL, - STM32H7_DAC_CR_HFSEL); + ret = regmap_set_bits(priv->common.regmap, STM32_DAC_CR, + STM32H7_DAC_CR_HFSEL); if (ret) return ret; }