From patchwork Mon Jun 17 13:50:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Trevor Gamblin X-Patchwork-Id: 13700789 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F2581C2BA15 for ; Mon, 17 Jun 2024 13:53:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qJxmNEavPx6due4CMPsHAHdfzBF+CIQn8709/BG4NhI=; b=YKorSc/hRazDPj EVfDlQ5fbEfNijciG7Bycd6p2B9LkuoeBNPdtIVDuxksTi7QZyYeM9Lz3r1EmgrgHa4VaKfrw36G0 fd6g+2Q73NHoJltD0u/UsLFg+g1AQ0QjLgbvm68CnXY9Q8X/Ap4lc6zLPM7Uk2s7r+anqijotg8Nc /XN7swW7Mt8OeqXb4T2xgdOVQ41J9wmg9xRYdVYgDHsRtiyTT5KH8Ks2FjmQTRWde59zevaaY+i+/ HAkr0VIUh0gzIweu1rEqXkqaRqHPlfJ26G1G7ptjhvyXqgbtaXMcem2615rmy0naQjaPkJBUEu7+H Y2MccCYlt1d+WgCboE3Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJCnL-0000000AzIs-2dQe; Mon, 17 Jun 2024 13:53:15 +0000 Received: from mail-ua1-x92d.google.com ([2607:f8b0:4864:20::92d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJCko-0000000AxNT-3HSD for linux-amlogic@lists.infradead.org; Mon, 17 Jun 2024 13:50:47 +0000 Received: by mail-ua1-x92d.google.com with SMTP id a1e0cc1a2514c-80d68861bf9so1534835241.2 for ; Mon, 17 Jun 2024 06:50:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1718632236; x=1719237036; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=yqMe4af98NHJiZdRmZKfGjAtSzwLMs3Usdpoxv76E0s=; b=dENKeH5mDMxJgCOAaIQYIUHZngon76uKfFjoMnRycl1dU8WKPBlj3LqHl32j5pMgt7 Jyn8HQMK8qJ3VWZtFSJWpjNKn0CznBti6HcbUJNdFeI1HCJgzWtb+NRd7aY5JQXCwta5 MGKBJWGWgGXUcamusJllF4uEUlk5eqJoMAghKf7UQWRzM4UXpFAgbVB4lOlU7+V+HuPy MuDNkAxq0e6jVEDPM9Dke0SdsDA7+pguqLed9kEpPrTi3yR3Iv1ecH0sdXVrLf+Kxxbr INnMb4mZwXwJG3NU2rYu1FwUWQv5Yjx1Mie1MytyFHv0jSxOxD8bi7IZuXMzFBw0mwg9 vljg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718632236; x=1719237036; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yqMe4af98NHJiZdRmZKfGjAtSzwLMs3Usdpoxv76E0s=; b=iQ6olsuKtD5SkDO5mOdrzo8lHM6m/ge73ROMsxb661FD20vpiLgqMxcAISsWQ/aqyA yjycKL/3XPXPgkv9Nz2guiNrELWjywrmKXzCqg8IOHAGuK9105Cko52dwlpDiNwljRkd 2sS09/YYL2d0BDMc0gkYXpCuHmhUuicYbDCZaz9V9yL40KHrDkbvBO5SsAeghzGbwjTN DuVzUoBx1PG0V7TYOzZJ2k8IMSH5He74hMWwek7stcJso1CQ9knBV2LGW7abM75rIpmi UXO1Fw2DcwzhahkQeIJbNXScLsfaFRqOB2bA9ETdubiCFFSkI0HKWZ7kkXBaYa/1lNS+ gx5Q== X-Forwarded-Encrypted: i=1; AJvYcCVlMq53DQY/PoAWzWz3BidAFUXQxUzxSqo/huwgDhe+9BBjXxGFau1PtDYtjDfpxNTpG+OPvSSJneczWkX5ix8/UXgsYIIF1jyyiGSnEn2nsn0= X-Gm-Message-State: AOJu0YwHc+e4y84Cx2XAGtW5kp9veD33pH8cqZ7ACk2cubPx++Ew6a3g VIj6sDF1TDtNbNcxnEZJ/ee1DzpEC3TMP20+r/V8Ffe2TmeAEmP1apLbSOJm0V4= X-Google-Smtp-Source: AGHT+IFihHa6bMcNzaeLIOOLDw8PfmzIsl9aK4RVvUYriLx2jOAq5E+Axp1aames8cM1+wIsIKtc2A== X-Received: by 2002:a05:6102:3b96:b0:48c:19d7:eb83 with SMTP id ada2fe7eead31-48dae3f30ebmr8867679137.34.1718632236471; Mon, 17 Jun 2024 06:50:36 -0700 (PDT) Received: from megalith.oryx-coho.ts.net (d24-150-219-207.home.cgocable.net. [24.150.219.207]) by smtp.gmail.com with ESMTPSA id af79cd13be357-798aaecc004sm432892285a.31.2024.06.17.06.50.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jun 2024 06:50:36 -0700 (PDT) From: Trevor Gamblin Date: Mon, 17 Jun 2024 09:50:04 -0400 Subject: [PATCH v3 24/41] iio: health: afe4404: make use of regmap_clear_bits(), regmap_set_bits() MIME-Version: 1.0 Message-Id: <20240617-review-v3-24-88d1338c4cca@baylibre.com> References: <20240617-review-v3-0-88d1338c4cca@baylibre.com> In-Reply-To: <20240617-review-v3-0-88d1338c4cca@baylibre.com> To: Jonathan Cameron , Lars-Peter Clausen , Dmitry Rokosov , Michael Hennerich , Cosmin Tanislav , Chen-Yu Tsai , Hans de Goede , Ray Jui , Scott Branden , Broadcom internal kernel review list , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Saravanan Sekar , Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , =?utf-8?q?Nuno_S=C3=A1?= , Linus Walleij , Jean-Baptiste Maneyrol , Crt Mori Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Trevor Gamblin X-Mailer: b4 0.13.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240617_065039_413512_4562E5A7 X-CRM114-Status: UNSURE ( 9.54 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Instead of using regmap_update_bits() and passing the mask twice, use regmap_set_bits(). Instead of using regmap_update_bits() and passing val = 0, use regmap_clear_bits(). Suggested-by: Uwe Kleine-König Signed-off-by: Trevor Gamblin --- drivers/iio/health/afe4404.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/iio/health/afe4404.c b/drivers/iio/health/afe4404.c index 7768b07ef7a6..51f4be39d20b 100644 --- a/drivers/iio/health/afe4404.c +++ b/drivers/iio/health/afe4404.c @@ -430,9 +430,8 @@ static int afe4404_suspend(struct device *dev) struct afe4404_data *afe = iio_priv(indio_dev); int ret; - ret = regmap_update_bits(afe->regmap, AFE440X_CONTROL2, - AFE440X_CONTROL2_PDN_AFE, - AFE440X_CONTROL2_PDN_AFE); + ret = regmap_set_bits(afe->regmap, AFE440X_CONTROL2, + AFE440X_CONTROL2_PDN_AFE); if (ret) return ret; @@ -457,8 +456,8 @@ static int afe4404_resume(struct device *dev) return ret; } - ret = regmap_update_bits(afe->regmap, AFE440X_CONTROL2, - AFE440X_CONTROL2_PDN_AFE, 0); + ret = regmap_clear_bits(afe->regmap, AFE440X_CONTROL2, + AFE440X_CONTROL2_PDN_AFE); if (ret) return ret;