From patchwork Mon Jun 17 13:50:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Trevor Gamblin X-Patchwork-Id: 13700790 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 996F7C2BA15 for ; Mon, 17 Jun 2024 13:53:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YxEi6VOvUhM1YMeB6SvW6nYQP+gbjHnjTQyy8bGsAlQ=; b=HukGJmKcabgOrk jFCdpuM0AkyVewsMVvoSzh8Ia2L0LLQ0eqsgYX684utmqgRhkTxb5WQgIPYh+yR5P5ImAsC9wa9us +PhmQp8daSsRxzcndMgVfxr00MXetoKLsxs6IsYvMFQlebooWQLpfvQ5YSkMsjqyoh4ASrqLpyOom pUMK7mQbrbPkyQkCO/6Cm7/mW5yuzctPbKTR52xrmVJbxPws0ulxXbZjDraZPFJN5Z5918yqlEBXL mlNaZJCXvKgxHF3Ls6tk0iMd/ybFnItx+O1fGRVcT0keBuulVbWgGcWHcn6OSrtP9uQcTZsrBgixd o5YM29C0z+a5AVEq/MjA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJCnP-0000000AzML-39BP; Mon, 17 Jun 2024 13:53:19 +0000 Received: from mail-qk1-x72c.google.com ([2607:f8b0:4864:20::72c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJCkq-0000000AxPP-2mM1 for linux-amlogic@lists.infradead.org; Mon, 17 Jun 2024 13:50:49 +0000 Received: by mail-qk1-x72c.google.com with SMTP id af79cd13be357-795502843ccso252193085a.1 for ; Mon, 17 Jun 2024 06:50:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1718632238; x=1719237038; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=7n1vQrJKdah20S8ZMrVRWoElzUuvEAd8XeagF8Tz1M4=; b=HuYwajOAyk/559EmR/1/W2S88i14JG8kW8dyNbnb8zSSQj00EpMtJ7gjkCez2o7Zk5 8Wxd4vbM7vbp4LAXgPF3EaY2URqMqb4sOH/9kXHdf3T8MW0avLcSr9Z+yNJ2iSn9D22K v+i0wM/plmXuhS9AhxqCeeDRIC0XWy/KPPiMPbSGBQ/tQZwUtMVhC9Ef+tCsaJNdOs4x ZrwR6OJZdmGgoAgG3Qg85/thGTPDZ2yWAiVZ8VlmCc81hncKkmiGNMnuf29CFNZOSF+C GVMbLY7/8GWHBnEMMnk7noJha80tjmNKlu31DlKbr/Aca2aZy+AUqWxNJQJ+PbEhbuXC Po0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718632238; x=1719237038; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7n1vQrJKdah20S8ZMrVRWoElzUuvEAd8XeagF8Tz1M4=; b=t8ZxtAefZl7MjLVJeJkX751W2trB17yOnF3DP3ThGxW+bAbrPS8Q7tzUd5uUUc7mWw 0eZhLUAtsqQkUdjNT7/UJwQ53KsB8xTRjkbR8p/+hKEq78ddKlOp4X3ef5Q1+USnGE4z jGnymoKUvzzxdHPzvKdwZl191jd1icZxOljxxl2pxlBzYNvuuYAnDvJPWu3wdC5yT7Id rEV7EvlHXic4cxlVwoqzM0aGBDVEj2vllk/wF1yiqV8dFTaDpPV1f9dP5yP6Y09joEzv z937EBN4gaIGoPZXlwlW7q4xzmnFoeMyTOzAC0bstuNm0z9ac4Gg7MkP5psWE5e8Dt17 vVXg== X-Forwarded-Encrypted: i=1; AJvYcCWy5BMBY9WCwfM2sfUfn+qUtjz4DRhcojYTIM1WW3m+Z8uCOAEWuR290HZTG+4FUH/QXHoWj60Y3YWwbMUmLAAgub/2nyVXe2cu80DxsEzNOm0= X-Gm-Message-State: AOJu0YwR4ERvW4xiG5r4ggeJ55yV7Sb8OgDPkmOw98pya5hfYXjhVuWg XFNa/XsQnfyb4JD9lmoFhChGOhqT6Rp4kOgL/YR/2fN6LFJDQdPJ8pdpL9LzIPw= X-Google-Smtp-Source: AGHT+IFPBsXk8OC1fXhOsjN5sQEyfL0NaDJoRNSti0BCnQHlNJa0XX2KPq4TD0tgoqruv2mBvc8G+w== X-Received: by 2002:a05:620a:2947:b0:795:60b0:3f5 with SMTP id af79cd13be357-798d2430e27mr984123785a.34.1718632238585; Mon, 17 Jun 2024 06:50:38 -0700 (PDT) Received: from megalith.oryx-coho.ts.net (d24-150-219-207.home.cgocable.net. [24.150.219.207]) by smtp.gmail.com with ESMTPSA id af79cd13be357-798aaecc004sm432892285a.31.2024.06.17.06.50.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jun 2024 06:50:38 -0700 (PDT) From: Trevor Gamblin Date: Mon, 17 Jun 2024 09:50:05 -0400 Subject: [PATCH v3 25/41] iio: health: max30100: make use of regmap_set_bits() MIME-Version: 1.0 Message-Id: <20240617-review-v3-25-88d1338c4cca@baylibre.com> References: <20240617-review-v3-0-88d1338c4cca@baylibre.com> In-Reply-To: <20240617-review-v3-0-88d1338c4cca@baylibre.com> To: Jonathan Cameron , Lars-Peter Clausen , Dmitry Rokosov , Michael Hennerich , Cosmin Tanislav , Chen-Yu Tsai , Hans de Goede , Ray Jui , Scott Branden , Broadcom internal kernel review list , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Saravanan Sekar , Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , =?utf-8?q?Nuno_S=C3=A1?= , Linus Walleij , Jean-Baptiste Maneyrol , Crt Mori Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Trevor Gamblin X-Mailer: b4 0.13.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240617_065041_349210_4DF94971 X-CRM114-Status: UNSURE ( 9.69 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Instead of using regmap_update_bits() and passing the mask twice, use regmap_set_bits(). Suggested-by: Uwe Kleine-König Signed-off-by: Trevor Gamblin --- drivers/iio/health/max30100.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/iio/health/max30100.c b/drivers/iio/health/max30100.c index 6236b4d96137..c1867c2ef8e2 100644 --- a/drivers/iio/health/max30100.c +++ b/drivers/iio/health/max30100.c @@ -363,9 +363,8 @@ static int max30100_get_temp(struct max30100_data *data, int *val) int ret; /* start acquisition */ - ret = regmap_update_bits(data->regmap, MAX30100_REG_MODE_CONFIG, - MAX30100_REG_MODE_CONFIG_TEMP_EN, - MAX30100_REG_MODE_CONFIG_TEMP_EN); + ret = regmap_set_bits(data->regmap, MAX30100_REG_MODE_CONFIG, + MAX30100_REG_MODE_CONFIG_TEMP_EN); if (ret) return ret;