| Message ID | 20240712-soc_info-v1-2-05ba95929d5a@amlogic.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add new Amlogic SoCs info defines. | expand |
On 12/07/2024 08:54, Xianwei Zhao via B4 Relay wrote: > From: Xianwei Zhao <xianwei.zhao@amlogic.com> > > Add node for board info registers, which allows getting SoC family and > board revision. > > For example, with MESON_GX_SOCINFO config enabled we can get the > following information for board with Amlogic S4 SoC: > soc soc0: Amlogic S4 (S805X2) Revision 37:a (2:1) Detecte > > Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com> > --- > arch/arm64/boot/dts/amlogic/meson-s4.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi > index c11c947fa18c..316905ec191c 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi > @@ -763,6 +763,12 @@ reset: reset-controller@2000 { > #reset-cells = <1>; > }; > > + sec_ao: ao-secure@10220 { > + compatible = "amlogic,meson-gx-ao-secure", "syscon"; This is not gx, but s4, so incorrect compatible used. Same for all other patches. Best regards, Krzysztof
Hi Krzysztof,
Thanks for your review.
On 2024/7/12 15:49, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
>
> On 12/07/2024 08:54, Xianwei Zhao via B4 Relay wrote:
>> From: Xianwei Zhao <xianwei.zhao@amlogic.com>
>>
>> Add node for board info registers, which allows getting SoC family and
>> board revision.
>>
>> For example, with MESON_GX_SOCINFO config enabled we can get the
>> following information for board with Amlogic S4 SoC:
>> soc soc0: Amlogic S4 (S805X2) Revision 37:a (2:1) Detecte
>>
>> Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
>> ---
>> arch/arm64/boot/dts/amlogic/meson-s4.dtsi | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
>> index c11c947fa18c..316905ec191c 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
>> @@ -763,6 +763,12 @@ reset: reset-controller@2000 {
>> #reset-cells = <1>;
>> };
>>
>> + sec_ao: ao-secure@10220 {
>> + compatible = "amlogic,meson-gx-ao-secure", "syscon";
>
> This is not gx, but s4, so incorrect compatible used. Same for all other
> patches.
>
Will use fallback to fix it.
> Best regards,
> Krzysztof
>
diff --git a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi index c11c947fa18c..316905ec191c 100644 --- a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi @@ -763,6 +763,12 @@ reset: reset-controller@2000 { #reset-cells = <1>; }; + sec_ao: ao-secure@10220 { + compatible = "amlogic,meson-gx-ao-secure", "syscon"; + reg = <0x0 0x10220 0x0 0x140>; + amlogic,has-chip-id; + }; + ir: ir@84040 { compatible = "amlogic,meson-s4-ir"; reg = <0x0 0x84040 0x0 0x30>;