diff mbox series

[v2,1/6] dt-bindings: arm: amlogic: meson-gx-ao-secure: support more SoCs.

Message ID 20240715-soc_info-v2-1-3836c8cc27a5@amlogic.com (mailing list archive)
State Superseded
Headers show
Series Add new Amlogic SoCs info defines. | expand

Commit Message

Xianwei Zhao via B4 Relay July 15, 2024, 8:59 a.m. UTC 
From: Xianwei Zhao <xianwei.zhao@amlogic.com>

Add dt-binding document for ao-secure of Amlogic SoCs(S4,C3,T7,A4).

Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
---
 .../bindings/arm/amlogic/amlogic,meson-gx-ao-secure.yaml | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

Comments

Conor Dooley July 15, 2024, 4:10 p.m. UTC | #1 
On Mon, Jul 15, 2024 at 04:59:19PM +0800, Xianwei Zhao via B4 Relay wrote:
> From: Xianwei Zhao <xianwei.zhao@amlogic.com>
> 
> Add dt-binding document for ao-secure of Amlogic SoCs(S4,C3,T7,A4).

That's not really accurate - no document is added here.
Otherwise,
Acked-by: Conor Dooley <conor.dooley@microchip.com>

cheers,
Conor.

> 
> Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
> ---
>  .../bindings/arm/amlogic/amlogic,meson-gx-ao-secure.yaml | 16 ++++++++++++----
>  1 file changed, 12 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/amlogic/amlogic,meson-gx-ao-secure.yaml b/Documentation/devicetree/bindings/arm/amlogic/amlogic,meson-gx-ao-secure.yaml
> index 7dff32f373cb..b4f6695a6015 100644
> --- a/Documentation/devicetree/bindings/arm/amlogic/amlogic,meson-gx-ao-secure.yaml
> +++ b/Documentation/devicetree/bindings/arm/amlogic/amlogic,meson-gx-ao-secure.yaml
> @@ -25,10 +25,18 @@ select:
>  
>  properties:
>    compatible:
> -    items:
> -      - const: amlogic,meson-gx-ao-secure
> -      - const: syscon
> -
> +    oneOf:
> +      - items:
> +          - const: amlogic,meson-gx-ao-secure
> +          - const: syscon
> +      - items:
> +          - enum:
> +              - amlogic,a4-ao-secure
> +              - amlogic,c3-ao-secure
> +              - amlogic,s4-ao-secure
> +              - amlogic,t7-ao-secure
> +          - const: amlogic,meson-gx-ao-secure
> +          - const: syscon
>    reg:
>      maxItems: 1
>  
> 
> -- 
> 2.37.1
> 
>
Krzysztof Kozlowski July 16, 2024, 7:36 a.m. UTC | #2 
On 15/07/2024 10:59, Xianwei Zhao via B4 Relay wrote:
> From: Xianwei Zhao <xianwei.zhao@amlogic.com>
> 
> Add dt-binding document for ao-secure of Amlogic SoCs(S4,C3,T7,A4).

Subjects do not end with full stop.

Best regards,
Krzysztof
Xianwei Zhao July 16, 2024, 7:40 a.m. UTC | #3 
Hi Krzysztof,
      Thanks for your review.

On 2024/7/16 15:36, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
> 
> On 15/07/2024 10:59, Xianwei Zhao via B4 Relay wrote:
>> From: Xianwei Zhao <xianwei.zhao@amlogic.com>
>>
>> Add dt-binding document for ao-secure of Amlogic SoCs(S4,C3,T7,A4).
> 
> Subjects do not end with full stop.
> 
Will fix it.
> Best regards,
> Krzysztof
>
Xianwei Zhao July 19, 2024, 2:07 a.m. UTC | #4 
Hi Conor,
     Thanks for your reply. I will fix it to "Add compatible for....." 
in next version.

On 2024/7/16 00:10, Conor Dooley wrote:
> [ EXTERNAL EMAIL ]
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/amlogic/amlogic,meson-gx-ao-secure.yaml b/Documentation/devicetree/bindings/arm/amlogic/amlogic,meson-gx-ao-secure.yaml
index 7dff32f373cb..b4f6695a6015 100644
--- a/Documentation/devicetree/bindings/arm/amlogic/amlogic,meson-gx-ao-secure.yaml
+++ b/Documentation/devicetree/bindings/arm/amlogic/amlogic,meson-gx-ao-secure.yaml
@@ -25,10 +25,18 @@  select:
 
 properties:
   compatible:
-    items:
-      - const: amlogic,meson-gx-ao-secure
-      - const: syscon
-
+    oneOf:
+      - items:
+          - const: amlogic,meson-gx-ao-secure
+          - const: syscon
+      - items:
+          - enum:
+              - amlogic,a4-ao-secure
+              - amlogic,c3-ao-secure
+              - amlogic,s4-ao-secure
+              - amlogic,t7-ao-secure
+          - const: amlogic,meson-gx-ao-secure
+          - const: syscon
   reg:
     maxItems: 1