diff mbox series

arm64: dts: amlogic: c3: fix dtbcheck warning

Message ID 20240902-fix_warning-v1-1-037029c584fc@amlogic.com (mailing list archive)
State Accepted
Headers show
Series arm64: dts: amlogic: c3: fix dtbcheck warning | expand

Commit Message

Xianwei Zhao via B4 Relay Sept. 2, 2024, 5:29 a.m. UTC
From: Xianwei Zhao <xianwei.zhao@amlogic.com>

Fix warning when use W=1 to build dtb, as following error:

arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi:65.7-76.4: Warning
(unit_address_vs_reg): /sram: node has a reg or ranges property,
but no unit name

arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi:168.34-413.6: Warning
(unit_address_vs_reg): /soc/bus@fe000000/pinctrl@4000: node has a
unit name, but no reg or ranges property

arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi:168.34-413.6: Warning
(simple_bus_reg): /soc/bus@fe000000/pinctrl@4000: missing or empty
reg/ranges property

arch/arm64/boot/dts/amlogic/amlogic-c3-c302x-aw409.dts:205.9-245.4:
Warning (avoid_unnecessary_addr_size): /soc/bus@fe000000/spi@56000
/nand@0: unnecessary #address-cells/#size-cells without "ranges",
"dma-ranges" or child "reg" property

Fixes: d4bd8f3023b6 ("arm64: dts: amlogic: add C3 AW419 board")
Fixes: 520b792e8317 ("arm64: dts: amlogic: add some device nodes for C3")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/r/202409010005.A7tSzgEn-lkp@intel.com/
Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
---
Fix some warning when use W=1 to make dtb_check.
---
 arch/arm64/boot/dts/amlogic/amlogic-c3-c302x-aw409.dts |  2 --
 arch/arm64/boot/dts/amlogic/amlogic-c3-c308l-aw419.dts |  2 --
 arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi            | 10 +++++-----
 3 files changed, 5 insertions(+), 9 deletions(-)


---
base-commit: 1565ad6d5afc023cc4cc721513c9be28b902dee8
change-id: 20240902-fix_warning-6c8f362fc833

Best regards,

Comments

Neil Armstrong Sept. 2, 2024, 8:34 a.m. UTC | #1
Hi,

On Mon, 02 Sep 2024 13:29:39 +0800, Xianwei Zhao wrote:
> Fix warning when use W=1 to build dtb, as following error:
> 
> arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi:65.7-76.4: Warning
> (unit_address_vs_reg): /sram: node has a reg or ranges property,
> but no unit name
> 
> arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi:168.34-413.6: Warning
> (unit_address_vs_reg): /soc/bus@fe000000/pinctrl@4000: node has a
> unit name, but no reg or ranges property
> 
> [...]

Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (v6.12/arm64-dt)

[1/1] arm64: dts: amlogic: c3: fix dtbcheck warning
      https://git.kernel.org/amlogic/c/ca55a30d27cb37c07f58e5c3448f4d19edb1829c

These changes has been applied on the intermediate git tree [1].

The v6.12/arm64-dt branch will then be sent via a formal Pull Request to the Linux SoC maintainers
for inclusion in their intermediate git branches in order to be sent to Linus during
the next merge window, or sooner if it's a set of fixes.

In the cases of fixes, those will be merged in the current release candidate
kernel and as soon they appear on the Linux master branch they will be
backported to the previous Stable and Long-Stable kernels [2].

The intermediate git branches are merged daily in the linux-next tree [3],
people are encouraged testing these pre-release kernels and report issues on the
relevant mailing-lists.

If problems are discovered on those changes, please submit a signed-off-by revert
patch followed by a corrective changeset.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git
[2] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
[3] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/amlogic/amlogic-c3-c302x-aw409.dts b/arch/arm64/boot/dts/amlogic/amlogic-c3-c302x-aw409.dts
index b8d2037afc00..a6736ad2a648 100644
--- a/arch/arm64/boot/dts/amlogic/amlogic-c3-c302x-aw409.dts
+++ b/arch/arm64/boot/dts/amlogic/amlogic-c3-c302x-aw409.dts
@@ -208,8 +208,6 @@  nand@0 {
 		spi-max-frequency = <83000000>;
 		spi-tx-bus-width = <4>;
 		spi-rx-bus-width = <4>;
-		#address-cells = <1>;
-		#size-cells = <1>;
 		status = "disabled";
 
 		partitions {
diff --git a/arch/arm64/boot/dts/amlogic/amlogic-c3-c308l-aw419.dts b/arch/arm64/boot/dts/amlogic/amlogic-c3-c308l-aw419.dts
index 4477a2659e27..45f8631f9feb 100644
--- a/arch/arm64/boot/dts/amlogic/amlogic-c3-c308l-aw419.dts
+++ b/arch/arm64/boot/dts/amlogic/amlogic-c3-c308l-aw419.dts
@@ -208,8 +208,6 @@  nand@0 {
 		spi-max-frequency = <83000000>;
 		spi-tx-bus-width = <4>;
 		spi-rx-bus-width = <4>;
-		#address-cells = <1>;
-		#size-cells = <1>;
 		status = "disabled";
 
 		partitions {
diff --git a/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi b/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi
index c0ce776ec463..d0cda759c25d 100644
--- a/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi
+++ b/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi
@@ -62,7 +62,7 @@  pwrc: power-controller {
 		};
 	};
 
-	sram {
+	sram@7f50e00 {
 		compatible = "mmio-sram";
 		reg = <0x0 0x07f50e00 0x0 0x100>;
 		#address-cells = <1>;
@@ -169,11 +169,11 @@  periphs_pinctrl: pinctrl@4000 {
 				compatible = "amlogic,c3-periphs-pinctrl";
 				#address-cells = <2>;
 				#size-cells = <2>;
-				ranges;
+				ranges = <0x0 0x0 0x0 0x4000 0x0 0x02de>;
 
-				gpio: bank@4000 {
-					reg = <0x0 0x4000 0x0 0x004c>,
-					      <0x0 0x4100 0x0 0x01de>;
+				gpio: bank@0 {
+					reg = <0x0 0x0 0x0 0x004c>,
+					      <0x0 0x100 0x0 0x01de>;
 					reg-names = "mux", "gpio";
 					gpio-controller;
 					#gpio-cells = <2>;