diff mbox series

[1/2] dt-bindings: pwm: amlogic: Document C3 PWM

Message ID 20240906-c3-pwm-v1-1-acaf17fad247@amlogic.com (mailing list archive)
State Superseded
Headers show
Series Add support for Amlogic C3 PWM | expand

Commit Message

Kelvin Zhang via B4 Relay Sept. 6, 2024, 12:46 p.m. UTC
From: Kelvin Zhang <kelvin.zhang@amlogic.com>

Document amlogic,c3-pwm compatible, which falls back to the meson-s4-pwm
group.

Signed-off-by: Kelvin Zhang <kelvin.zhang@amlogic.com>
---
 Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Krzysztof Kozlowski Sept. 6, 2024, 12:50 p.m. UTC | #1
On 06/09/2024 14:46, Kelvin Zhang via B4 Relay wrote:
> From: Kelvin Zhang <kelvin.zhang@amlogic.com>
> 
> Document amlogic,c3-pwm compatible, which falls back to the meson-s4-pwm
> group.
> 
> Signed-off-by: Kelvin Zhang <kelvin.zhang@amlogic.com>
> ---
>  Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
> index 1d71d4f8f328..356371164acd 100644
> --- a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
> +++ b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
> @@ -44,6 +44,10 @@ properties:
>                - amlogic,meson-axg-pwm-v2
>                - amlogic,meson-g12-pwm-v2
>            - const: amlogic,meson8-pwm-v2
> +      - items:
> +          - enum:
> +              - amlogic,c3-pwm

Assuming that lack of meson fits all other instances of c3:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Kelvin Zhang Sept. 9, 2024, 10:43 a.m. UTC | #2
On 2024/9/6 20:50, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
> 
> On 06/09/2024 14:46, Kelvin Zhang via B4 Relay wrote:
>> From: Kelvin Zhang <kelvin.zhang@amlogic.com>
>>
>> Document amlogic,c3-pwm compatible, which falls back to the meson-s4-pwm
>> group.
>>
>> Signed-off-by: Kelvin Zhang <kelvin.zhang@amlogic.com>
>> ---
>>   Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
>> index 1d71d4f8f328..356371164acd 100644
>> --- a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
>> +++ b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
>> @@ -44,6 +44,10 @@ properties:
>>                 - amlogic,meson-axg-pwm-v2
>>                 - amlogic,meson-g12-pwm-v2
>>             - const: amlogic,meson8-pwm-v2
>> +      - items:
>> +          - enum:
>> +              - amlogic,c3-pwm
> 
> Assuming that lack of meson fits all other instances of c3:
> 
That's right. C3 does not belong to the meson series.
Thanks for your review!

> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Best regards,
> Krzysztof
>
George Stark Sept. 9, 2024, 12:49 p.m. UTC | #3
Hello Kelvin, Krzysztof

There's acked yet not merged patch [1] adding amlogic,meson-a1-pwm with 
s4 as back-compatible. Should amlogic,c3-pwm be added in the enum along 
with a1?

[1] 
https://lore.kernel.org/linux-arm-kernel/dbb4be50-4793-40ab-b362-6c9a6dd87324@salutedevices.com/T/

On 9/6/24 15:46, Kelvin Zhang via B4 Relay wrote:
> From: Kelvin Zhang <kelvin.zhang@amlogic.com>
> 
> Document amlogic,c3-pwm compatible, which falls back to the meson-s4-pwm
> group.
> 
> Signed-off-by: Kelvin Zhang <kelvin.zhang@amlogic.com>
> ---
>   Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
> index 1d71d4f8f328..356371164acd 100644
> --- a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
> +++ b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
> @@ -44,6 +44,10 @@ properties:
>                 - amlogic,meson-axg-pwm-v2
>                 - amlogic,meson-g12-pwm-v2
>             - const: amlogic,meson8-pwm-v2
> +      - items:
> +          - enum:
> +              - amlogic,c3-pwm
> +          - const: amlogic,meson-s4-pwm
>   
>     reg:
>       maxItems: 1
>
Kelvin Zhang Sept. 10, 2024, 2:22 a.m. UTC | #4
On 2024/9/9 20:49, George Stark wrote:
> [ EXTERNAL EMAIL ]
> 
> Hello Kelvin, Krzysztof
> 
> There's acked yet not merged patch [1] adding amlogic,meson-a1-pwm with
> s4 as back-compatible. Should amlogic,c3-pwm be added in the enum along
> with a1?
> 
> [1]
> https://lore.kernel.org/linux-arm-kernel/dbb4be50-4793-40ab- 
> b362-6c9a6dd87324@salutedevices.com/T/
> 
Hello George,
I've noticed your patch.
Once it is merged, I will rebase my submission.
Thanks!

> On 9/6/24 15:46, Kelvin Zhang via B4 Relay wrote:
>> From: Kelvin Zhang <kelvin.zhang@amlogic.com>
>>
>> Document amlogic,c3-pwm compatible, which falls back to the meson-s4-pwm
>> group.
>>
>> Signed-off-by: Kelvin Zhang <kelvin.zhang@amlogic.com>
>> ---
>>   Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml b/ 
>> Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
>> index 1d71d4f8f328..356371164acd 100644
>> --- a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
>> +++ b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
>> @@ -44,6 +44,10 @@ properties:
>>                 - amlogic,meson-axg-pwm-v2
>>                 - amlogic,meson-g12-pwm-v2
>>             - const: amlogic,meson8-pwm-v2
>> +      - items:
>> +          - enum:
>> +              - amlogic,c3-pwm
>> +          - const: amlogic,meson-s4-pwm
>>
>>     reg:
>>       maxItems: 1
>>
> 
> -- 
> Best regards
> George
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
index 1d71d4f8f328..356371164acd 100644
--- a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
+++ b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
@@ -44,6 +44,10 @@  properties:
               - amlogic,meson-axg-pwm-v2
               - amlogic,meson-g12-pwm-v2
           - const: amlogic,meson8-pwm-v2
+      - items:
+          - enum:
+              - amlogic,c3-pwm
+          - const: amlogic,meson-s4-pwm
 
   reg:
     maxItems: 1