| Message ID | 20250212-mmc-slot-v3-1-2bf288207040@microchip.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | dt-bindings: mmc: Fix the mmc-slot and Convert atmel,hsmci to json schema | expand |
On Wed, 12 Feb 2025 14:52:10 +0530, Dharma Balasubiramani wrote: > The compatible property is required for some vendor-specific device trees, such > as Amlogic's meson-mx-sdio, but is unnecessary for others, like Microchip's > DTS. To resolve unintended warnings for configurations that do not require it, > remove compatible from the required properties in mmc-slot.yaml. Please rewrap your commit message at the right length. checkpatch.pl will tell you this so I don't have to. > > Since meson-mx-sdio still requires compatible, explicitly add it to its > required list in amlogic,meson-mx-sdio.yaml. > > Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com> > --- > Documentation/devicetree/bindings/mmc/amlogic,meson-mx-sdio.yaml | 3 +++ > Documentation/devicetree/bindings/mmc/mmc-slot.yaml | 1 - > 2 files changed, 3 insertions(+), 1 deletion(-) > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/mmc/amlogic,meson-mx-sdio.yaml b/Documentation/devicetree/bindings/mmc/amlogic,meson-mx-sdio.yaml index 022682a977c6..0d4d9ca6a8d9 100644 --- a/Documentation/devicetree/bindings/mmc/amlogic,meson-mx-sdio.yaml +++ b/Documentation/devicetree/bindings/mmc/amlogic,meson-mx-sdio.yaml @@ -60,6 +60,9 @@ patternProperties: bus-width: enum: [1, 4] + required: + - compatible + unevaluatedProperties: false required: diff --git a/Documentation/devicetree/bindings/mmc/mmc-slot.yaml b/Documentation/devicetree/bindings/mmc/mmc-slot.yaml index 1f0667828063..ca3d0114bfc6 100644 --- a/Documentation/devicetree/bindings/mmc/mmc-slot.yaml +++ b/Documentation/devicetree/bindings/mmc/mmc-slot.yaml @@ -29,7 +29,6 @@ properties: maxItems: 1 required: - - compatible - reg unevaluatedProperties: false
The compatible property is required for some vendor-specific device trees, such as Amlogic's meson-mx-sdio, but is unnecessary for others, like Microchip's DTS. To resolve unintended warnings for configurations that do not require it, remove compatible from the required properties in mmc-slot.yaml. Since meson-mx-sdio still requires compatible, explicitly add it to its required list in amlogic,meson-mx-sdio.yaml. Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com> --- Documentation/devicetree/bindings/mmc/amlogic,meson-mx-sdio.yaml | 3 +++ Documentation/devicetree/bindings/mmc/mmc-slot.yaml | 1 - 2 files changed, 3 insertions(+), 1 deletion(-)