From patchwork Tue Mar 4 17:05:29 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 14001241 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C9434C282D6 for ; Tue, 4 Mar 2025 18:29:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sPngdK5DYbhGAiT7MxWwZIKSvO4D3M6mDFleryhZjHQ=; b=hi2KF30ZF0NSgp 4ZRIpoEgQqYczuXJE36xK+farQM3+NLwmi0OT3ygEMS7ev6cW75bnTHjBog3D+FwTfM/+FA7SiZvk GXMTh6vLogh98dsW5LqbUJDD5mq80m5DeBfDMZ8qY6TEw6y/lHl0Fe84RxPv4NczSfuZAiXig49h2 GPACCjTwe5v8cMQ1sjOPFbEvflasxwOF1N/rvJrve+ha//KGrTcrC6NwDS5SBQVVMmuniXBHRTN8v 2X7csmIeOU7v/FIe/Qk0HpT3EoEERyWrJNw56bxO6aZPax7iIYfraDASg5d8xrN4ta+O3WLkPu4TE Y6hYIDymkeerAXqKK08g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tpX11-00000005qmN-2VOH; Tue, 04 Mar 2025 18:29:15 +0000 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpVi2-00000005Y8c-1Py1 for linux-amlogic@lists.infradead.org; Tue, 04 Mar 2025 17:05:36 +0000 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-390e3b3d3bcso6933931f8f.3 for ; Tue, 04 Mar 2025 09:05:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741107932; x=1741712732; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=M1Zs+DHu4keoQ7nH0HfotkX9qiVtwoVoQvIhvtnI4DA=; b=hC8DY/E0iJrbQ6B5sTX1MfLAaFia3ogm1eHufZbXq18YcJ9qsGdMLGPvP4CEqmkqXY rKme/EqkXuJhx7Cv4yx/2/Cn7a+JiJIPULm+7LpRXf5eipc2lmMvE+uTdVNiNj80RsSJ I2z44wv2KvYsDfSB3MPdpIySbPi90bmTkLlQnCMUCrnnmh0KHVbqB/l+KAmcsf8ZsF04 IDWm4umDTBORk6jDIA44SsSdFIoY10YFpcpXiOnJMXAesJ3yJsyd35kcX3tfPjTisyt4 zP4YCqJy042ThfWYAoMrRkZK/Co4vXGfKjPgfN3QQKuS6aruBTCq7vCn/Szjz/Xt0E0x EKdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741107932; x=1741712732; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=M1Zs+DHu4keoQ7nH0HfotkX9qiVtwoVoQvIhvtnI4DA=; b=nuPBtUOeVVY214F4baxfRxhtWzpFPcBxqJbXzonSHfklxlPXNv5MnYyCbGjSCuYF9C jTiEeyxopmknGhnEA8ay+7Gi6fQuRenphlvvYk41RQgfOFvhu5aBLrxWGUmfwseBMefJ +FJCxrTtkeFA+2wRq3qW//rnsK2bp8FGbUWAiqWhzs0GIdhpZdqYwUmtAOf+48uq10aK 5N3kLRGU3H0Up53xjBx1qY34j7voujJKFjvG4k8A3IXVIz7QUg1C0Xqv0iu/pY94WM6k vRbpHZtAjlCdCY1Xsu+1f1gLa8a2SkU7q5qDFrGLdknSMz6jnpseCt7/ERcuH+EGgRcB 3o0Q== X-Forwarded-Encrypted: i=1; AJvYcCW9KEetVL6G3uX1dBbotcLHZAQU5sOAnemIHbpDmjM5cjV8TGZrBo0YI/ePnoeyf9djDA74OTpi2xiBQmWq@lists.infradead.org X-Gm-Message-State: AOJu0YydJkJtdWUMvhpPd5akLUtYTs7e1cSXcaUKX1pao+R9ToAw0S2Z BDhJXCcnUmfA6aXrhMaGMklC2LqUO5XfvQq521bUDQSstmfndhJGbABEdVL4AU8= X-Gm-Gg: ASbGncvht2AeCIjtvpxfm5U0ENclYix6lgbfU1RX7LUUuHvCkrfxhaawrLfAKKZPPpr zfJgZhMR7KgN8vHxvI0akszVDryzCYlL5DmBmet2G25h4wp/aZxhA9iWBjZFfWcAgE+GkAuWCg+ b1hdJP8mKsePzSy7NfFiMsJjeu8UWf0HunmkPA2HYgkzf0/O9vU2Z6Ssdo49t25dvBbcOH6YnPY Do9OwuReIlGDsSRyVlkUAL7AsThSWqy5TLnxmzlZQPHHVefhoKs4ZhH6XFW0GHKxUXMB/GQJRXH qLGCZJ6F9oM4VjlE1vR4DJN0Zsj1ZQbYInw94mBopfEmai7/NvIi4b0qMmWJLMbmTiOhvSm8qmM qs4krWydhOfxNT5voEGVjv2WVzqqP X-Google-Smtp-Source: AGHT+IHSc8pjwattEBJyeHF3OjOkT41+G9Y/Rh1pozPSubIjG3eC8i5kYIqu87xMZCHZm4ULB7j+yA== X-Received: by 2002:a05:6000:1faf:b0:391:888:f534 with SMTP id ffacd0b85a97d-3910888f656mr7939190f8f.20.1741107931986; Tue, 04 Mar 2025 09:05:31 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf795ba15esm367589066b.131.2025.03.04.09.05.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 09:05:31 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 04 Mar 2025 17:05:29 +0000 Subject: [PATCH v2 01/16] rtc: max77686: drop needless struct max77686_rtc_info::rtc member MIME-Version: 1.0 Message-Id: <20250304-rtc-cleanups-v2-1-d4689a71668c@linaro.org> References: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> In-Reply-To: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, llvm@lists.linux.dev, =?utf-8?q?Andr=C3=A9_Draszik?= , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250304_090534_373617_B62CA225 X-CRM114-Status: GOOD ( 13.53 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org When this driver was converted to using the devres managed i2c device in commit 59a7f24fceb3 ("rtc: max77686: convert to devm_i2c_new_dummy_device()"), struct max77686_rtc_info::rtc became essentially unused. We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Reviewed-by: Krzysztof Kozlowski Signed-off-by: André Draszik --- drivers/rtc/rtc-max77686.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c index 7bb044d2ac25aeaaf2404b47b7e7bd485ae3d39e..6b0d02b44c8097453f704cbec9f02580fb869ca3 100644 --- a/drivers/rtc/rtc-max77686.c +++ b/drivers/rtc/rtc-max77686.c @@ -85,7 +85,6 @@ struct max77686_rtc_driver_data { struct max77686_rtc_info { struct device *dev; - struct i2c_client *rtc; struct rtc_device *rtc_dev; struct mutex lock; @@ -691,6 +690,7 @@ static int max77686_init_rtc_regmap(struct max77686_rtc_info *info) { struct device *parent = info->dev->parent; struct i2c_client *parent_i2c = to_i2c_client(parent); + struct i2c_client *client; int ret; if (info->drv_data->rtc_irq_from_platform) { @@ -714,14 +714,14 @@ static int max77686_init_rtc_regmap(struct max77686_rtc_info *info) goto add_rtc_irq; } - info->rtc = devm_i2c_new_dummy_device(info->dev, parent_i2c->adapter, - info->drv_data->rtc_i2c_addr); - if (IS_ERR(info->rtc)) { + client = devm_i2c_new_dummy_device(info->dev, parent_i2c->adapter, + info->drv_data->rtc_i2c_addr); + if (IS_ERR(client)) { dev_err(info->dev, "Failed to allocate I2C device for RTC\n"); - return PTR_ERR(info->rtc); + return PTR_ERR(client); } - info->rtc_regmap = devm_regmap_init_i2c(info->rtc, + info->rtc_regmap = devm_regmap_init_i2c(client, info->drv_data->regmap_config); if (IS_ERR(info->rtc_regmap)) { ret = PTR_ERR(info->rtc_regmap);