From patchwork Tue Mar 4 17:05:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 14001243 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DEB20C282D9 for ; Tue, 4 Mar 2025 18:30:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=honpLzeJN9HARrQ1SV4QPdzugwa15bIeIM+VCyykdk0=; b=bBBPfbDSx/Ha3V Bjn6WkRwJEpEA36dTGbdFqvBS0qhB52RF1Ftb1iXVH6Fe0Nq9/wj3/WuCj9rgk60lHWAvwnT0E3CT 0pOnU/3zfT+ezePyOl7pm2upd6N6BnEOOuDe/s5W70oiwoOG+jdydNiIRpV8bfbEOGUcYNCA6ZF/3 DWMl2Q+AClfvImd3iHpKMPWdcYTUhDGF5y+bEFu0JvmAhR03e2TIZ2Exr0NLMwNTBdMTN83SL/Kjo TFbmjxivO9mePv9G2MPuyfaLybsH+s4V1HVNx/8k5EJ2nluV+6lDCt1cQG3FpCKtwm6T8j0fNrEO7 10puTIShM/enwHq0WmEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tpX2Y-00000005r8q-3kx0; Tue, 04 Mar 2025 18:30:50 +0000 Received: from mail-ej1-f49.google.com ([209.85.218.49]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpVi5-00000005YAu-3lrn for linux-amlogic@lists.infradead.org; Tue, 04 Mar 2025 17:05:39 +0000 Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-abf57138cfaso615829266b.1 for ; Tue, 04 Mar 2025 09:05:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741107936; x=1741712736; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=IgG/ZB1ufhyJ5LLnH+TbRO+Ff9QR7sb5p8sH4cYGYcE=; b=LpeJEz0R5X8T2QR7pofOV8gJkBUXWjwn/cXKloeQc/IAeyCvcl3y/GyhTz8iC+6XWm 7vlmZDl96pjxW07cDgJQpnC+ZC0omY4n/9vZ4fxBMiuQesFE5wOvuFjyf6a6H56tlTwi 03CQJqSfZX2DUVV4Wx3TDJjhq+INjqauYZB8OUE0jHg2xbuHl5DCtzYydLY3xX3ilmc9 u6ciP35/VbpUtmGDCE+OUA3gkaqPpcFG+/q9zWyE1ZwLKXmwtwyZpRrk1OZol6J04aWN BIJ5kVb5fLNeCaoevFCD5UENx5zqf+Es5adMIqUIVLirE9Ov1UL177i5jBlJ3sjNRLez JT9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741107936; x=1741712736; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IgG/ZB1ufhyJ5LLnH+TbRO+Ff9QR7sb5p8sH4cYGYcE=; b=G2KDr80Dm3ruSdr/UG1fYZaVW8F+oETIZMOrPPUW40nQCeLJaGY5GE6MmWL3Hg2QRC TZU63H2sj0fW35XUKllugGSS5wyp50bIrqpWvqdRShLsoporm6oVRLjPG8XXkY6zkKV3 fdQa5Md9ooFlOHCalNq/S2VnKDSdRpiMh7ExotqbtkKwTMXmOsOK9o2BmUY7mC9Fe2Wb JS+u+aHZsMOTrwVjhyMn8Bb1VxyBjGxthdlQ7Cor/xd7r9EERgHSHv7/EZutiMNIN0yT exTSnfeIPjGYy7dboWE2PHZlKBnXeUAsO/k4BGSiUZ7zm9VKUQKJQ12t20z6UoaOHsJ0 kdPQ== X-Forwarded-Encrypted: i=1; AJvYcCX+c/W0vPbepX0g97JYzGfaD+vYt6s1sIAZHxPgFoZSAnlQCxp3bieo6XTYwL45GRDAona22+ik/P4RGaD8@lists.infradead.org X-Gm-Message-State: AOJu0YxSBRsCArUhNihUwjOzfRwCOuyVln5sOkrWShvhwmcaU6TbJN/s /Q6rJY8KCBNJNJ/dKimPSkZQhF0TCNPgbV+j/kPl4V2gX5/6E/t0Mh3EFh825NI= X-Gm-Gg: ASbGncv+Ivjs3Y3mhPlTHEw7qdw0HIuisrUJAmcwtAT5hbJzYqKk7Q4Wp1nt0MAFc/z KanlSnYy2CW7teYj6A8st0G3m5XQCimlofsneDNXt4Bzw1BXszRAN03xmEgbjqJSu3K/Nrs15L7 MO2BiHvneqGiuDXYponl4MCea5+2YzMFOXSV1kOzzUOjOi/5s/rPicHFxM+5/oYW2kzF6mev4QK NFibK2Valu5ipdL0CcS8vJrg1O0Evx1V7L/CddSw70is0G5rFDaLIABN+R/SRJjKnd/zLW0DSMO yeAHiOxvw68HjLF/uu625qA2Qa8tiuEoSnKhdSEpVMoYsmFhFiyPgZttz1iq7HbjzRLkTMhRC32 VglR/cby7X6QU9bOQw1FnNax9UjSt X-Google-Smtp-Source: AGHT+IEZSM7e60umftuoTA+5yHKxOw5bEfyTXKI9tFiIm+4qyPCIhcf70tbw/wLp28VjnQQVfyBtmQ== X-Received: by 2002:a17:907:c2a:b0:abf:6b30:7a94 with SMTP id a640c23a62f3a-abf6b58f60cmr1276559166b.45.1741107935884; Tue, 04 Mar 2025 09:05:35 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf795ba15esm367589066b.131.2025.03.04.09.05.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 09:05:35 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 04 Mar 2025 17:05:35 +0000 Subject: [PATCH v2 07/16] rtc: m48t86: drop needless struct m48t86_rtc_info::rtc member MIME-Version: 1.0 Message-Id: <20250304-rtc-cleanups-v2-7-d4689a71668c@linaro.org> References: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> In-Reply-To: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, llvm@lists.linux.dev, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250304_090537_939638_D153E88B X-CRM114-Status: GOOD ( 13.40 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: André Draszik --- drivers/rtc/rtc-m48t86.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-m48t86.c b/drivers/rtc/rtc-m48t86.c index dd4a62e2d39c73b1c8c3f50a59fd4fffc0b45105..10cd054fe86f9e6be74eb282222b2751dd91cc7e 100644 --- a/drivers/rtc/rtc-m48t86.c +++ b/drivers/rtc/rtc-m48t86.c @@ -41,7 +41,6 @@ struct m48t86_rtc_info { void __iomem *index_reg; void __iomem *data_reg; - struct rtc_device *rtc; }; static unsigned char m48t86_readb(struct device *dev, unsigned long addr) @@ -219,6 +218,7 @@ static bool m48t86_verify_chip(struct platform_device *pdev) static int m48t86_rtc_probe(struct platform_device *pdev) { struct m48t86_rtc_info *info; + struct rtc_device *rtc; unsigned char reg; int err; struct nvmem_config m48t86_nvmem_cfg = { @@ -250,17 +250,17 @@ static int m48t86_rtc_probe(struct platform_device *pdev) return -ENODEV; } - info->rtc = devm_rtc_allocate_device(&pdev->dev); - if (IS_ERR(info->rtc)) - return PTR_ERR(info->rtc); + rtc = devm_rtc_allocate_device(&pdev->dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); - info->rtc->ops = &m48t86_rtc_ops; + rtc->ops = &m48t86_rtc_ops; - err = devm_rtc_register_device(info->rtc); + err = devm_rtc_register_device(rtc); if (err) return err; - devm_rtc_nvmem_register(info->rtc, &m48t86_nvmem_cfg); + devm_rtc_nvmem_register(rtc, &m48t86_nvmem_cfg); /* read battery status */ reg = m48t86_readb(&pdev->dev, M48T86_D);