| Message ID | 20250313-a4-a5-reset-v4-2-8076f684d6cf@amlogic.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add support for Amlogic A4/A5 Reset | expand |
On Thu, Mar 13, 2025 at 05:05:35PM +0800, Kelvin Zhang wrote: > &apb { > + reset: reset-controller@2000 { > + compatible = "amlogic,a4-reset", > + "amlogic,meson-s4-reset"; > + reg = <0x0 0x2000 0x0 0x98>; > + #reset-cells = <1>; > + }; > + Why do you have on the bus devices with bus addressing and without it? What sort of bus is it? > periphs_pinctrl: pinctrl { > compatible = "amlogic,pinctrl-a4"; > #address-cells = <2>; Best regards, Krzysztof
On 2025/3/14 16:01, Krzysztof Kozlowski wrote: > > On Thu, Mar 13, 2025 at 05:05:35PM +0800, Kelvin Zhang wrote: >> &apb { >> + reset: reset-controller@2000 { >> + compatible = "amlogic,a4-reset", >> + "amlogic,meson-s4-reset"; >> + reg = <0x0 0x2000 0x0 0x98>; >> + #reset-cells = <1>; >> + }; >> + > > Why do you have on the bus devices with bus addressing and without it? > What sort of bus is it? Are you referring to the 'apb'? If so, the 'apb' bus is defined in arch/arm64/boot/dts/amlogic/amlogic-a4-common.dtsi. apb: bus@fe000000 { compatible = "simple-bus"; reg = <0x0 0xfe000000 0x0 0x480000>; #address-cells = <2>; #size-cells = <2>; ranges = <0x0 0x0 0x0 0xfe000000 0x0 0x480000>; > >> periphs_pinctrl: pinctrl { >> compatible = "amlogic,pinctrl-a4"; >> #address-cells = <2>; > > Best regards, > Krzysztof >
On 17/03/2025 03:49, Kelvin Zhang wrote: >> >> Why do you have on the bus devices with bus addressing and without it? >> What sort of bus is it? > > Are you referring to the 'apb'? > If so, the 'apb' bus is defined in > arch/arm64/boot/dts/amlogic/amlogic-a4-common.dtsi. > > apb: bus@fe000000 { > compatible = "simple-bus"; > reg = <0x0 0xfe000000 0x0 0x480000>; > #address-cells = <2>; > #size-cells = <2>; > ranges = <0x0 0x0 0x0 0xfe000000 0x0 0x480000>; > >> >>> periphs_pinctrl: pinctrl { Then what the heck is this? >>> compatible = "amlogic,pinctrl-a4"; >>> #address-cells = <2>; >> >> Best regards, >> Krzysztof >> > Best regards, Krzysztof
Hi Krzysztof, On 2025/3/17 15:28, Krzysztof Kozlowski wrote: > [ EXTERNAL EMAIL ] > > On 17/03/2025 03:49, Kelvin Zhang wrote: >>> >>> Why do you have on the bus devices with bus addressing and without it? >>> What sort of bus is it? >> >> Are you referring to the 'apb'? >> If so, the 'apb' bus is defined in >> arch/arm64/boot/dts/amlogic/amlogic-a4-common.dtsi. >> >> apb: bus@fe000000 { >> compatible = "simple-bus"; >> reg = <0x0 0xfe000000 0x0 0x480000>; >> #address-cells = <2>; >> #size-cells = <2>; >> ranges = <0x0 0x0 0x0 0xfe000000 0x0 0x480000>; >> >>> >>>> periphs_pinctrl: pinctrl { > > Then what the heck is this? > I will fix it and add the unit address to the pinctrl node. >>>> compatible = "amlogic,pinctrl-a4"; >>>> #address-cells = <2>; >>> >>> Best regards, >>> Krzysztof >>> >> > > > Best regards, > Krzysztof > > _______________________________________________ > linux-amlogic mailing list > linux-amlogic@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-amlogic
diff --git a/arch/arm64/boot/dts/amlogic/amlogic-a4-reset.h b/arch/arm64/boot/dts/amlogic/amlogic-a4-reset.h new file mode 100644 index 0000000000000000000000000000000000000000..f6a4c90bab3cf7cfaa3c98c522bed5e455b73bd3 --- /dev/null +++ b/arch/arm64/boot/dts/amlogic/amlogic-a4-reset.h @@ -0,0 +1,93 @@ +/* SPDX-License-Identifier: (GPL-2.0-only OR MIT) */ +/* + * Copyright (c) 2024 Amlogic, Inc. All rights reserved. + */ + +#ifndef __DTS_AMLOGIC_A4_RESET_H +#define __DTS_AMLOGIC_A4_RESET_H + +/* RESET0 */ +/* 0-3 */ +#define RESET_USB 4 +/* 5-6*/ +#define RESET_U2PHY22 7 +#define RESET_USBPHY20 8 +#define RESET_U2PHY21 9 +#define RESET_USB2DRD 10 +#define RESET_U2H 11 +#define RESET_LED_CTRL 12 +/* 13-31 */ + +/* RESET1 */ +#define RESET_AUDIO 32 +#define RESET_AUDIO_VAD 33 +/* 34*/ +#define RESET_DDR_APB 35 +#define RESET_DDR 36 +#define RESET_VOUT_VENC 37 +#define RESET_VOUT 38 +/* 39-47 */ +#define RESET_ETHERNET 48 +/* 49-63 */ + +/* RESET2 */ +#define RESET_DEVICE_MMC_ARB 64 +#define RESET_IRCTRL 65 +/* 66*/ +#define RESET_TS_PLL 67 +/* 68-72*/ +#define RESET_SPICC_0 73 +#define RESET_SPICC_1 74 +/* 75-79*/ +#define RESET_MSR_CLK 80 +/* 81*/ +#define RESET_SAR_ADC 82 +/* 83-87*/ +#define RESET_ACODEC 88 +/* 89-90*/ +#define RESET_WATCHDOG 91 +/* 92-95*/ + +/* RESET3 */ +/* 96-127 */ + +/* RESET4 */ +/* 128-131 */ +#define RESET_PWM_AB 132 +#define RESET_PWM_CD 133 +#define RESET_PWM_EF 134 +#define RESET_PWM_GH 135 +/* 136-137*/ +#define RESET_UART_A 138 +#define RESET_UART_B 139 +/* 140*/ +#define RESET_UART_D 141 +#define RESET_UART_E 142 +/* 143-144*/ +#define RESET_I2C_M_A 145 +#define RESET_I2C_M_B 146 +#define RESET_I2C_M_C 147 +#define RESET_I2C_M_D 148 +/* 149-151*/ +#define RESET_SDEMMC_A 152 +/* 153*/ +#define RESET_SDEMMC_C 154 +/* 155-159*/ + +/* RESET5 */ +/* 160-175*/ +#define RESET_BRG_AO_NIC_SYS 176 +/* 177*/ +#define RESET_BRG_AO_NIC_MAIN 178 +#define RESET_BRG_AO_NIC_AUDIO 179 +/* 180-183*/ +#define RESET_BRG_AO_NIC_ALL 184 +/* 185*/ +#define RESET_BRG_NIC_SDIO 186 +#define RESET_BRG_NIC_EMMC 187 +#define RESET_BRG_NIC_DSU 188 +#define RESET_BRG_NIC_CLK81 189 +#define RESET_BRG_NIC_MAIN 190 +#define RESET_BRG_NIC_ALL 191 + +#endif diff --git a/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi b/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi index efba8565af3cf5298f894819572d78e0c0041f71..02365494d8655f8cf97f0ffdc9a9566e42ab61ae 100644 --- a/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi +++ b/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi @@ -4,6 +4,7 @@ */ #include "amlogic-a4-common.dtsi" +#include "amlogic-a4-reset.h" #include <dt-bindings/power/amlogic,a4-pwrc.h> #include <dt-bindings/pinctrl/amlogic,pinctrl.h> / { @@ -51,6 +52,13 @@ pwrc: power-controller { }; &apb { + reset: reset-controller@2000 { + compatible = "amlogic,a4-reset", + "amlogic,meson-s4-reset"; + reg = <0x0 0x2000 0x0 0x98>; + #reset-cells = <1>; + }; + periphs_pinctrl: pinctrl { compatible = "amlogic,pinctrl-a4"; #address-cells = <2>;