From patchwork Sat Mar 4 12:21:54 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 9603923 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 587A1602B4 for ; Sat, 4 Mar 2017 12:39:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4876C2843F for ; Sat, 4 Mar 2017 12:39:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3D5362854F; Sat, 4 Mar 2017 12:39:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E8F322843F for ; Sat, 4 Mar 2017 12:39:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ltQMuuIbXK/WmXWeIfoqoRXZHBXHeNDjFiYy5YCaN9g=; b=bJ9ptTi0hkMVWY ca93wLg9k8+rNEiEFKSBHZ56CdMl6moLodqK/Zyepz9GlHE8lXdmavfO6zLUXXidgw71s9A11giIR ZhuLybZdZzJjzJfPUJ7RTnyJ0cuOgBPPxBQd8auiFUlU/fxO7wzaUljWUYDOj4aU+j9Rh6isCtzqL gFkQFPx2/wD+ebAiu6lVnoug+jRxrQLR95f8G2SrCnSCQ3JHUO9wJpYVzk1npnHQrByg16e5DLdvb LsAIYJdExdcBfxvFycPwANAWkjLwGdysMSclAhpZJRzpfFROAQ1XrieScbqpuaOLJT15cJCICOP2I vnnnwxVz5IdY+/Gj+zYw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1ck8xi-00079x-JS; Sat, 04 Mar 2017 12:39:02 +0000 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1ck8xJ-0006qb-Fj for linux-amlogic@lists.infradead.org; Sat, 04 Mar 2017 12:38:39 +0000 Received: by mail-wm0-x242.google.com with SMTP id z63so4629877wmg.2 for ; Sat, 04 Mar 2017 04:38:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=OTgZX/iVWb2AoOwH4XQ+2LP4a3ww5QGP4N3TsgObPJk=; b=grFQJRFpwbTQXT/BZiKvGjywNpIYcKLLNHBYP7jilQmeKl68CpiR+ABgPqaQU8Sx/t OBV+sazn5WkR8Wblfgw7NhRJegyq0SX0/O1esyP/b3C5DxxAupbWbcZe+5w9+Y+gW7f5 i4+sEcygAUQqwcGc8IZ7kk+ELCyft7V90VVo7VDiwPYUIfn/53yrpR/ejhZQopZhFBZW DqvXsHJEtAZQ7SqR9nRKfbLlsL232Z8PHySP90IeAg5gHPH6lkwIe6AIJ5NbbmRggHWG q4P+dx0L4A8xidWdLrWgg2at0/eFUAyX9Q+SXTLH7i5vo65eoqTPR8Euo1dasc/1ez3K 1sLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=OTgZX/iVWb2AoOwH4XQ+2LP4a3ww5QGP4N3TsgObPJk=; b=oEhi4dxj6IucCkigdLOSuh9g0oMHqnQEFxr1wx5KIQqE0o6RPfYO55/iiywnYWH8oU iLTp4GA9WyKKK2kTh+S7estaXW2MbaeqBWABZgtcfhBzgvunyaugUuSaRKQuRgUsAuo6 ++8oNAKMWLFdEr0TYpyqEJhCqo2y6Vx4w5n6hmY+NX3r8KH9IcAP+SZf5btbIwp5KLgc q0SrZkKG8MHbcMG40RcPYY3IxRLnKEShmLbgYhYqDIkTb5tyEiLe4NNSK4rlTPCwYmDg fDVDn0ZIyJ6EgaFCZ3K3ig236Qxj8tK1K2dQOxHuv96hP6WAFfxcVH3cFWz7Qg391QDC e8EQ== X-Gm-Message-State: AMke39k/KsuKmZYgkK2cUXIbkPxNnLmBnlLb8GHOgrPWEFqZKXvugpptEmr1Hgkp6QYH/A== X-Received: by 10.28.140.140 with SMTP id o134mr7171870wmd.87.1488631095846; Sat, 04 Mar 2017 04:38:15 -0800 (PST) Received: from ?IPv6:2003:c6:ebdc:4000:98cd:c51c:6f4e:443? (p200300C6EBDC400098CDC51C6F4E0443.dip0.t-ipconnect.de. [2003:c6:ebdc:4000:98cd:c51c:6f4e:443]) by smtp.googlemail.com with ESMTPSA id r82sm6908793wmd.32.2017.03.04.04.38.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 04 Mar 2017 04:38:15 -0800 (PST) Subject: [PATCH v5 3/10] mmc: meson-gx: remove unused members irq, ocr_mask from struct meson_host To: Ulf Hansson , Kevin Hilman References: From: Heiner Kallweit Message-ID: <713d2aba-76b6-b47d-60d1-1e90d629c292@gmail.com> Date: Sat, 4 Mar 2017 13:21:54 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170304_043837_690645_D56B5788 X-CRM114-Status: UNSURE ( 8.65 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-amlogic@lists.infradead.org, "linux-mmc@vger.kernel.org" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+patchwork-linux-amlogic=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Member ocr_mask is never used and member irq we can replace with a local variable in meson_mmc_probe. So let's remove both members. Signed-off-by: Heiner Kallweit Acked-by: Kevin Hilman --- v2: - added acked-by v3: - no changes v4: - no changes v5: - no changes --- drivers/mmc/host/meson-gx-mmc.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c index b99461ff..b9de3d47 100644 --- a/drivers/mmc/host/meson-gx-mmc.c +++ b/drivers/mmc/host/meson-gx-mmc.c @@ -127,8 +127,6 @@ struct meson_host { spinlock_t lock; void __iomem *regs; - int irq; - u32 ocr_mask; struct clk *core_clk; struct clk_mux mux; struct clk *mux_clk; @@ -712,7 +710,7 @@ static int meson_mmc_probe(struct platform_device *pdev) struct resource *res; struct meson_host *host; struct mmc_host *mmc; - int ret; + int ret, irq; mmc = mmc_alloc_host(sizeof(struct meson_host), &pdev->dev); if (!mmc) @@ -744,8 +742,8 @@ static int meson_mmc_probe(struct platform_device *pdev) goto free_host; } - host->irq = platform_get_irq(pdev, 0); - if (host->irq == 0) { + irq = platform_get_irq(pdev, 0); + if (!irq) { dev_err(&pdev->dev, "failed to get interrupt resource.\n"); ret = -EINVAL; goto free_host; @@ -773,9 +771,9 @@ static int meson_mmc_probe(struct platform_device *pdev) writel(IRQ_EN_MASK, host->regs + SD_EMMC_STATUS); writel(IRQ_EN_MASK, host->regs + SD_EMMC_IRQ_EN); - ret = devm_request_threaded_irq(&pdev->dev, host->irq, - meson_mmc_irq, meson_mmc_irq_thread, - IRQF_SHARED, DRIVER_NAME, host); + ret = devm_request_threaded_irq(&pdev->dev, irq, meson_mmc_irq, + meson_mmc_irq_thread, IRQF_SHARED, + DRIVER_NAME, host); if (ret) goto free_host;