From patchwork Sun Apr 16 20:13:25 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 9683107 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E5ACA60138 for ; Sun, 16 Apr 2017 20:24:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D58BA27B81 for ; Sun, 16 Apr 2017 20:24:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C70DA27CF3; Sun, 16 Apr 2017 20:24:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8421A27CEA for ; Sun, 16 Apr 2017 20:24:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:References:To:From:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=90iPByjfAfUsCkfGVodols4PP8ekmfRRApEFBfus6VY=; b=EOb1Znh7T9kcit qumARwqz+NXVkUuIVVhLmf7O0GjS8h0B9Yng4g6kcI6dhfSTobmL6iiMbs9Nw00K8OJ0taLvFYfCp eA7tbKyu2EU0CErQEG6Ft9OYDuCvkl+tEJBHoE7FCebufshLV2i4zGFGsC4cM7GXHFEYBW6CKlK5H tjpBWs7dGch4DTC41tWXsIS5uvuVaUuPzxVvj6TtFG2jQsE9cexP+eV1NvPMEssaki15RnDRyASP4 WMzwVIdiAh1XQC70R7wcR0iNgNeVqONK3a2BbuOc4F0wcZPktDB3VMJlLjJW7spYcOk1cY5kYN3+5 OXWLJwHiKF/TDTnti0Iw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1czqip-00040h-Il; Sun, 16 Apr 2017 20:24:35 +0000 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1czqil-0003rA-Ug for linux-amlogic@lists.infradead.org; Sun, 16 Apr 2017 20:24:33 +0000 Received: by mail-wm0-x243.google.com with SMTP id z129so3639822wmb.1 for ; Sun, 16 Apr 2017 13:24:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=5ow0kZRGXfFb9ZO9qFN3YmdHddG+m31Dsk/tFwdTgnY=; b=eXYWpsyzrKmT2wAsQe9STV7B2DAw3cpRHyE7fkTeVdrQ/k0al+A9iPmgrRV64H5wVf Wn1XFl+qG2yyuvuzhoCIdcFepB63SLKeDpPf95pqHfMKdYxdtX2NiwzUiq9v4EN4d2hX A8VwHfo3SBMhQj8Y8n5lSVRWcL//OMpYE+M1GQ30RuwVqaL6id/1tglB+cG4AJimbSgg iLFpl+APh/gKJlBSC3PYWRuJWaOBkhz02t+LYK2fKYhKrAWSNpaGwnXdgI2KtyOZ1v47 WHNkCerHlZfxyPoxYEL7hJAEKqHT9+NdEdcEmgjxQkHp1X3fN9go6pCWauHLm+S+qKce kxpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=5ow0kZRGXfFb9ZO9qFN3YmdHddG+m31Dsk/tFwdTgnY=; b=K412VRle4CxmJLnLRFdiri7DQmuk73MiD76BW8Ky1Zs/US5kxpBkNg/37wGunUFUtz yOynibu1A0MpRY4Sl5wQWkl8KGF3lLPl3nwgeE3WjuwDk0EqFu+tfetoSllltHL0F0lY A6yoxVBoplT/QBiRp3FEBUbKkwNMjlm6Hjltr3XOh8zX4EkGCQBi+g/BfB5kR4Fll/no bq/n8G/Y95N0yc5uT/CsGh3RMYYgp2VxpnglnF21lc6uWChwu950hKCazPx0S7Km/X4o AWahcE/jilIkyTrhO64J+OCyqkS8843bQ00GLdn18Zrbp/mn1kqMn+Xr40j38tmeK3Ll bbUQ== X-Gm-Message-State: AN3rC/4+FTTV6SDuuRLuEdrAOXGbPvABx0rQC9o+7x5GIQlqcSuhymOB Zm57/JDVs13FQVPS X-Received: by 10.28.133.7 with SMTP id h7mr2328239wmd.67.1492374248002; Sun, 16 Apr 2017 13:24:08 -0700 (PDT) Received: from ?IPv6:2003:c6:ebdc:4000:707e:f128:10e3:ba12? (p200300C6EBDC4000707EF12810E3BA12.dip0.t-ipconnect.de. [2003:c6:ebdc:4000:707e:f128:10e3:ba12]) by smtp.googlemail.com with ESMTPSA id k90sm7684235wmi.26.2017.04.16.13.24.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 16 Apr 2017 13:24:07 -0700 (PDT) Subject: [PATCH 3/6] serial: meson: remove unneeded variable assignment in meson_serial_port_write From: Heiner Kallweit To: Kevin Hilman , Greg Kroah-Hartman References: Message-ID: Date: Sun, 16 Apr 2017 22:13:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170416_132432_213535_5076F558 X-CRM114-Status: UNSURE ( 7.33 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-amlogic@lists.infradead.org, =?UTF-8?Q?Andreas_F=c3=a4rber?= , linux-serial@vger.kernel.org Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+patchwork-linux-amlogic=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP AML_UART_TX_EN is set in meson_uart_startup and there's no place in the driver where it gets cleared. Therefore we don't have to set it here. Signed-off-by: Heiner Kallweit Reviewed-by: Neil Armstrong --- drivers/tty/serial/meson_uart.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c index 22857f1e..714b29ad 100644 --- a/drivers/tty/serial/meson_uart.c +++ b/drivers/tty/serial/meson_uart.c @@ -497,7 +497,6 @@ static void meson_serial_port_write(struct uart_port *port, const char *s, } val = readl(port->membase + AML_UART_CONTROL); - val |= AML_UART_TX_EN; tmp = val & ~(AML_UART_TX_INT_EN | AML_UART_RX_INT_EN); writel(tmp, port->membase + AML_UART_CONTROL);