From patchwork Sun Nov 19 04:52:43 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 10065059 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 95A0F602B7 for ; Sun, 19 Nov 2017 04:53:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8EAE72624A for ; Sun, 19 Nov 2017 04:53:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8387229455; Sun, 19 Nov 2017 04:53:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 112DA2624A for ; Sun, 19 Nov 2017 04:53:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=XIhBWHI8BIIqsnvs60Yswtcqur2i0G4vDwyASG8owmI=; b=ewh aH/OIqz/CsvSQhWPXZRC5NhQmgrnirVFdLJORJuFJEbwKgQzxW49RNYfm0J6574N8it2aMWQQ9S2/ FJmxjTennw8uHXxIW+h2nTPNM5BHfq2qqQ+aYdoBQrltOsYujKNLmPMwveVIc6xIDrssqKk99YC7i Lzb8G1uK2SLuxRLyq7mQMrOrYHMEaX+GJ2M6VQ+VbfGQRIw8/uwsLk2M3xFfgRkL4hsdlGZ2UwLG2 HVRqWfrnsJRufRgSrjn4SNVUtj7zMgVpoT8AKkFB7TgwGV5k/ATNIZX8WwQhFYVGsvGqmBiBjybCc pxwSRQD/+n3n2UAgwJk25C7tPi2gbig==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eGHbv-0000iN-MI; Sun, 19 Nov 2017 04:53:39 +0000 Received: from mail-pg0-x242.google.com ([2607:f8b0:400e:c05::242]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1eGHbc-0000PU-5P; Sun, 19 Nov 2017 04:53:21 +0000 Received: by mail-pg0-x242.google.com with SMTP id l19so4885349pgo.2; Sat, 18 Nov 2017 20:53:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=/dNHQeVwfe6bDvdn5cHntoOPiaJbQQ59731iAVB0hY0=; b=m7vtxy+Jm0cZX87CCJWw3ZnFJDReJPcgNLO0iRPP1St2VlSCkI4Hh1Q2wM/q4a+OkJ FZHOu4Iz+GSi2HmtRfqOCkNO1fHyhE0GYhlIJdJkxTZAZ6ZYFAgsHqq6XsvH98tt211K /WzLJUA8xr6LA+2OYjpxbBc4WWfV92Ff+xanxKdQKYX87/aI+Nag08K1vrFBCNhrCIyy IjMzwekKEzgCNz30v0bixaNNKtmcJ6xYgAO7pVjXUoR0c8LuL9WqLSqcdM2MdnzQqJO1 0ZSYRcz/n18JwjA7phdRvhl8PBedHxXqD8mkzjC2RALYrJ1W8qxb1q6HjHeiMHKG+z0S j3kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=/dNHQeVwfe6bDvdn5cHntoOPiaJbQQ59731iAVB0hY0=; b=l3C3tMQRuBCZyUmgBvjgrXdUfndVKdL0QgdUBuE7lYV1uj0T7rYiD+BBIbJVJB+CUo Ux0VVUx9VGIs74HhgDVt1fyXqTxHoSTLFmJfuRuFTTdiDMGmaodixUvSkfFx6dA4+M7Y eIaMwIhfxG5KH3XnOrqaNERdwbfJqdoX5vPkaEDfsU5ecuPPUgo5pkkJZAgDRwrwHpXR iDmHj8DwSjoVleJISxB2s0hy70NZeNkFpCM/Qel/sV/yIoJ6OI/10Y+v3jAuMxDRiam6 5P4yF4/LEu5cX7xzBmJ7QpNfPnbgJppQafXAo6fZyYYuDfvHVepljwxRmSogKG94KSL8 Gjiw== X-Gm-Message-State: AJaThX4o3kr/k3Xz9GCqH6glNH/4y4Pto8mCNmEIHd1eMO5wmnI2teY7 DaIUEFEMESAUodlcDyPGfWk= X-Google-Smtp-Source: AGs4zMYZME1CFy8m44bjnJ2usfJLXm6CeeelKZTf4opjhErwHtqLyxyVg+kcszCHfKlBBlxETCnIoA== X-Received: by 10.99.134.73 with SMTP id x70mr9943489pgd.130.1511067179702; Sat, 18 Nov 2017 20:52:59 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id j79sm2312952pfe.129.2017.11.18.20.52.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 18 Nov 2017 20:52:59 -0800 (PST) From: Arvind Yadav To: ben-linux@fluff.org, ulf.hansson@linaro.org, adrian.hunter@intel.com, vireshk@kernel.org, maxime.ripard@free-electrons.com, wens@csie.org, linux@armlinux.org.uk, carlo@caione.org, khilman@baylibre.com Subject: [PATCH 1/6 v3] mmc: meson-gx-mmc: Fix platform_get_irq's error checking Date: Sun, 19 Nov 2017 10:22:43 +0530 Message-Id: X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171118_205320_242936_1BEE61E8 X-CRM114-Status: UNSURE ( 8.63 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-amlogic@lists.infradead.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+patchwork-linux-amlogic=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav Acked-by: Kevin Hilman --- changes in v2 : Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid. changes in v3 : return -EINVAL instead of irq. drivers/mmc/host/meson-gx-mmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c index e0862d3..32a6a22 100644 --- a/drivers/mmc/host/meson-gx-mmc.c +++ b/drivers/mmc/host/meson-gx-mmc.c @@ -1208,7 +1208,7 @@ static int meson_mmc_probe(struct platform_device *pdev) } irq = platform_get_irq(pdev, 0); - if (!irq) { + if (irq <= 0) { dev_err(&pdev->dev, "failed to get interrupt resource.\n"); ret = -EINVAL; goto free_host;