From patchwork Fri Mar 3 19:53:38 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 9603439 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7330760414 for ; Fri, 3 Mar 2017 20:01:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 649F828632 for ; Fri, 3 Mar 2017 20:01:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 596A328636; Fri, 3 Mar 2017 20:01:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 0E1D028632 for ; Fri, 3 Mar 2017 20:01:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=69zKhMQa7WPFhl9m8g30O026m9AEi445PH+2rkZN4PE=; b=qSNQSMtebHyaL3 JUApUzdEvV4LIkxUuLnTv2NpnHaJnW4ShiJuWKY7Tc0a00wAbLoCBbUfxHZU/IRYcMUNLAXZ6BUxm svH4mX5uleZDTn1teFkMd+N1BfplqQJRatNuL0byo0bXHFppDlu7v760nk+37rf+gQYj8arPBVoj/ uht63i0MMmrPcpQngTo3JvbubbORzdoo6QiGsn33RV3pHtimSBhcJR2FaBBIc7zAatNVVVA3olXov JXMtG90vf9QlQR6noYw/5nXuCNHWV6zfRT7iwOThpJBNVFEoUkpEL6BoXfZg2vaqH4ZkPY/VSR2KO KDygl0mjwM4rlpvaMA3Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cjtNz-0007Wy-OI; Fri, 03 Mar 2017 20:01:07 +0000 Received: from mail-wr0-x244.google.com ([2a00:1450:400c:c0c::244]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cjtNv-0007Oh-Fn for linux-amlogic@lists.infradead.org; Fri, 03 Mar 2017 20:01:05 +0000 Received: by mail-wr0-x244.google.com with SMTP id u108so10557026wrb.2 for ; Fri, 03 Mar 2017 12:00:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=80vlnTDvrbuVe2Yw/lty8EOBIwJTU6DHjfX5iRmoInk=; b=PR+EJKzH73Gnca+3r7P7DPVF+z5x1ep7lEjS9v35ml5A2qe5i4IeqPSmdpW/SDt7qk wA/UzuGCdW6klpJktUNm/IyAynKKcO330eNuxBkxXIBsg0tJEJLsFBTWdaUoDaSQviYT KTEmBJxHz5te/HzweNh50kR1JOflGUqiLtWsoE3O3MsycspIw9GftjBzPuSCbJsK+OPc Q98o+crpLGwh8uior3LKmAUloZAJbZ+bQUODGWHKkwN7Yai+pq23nM9PWmKwHn3Ulvx+ Nql86aZqqbeWumnDQ+zOB6gbQv8nOLwCNtTNVu4Vh9ztIra+tpMIiJAckzPFUiLv9e+Y Sjeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=80vlnTDvrbuVe2Yw/lty8EOBIwJTU6DHjfX5iRmoInk=; b=f1VoNfTRz1tSVenyrPfWsnJ3d+Yj7DxpvI2QpBlSWylBdF7EwbCR305BX25ElOLJBY oM9IQY071acI9CdwZJ9B/o76jMe7dnBnSRepndqlHAauOf4wdZWj7rNY7lGUleD8EeYd SC0uuQKUlH+F3g4Xg/WVPotq8+0dwyv1tA97hYJCeMnytD+SimH5SiPc5j9oFsXy7CXO OCv2jFs72saXtqdtp3ej9+K5F3cppguVuUOH6tbBJw20sW8EtfFImQGZTZtC9ZWzrhU2 9HWOzBvzEthgQaO0GfB2O90r5k44WtKvhL8URKIR0UEKN9dOlyCt6klaIducBrqkfWlB lPcg== X-Gm-Message-State: AMke39kPGjZ22lBqzoANCWz/5YawzobsF8ktKx7RmDo0l2GSpWTdlXl5zdJ1oS+sR+90AQ== X-Received: by 10.223.130.214 with SMTP id 80mr4406356wrc.43.1488571241819; Fri, 03 Mar 2017 12:00:41 -0800 (PST) Received: from ?IPv6:2003:c6:ebdc:4000:f903:fe11:afad:80a0? (p200300C6EBDC4000F903FE11AFAD80A0.dip0.t-ipconnect.de. [2003:c6:ebdc:4000:f903:fe11:afad:80a0]) by smtp.googlemail.com with ESMTPSA id y69sm16403822wrc.69.2017.03.03.12.00.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 Mar 2017 12:00:41 -0800 (PST) Subject: [PATCH v4 3/10] mmc: meson-gx: remove unused members irq, ocr_mask from struct meson_host To: Ulf Hansson , Kevin Hilman References: <62912f3d-2307-cfff-3c69-c8b8ffaeb474@gmail.com> From: Heiner Kallweit Message-ID: Date: Fri, 3 Mar 2017 20:53:38 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <62912f3d-2307-cfff-3c69-c8b8ffaeb474@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170303_120103_681652_C5B8B517 X-CRM114-Status: UNSURE ( 8.49 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-amlogic@lists.infradead.org, "linux-mmc@vger.kernel.org" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+patchwork-linux-amlogic=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Member ocr_mask is never used and member irq we can replace with a local variable in meson_mmc_probe. So let's remove both members. Signed-off-by: Heiner Kallweit Acked-by: Kevin Hilman --- v2: - added acked-by v3: - no changes v4: - no changes --- drivers/mmc/host/meson-gx-mmc.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c index b99461ff..b9de3d47 100644 --- a/drivers/mmc/host/meson-gx-mmc.c +++ b/drivers/mmc/host/meson-gx-mmc.c @@ -127,8 +127,6 @@ struct meson_host { spinlock_t lock; void __iomem *regs; - int irq; - u32 ocr_mask; struct clk *core_clk; struct clk_mux mux; struct clk *mux_clk; @@ -712,7 +710,7 @@ static int meson_mmc_probe(struct platform_device *pdev) struct resource *res; struct meson_host *host; struct mmc_host *mmc; - int ret; + int ret, irq; mmc = mmc_alloc_host(sizeof(struct meson_host), &pdev->dev); if (!mmc) @@ -744,8 +742,8 @@ static int meson_mmc_probe(struct platform_device *pdev) goto free_host; } - host->irq = platform_get_irq(pdev, 0); - if (host->irq == 0) { + irq = platform_get_irq(pdev, 0); + if (!irq) { dev_err(&pdev->dev, "failed to get interrupt resource.\n"); ret = -EINVAL; goto free_host; @@ -773,9 +771,9 @@ static int meson_mmc_probe(struct platform_device *pdev) writel(IRQ_EN_MASK, host->regs + SD_EMMC_STATUS); writel(IRQ_EN_MASK, host->regs + SD_EMMC_IRQ_EN); - ret = devm_request_threaded_irq(&pdev->dev, host->irq, - meson_mmc_irq, meson_mmc_irq_thread, - IRQF_SHARED, DRIVER_NAME, host); + ret = devm_request_threaded_irq(&pdev->dev, irq, meson_mmc_irq, + meson_mmc_irq_thread, IRQF_SHARED, + DRIVER_NAME, host); if (ret) goto free_host;