From patchwork Mon Jun 11 10:01:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: st6589@public-files.de X-Patchwork-Id: 10457513 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5A66460467 for ; Mon, 11 Jun 2018 10:07:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3468428179 for ; Mon, 11 Jun 2018 10:07:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 28A9C2832B; Mon, 11 Jun 2018 10:07:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id CD3ED28179 for ; Mon, 11 Jun 2018 10:07:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:Content-Type: Subject:To:From:Message-ID:MIME-Version:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=EYDwjU0f8lSnDFL7g293Wn4utqb5BRGNJb+yIyukEmc=; b=B1UXQ+mTl2lRAidX/+2y6zzPFY c/w/wvP9yVmvBN7yG6BXxgbHdsOYSCG4Oh378oX/NiRZzVqE6jKtcJZ+n5kc+37M0sZIh2dXr7TQE +YN5I8r3rWlYwcnNsNlmB/nhWW6mayo7BOla99kxGQ4nNNx0N8ViXk4MMIPuuhwYntdTjozMz5Ou3 mL/q3gMV4qFnuZ/hnoO1S/HovgnhKGi63/VyRwz+lm73DRpBXeHmUhlQqnM5RUtJBRM1S5XAEfQak hwwEf0P9kjL3kZt01G9jsQMLzqXGquCo6za1A1advEDsb2ApGlcpgUGsjfaQhOHkp9P4fvYwAYeZS A6Qh+wLg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fSJjA-0003Yl-Nn; Mon, 11 Jun 2018 10:07:08 +0000 Received: from mout.gmx.net ([212.227.17.20]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fSJj6-0003Vb-HJ for linux-amlogic@lists.infradead.org; Mon, 11 Jun 2018 10:07:06 +0000 Received: from [213.128.98.93] ([213.128.98.93]) by 3c-app-gmx-bs27.server.lan (via HTTP); Mon, 11 Jun 2018 12:01:43 +0200 MIME-Version: 1.0 Message-ID: From: st6589@public-files.de To: linux-kernel@vger.kernel.org Subject: [BUG] Pinning in pinctrl-meson-gxbb.c for uart_C is wrong Date: Mon, 11 Jun 2018 12:01:43 +0200 Importance: normal Sensitivity: Normal X-Priority: 3 X-Provags-ID: V03:K1:QDs9JIOnupg8cWvj0TovdAFI0KSA1wC8NXSn1j1grlr dPYdSgQBYsSobhZgcaTfsacVdCfLCkA9cTWwSr/sMi2aR/jR2l pdkFtGtOB/U86e2NSBiqm0eChQZ6BSDrNOM2gASVtEMtLrjgXL c2hyKBg0lhO4nmLrja8g91bgyCyu/o73c9R3r6kfA6BoOm+mck yJmqWkL9hGxFRXrHGp110I0QAuAYYtAFgDDrzgRzd87ql1qA70 2OnXDa5Lp+5DKy+SY3dOOLKXSmKSF80fzwKHvBecfnFQRJE+XM Hu9cgk= X-UI-Out-Filterresults: notjunk:1; V01:K0:j+FRO/52TBE=:1ST39NfBYnBYoY2TkREG3U YUWuHOdiDkqUIwnv9KvMNWbGeA2JEKIb+BDFniguJfHH2eIzCMPlz3gmqkkigA5sGJoB8RMNx PEolg7Gs0CfRyW1H2UwSv9SuFcw9ESy5tNumd84muMhUQSzV3dQDVLzExDmnJMTHB1rkpviNP 18M81ybY1rWNo51DCt6u6ERBAX9oRN18f22uFOhAB7SX61eRD+2Dsny0SsI/4VU63SHAgWE28 8kFl4kyUikGIfzxRBwMcOHxS80nDwEQpnnks07KYY452IY7EnpzHgLUkeq/p/Gof+Kz8fyBDb wluPvXd9IRAdPD+iEyqDdMYWrFzOLx/1laFcDoBF6JthG21sIjDWsM+Bi4Run4g6t5a7/D6cT SPMZ010QN5VlJsug3dLzoypyosGSKNlYQ80lQjTtyqgRdNofXBs4PtHiiIkWQJlKoxxie4fWy YkiEVKFRpRbKhoyTg43NW0EiJJNRiSI50GDCzvZ7LKVlmvQW00WR X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180611_030704_870676_2A41710E X-CRM114-Status: UNSURE ( 6.77 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-amlogic@lists.infradead.org Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+patchwork-linux-amlogic=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Hello with the actuel Pinning definition in  pinctrl-meson-gxbb.c for the uart_c the system crashes when activated. The seams to be a depency with mmc driver for SD cards.   according to the comment here: https://forum.odroid.com/viewtopic.php?f=137&t=25373#p177855 the seams to be an error in the amlogic datasheets regarding uart_c   with the attached patch everything works as it should.   Best regards     ## # https://forum.odroid.com/viewtopic.php?f=137&t=25373#p177855 # ## # https://forum.odroid.com/viewtopic.php?f=137&t=25373#p177855 # --- linux-next-20180608/drivers/pinctrl/meson/pinctrl-meson-gxbb.c.orig 2018-06-09 12:03:58.921540445 +0200 +++ linux-next-20180608/drivers/pinctrl/meson/pinctrl-meson-gxbb.c 2018-06-10 18:51:52.080665271 +0200 @@ -198,8 +198,8 @@ static const unsigned int uart_tx_c_pins[] = { GPIOY_13 }; static const unsigned int uart_rx_c_pins[] = { GPIOY_14 }; -static const unsigned int uart_cts_c_pins[] = { GPIOX_11 }; -static const unsigned int uart_rts_c_pins[] = { GPIOX_12 }; +static const unsigned int uart_cts_c_pins[] = { GPIOY_11 }; +static const unsigned int uart_rts_c_pins[] = { GPIOY_12 }; static const unsigned int i2c_sck_a_pins[] = { GPIODV_25 }; static const unsigned int i2c_sda_a_pins[] = { GPIODV_24 }; @@ -443,10 +443,10 @@ GROUP(pwm_f_x, 3, 18), /* Bank Y */ - GROUP(uart_cts_c, 1, 19), - GROUP(uart_rts_c, 1, 18), - GROUP(uart_tx_c, 1, 17), - GROUP(uart_rx_c, 1, 16), + GROUP(uart_cts_c, 1, 17), + GROUP(uart_rts_c, 1, 16), + GROUP(uart_tx_c, 1, 19), + GROUP(uart_rx_c, 1, 18), GROUP(pwm_a_y, 1, 21), GROUP(pwm_f_y, 1, 20), GROUP(i2s_out_ch23_y, 1, 5),