[00/10] staging: vc04_services: Improve driver load/unload

Message

Stefan Wahren Dec. 6, 2018, 6:28 p.m. UTC

This patch series improves the load/unload of bcm2835 camera and audio
drivers.

Changes since RFC:
- rebase on current staging-next
- add Nicolas' reviewed-by
- address Dan Carpenter's comments about error handling of device registration

Stefan Wahren (10):
  staging: bcm2835-camera: Abort probe if there is no camera
  staging: bcm2835-camera: fix module autoloading
  staging: bcm2835-camera: Move module info to the end
  staging: vchiq_arm: Fix camera device registration
  staging: vchiq_arm: Register a platform device for audio
  staging: bcm2835-audio: Enable compile test
  staging: bcm2835-audio: use module_platform_driver() macro
  staging: bcm2835-audio: Drop DT dependency
  staging: bcm2835-camera: Provide more specific probe error messages
  staging: bcm2835-camera: Add hint about possible faulty config

 .../staging/vc04_services/bcm2835-audio/Kconfig    |  2 +-
 .../staging/vc04_services/bcm2835-audio/bcm2835.c  | 51 +++-----------
 .../vc04_services/bcm2835-camera/bcm2835-camera.c  | 78 +++++++++++++++-------
 .../vc04_services/bcm2835-camera/mmal-vchiq.c      |  5 +-
 .../vc04_services/interface/vchiq_arm/vchiq_arm.c  | 29 +++++++-
 5 files changed, 95 insertions(+), 70 deletions(-)

Comments

Dan Carpenter Dec. 7, 2018, 6:21 a.m. UTC | #1

This looks really nice.

Reviewed-by: Dan Carpenter <[e-mail]>

regards,
dan carpenter