| Message ID | 1555603631-8107-1-git-send-email-Dave.Martin@arm.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | KVM: arm64: SVE cleanups | expand |
Dave Martin <Dave.Martin@arm.com> writes: > This series contains some cleanups applicable to the SVE KVM support > patches merged into kvmarm/next. These arose from Andrew Jones' > review. Does this mean these won't get merged into the original series before the final merging upstream? <snip> -- Alex Bennée
On 24/04/2019 10:21, Alex Bennée wrote: > > Dave Martin <Dave.Martin@arm.com> writes: > >> This series contains some cleanups applicable to the SVE KVM support >> patches merged into kvmarm/next. These arose from Andrew Jones' >> review. > > Does this mean these won't get merged into the original series before > the final merging upstream? I've queued these on top of the existing SVE patches. I'm quite keen on not rebasing -next at this stage. Thanks, M.
Dave Martin <Dave.Martin@arm.com> writes: > This series contains some cleanups applicable to the SVE KVM support > patches merged into kvmarm/next. These arose from Andrew Jones' > review. > > Apart from some minor changes to error codes and checking, these are > mostly cosmetic / sytlistic changes only. > > The patches are based on > git://git.kernel.org/pub/scm/linux/kernel/git/kvmarm/kvmarm.git next > 5d8d4af24460 ("arm64: KVM: Fix system register enumeration") > > This series in git: > git://linux-arm.org/linux-dm.git sve-kvm-fixes/v2/head > http://linux-arm.org/git?p=linux-dm.git;a=shortlog;h=refs/heads/sve-kvm-fixes/v2/head > > Tested with qemu and kvmtool on ThunderX2, and with kvmtool on the Arm > Fast model (to exercise SVE support). These all look good to me: Reviewed-by: Alex Bennée <alex.bennee@linaro.org> -- Alex Bennée
On Thu, Apr 25, 2019 at 01:35:56PM +0100, Alex Bennée wrote: > > Dave Martin <Dave.Martin@arm.com> writes: > > > This series contains some cleanups applicable to the SVE KVM support > > patches merged into kvmarm/next. These arose from Andrew Jones' > > review. > > > > Apart from some minor changes to error codes and checking, these are > > mostly cosmetic / sytlistic changes only. > > > > The patches are based on > > git://git.kernel.org/pub/scm/linux/kernel/git/kvmarm/kvmarm.git next > > 5d8d4af24460 ("arm64: KVM: Fix system register enumeration") > > > > This series in git: > > git://linux-arm.org/linux-dm.git sve-kvm-fixes/v2/head > > http://linux-arm.org/git?p=linux-dm.git;a=shortlog;h=refs/heads/sve-kvm-fixes/v2/head > > > > Tested with qemu and kvmtool on ThunderX2, and with kvmtool on the Arm > > Fast model (to exercise SVE support). > > These all look good to me: > > Reviewed-by: Alex Bennée <alex.bennee@linaro.org> Thanks for the review! Cheers ---Dave
This series contains some cleanups applicable to the SVE KVM support patches merged into kvmarm/next. These arose from Andrew Jones' review. Apart from some minor changes to error codes and checking, these are mostly cosmetic / sytlistic changes only. The patches are based on git://git.kernel.org/pub/scm/linux/kernel/git/kvmarm/kvmarm.git next 5d8d4af24460 ("arm64: KVM: Fix system register enumeration") This series in git: git://linux-arm.org/linux-dm.git sve-kvm-fixes/v2/head http://linux-arm.org/git?p=linux-dm.git;a=shortlog;h=refs/heads/sve-kvm-fixes/v2/head Tested with qemu and kvmtool on ThunderX2, and with kvmtool on the Arm Fast model (to exercise SVE support). Some additional manual testing was done to exercise the updated error behaviours when accessing the SVE registers via ioctl. Dave Martin (14): arm64/sve: Clarify vq map semantics KVM: arm/arm64: Demote kvm_arm_init_arch_resources() to just set up SVE KVM: arm: Make vcpu finalization stubs into inline functions KVM: arm64/sve: sys_regs: Demote redundant vcpu_has_sve() checks to WARNs KVM: arm64/sve: Clean up UAPI register ID definitions KVM: arm64/sve: Miscellaneous tidyups in guest.c KVM: arm64/sve: Make register ioctl access errors more consistent KVM: arm64/sve: WARN when avoiding divide-by-zero in sve_reg_to_region() KVM: arm64/sve: Simplify KVM_REG_ARM64_SVE_VLS array sizing KVM: arm64/sve: Explain validity checks in set_sve_vls() KVM: arm/arm64: Clean up vcpu finalization function parameter naming KVM: Clarify capability requirements for KVM_ARM_VCPU_FINALIZE KVM: Clarify KVM_{SET,GET}_ONE_REG error code documentation KVM: arm64: Clarify access behaviour for out-of-range SVE register slice IDs Documentation/virtual/kvm/api.txt | 24 ++++++----- arch/arm/include/asm/kvm_host.h | 13 ++++-- arch/arm64/include/asm/fpsimd.h | 4 -- arch/arm64/include/asm/kvm_host.h | 4 +- arch/arm64/include/uapi/asm/kvm.h | 32 ++++++++++---- arch/arm64/kernel/fpsimd.c | 7 ++- arch/arm64/kvm/guest.c | 91 +++++++++++++++++++++++---------------- arch/arm64/kvm/reset.c | 6 +-- arch/arm64/kvm/sys_regs.c | 4 +- virt/kvm/arm/arm.c | 2 +- 10 files changed, 116 insertions(+), 71 deletions(-)