mbox series

[v4,0/4] coresight: Do not call smp_processor_id from pre-emptible contexts

Message ID 1559837807-15447-1-git-send-email-suzuki.poulose@arm.com (mailing list archive)
Headers show
Series coresight: Do not call smp_processor_id from pre-emptible contexts | expand

Message

Suzuki K Poulose June 6, 2019, 4:16 p.m. UTC
We have a few places where we call smp_processor_id() from preemptible
contexts during the perf buffer handling. We do this to figure out the
numa node for the allocation in case the event is not CPU bound. Instead
use NUMA_NO_NODE to avoid a splat.


Changes since v3:
 - No function changes. Fix the commit description
Changes since V2:
 - Use NUMA_NO_NODE instead of numa_node_id() for event->cpu == -1. (Robin Murphy)


Suzuki K Poulose (4):
  coresight: tmc-etr: Do not call smp_processor_id() from preemptible
  coresight: tmc-etr: alloc_perf_buf: Do not call smp_processor_id from
    preemptible
  coresight: tmc-etf: Do not call smp_processor_id from preemptible
  coresight: etb10: Do not call smp_processor_id from preemptible

 drivers/hwtracing/coresight/coresight-etb10.c   |  6 ++----
 drivers/hwtracing/coresight/coresight-tmc-etf.c |  6 ++----
 drivers/hwtracing/coresight/coresight-tmc-etr.c | 13 ++++---------
 3 files changed, 8 insertions(+), 17 deletions(-)

Comments

Mathieu Poirier June 6, 2019, 5:46 p.m. UTC | #1
On Thu, 6 Jun 2019 at 10:17, Suzuki K Poulose <suzuki.poulose@arm.com> wrote:
>
> We have a few places where we call smp_processor_id() from preemptible
> contexts during the perf buffer handling. We do this to figure out the
> numa node for the allocation in case the event is not CPU bound. Instead
> use NUMA_NO_NODE to avoid a splat.
>
>
> Changes since v3:
>  - No function changes. Fix the commit description
> Changes since V2:
>  - Use NUMA_NO_NODE instead of numa_node_id() for event->cpu == -1. (Robin Murphy)
>
>
> Suzuki K Poulose (4):
>   coresight: tmc-etr: Do not call smp_processor_id() from preemptible
>   coresight: tmc-etr: alloc_perf_buf: Do not call smp_processor_id from
>     preemptible
>   coresight: tmc-etf: Do not call smp_processor_id from preemptible
>   coresight: etb10: Do not call smp_processor_id from preemptible
>
>  drivers/hwtracing/coresight/coresight-etb10.c   |  6 ++----
>  drivers/hwtracing/coresight/coresight-tmc-etf.c |  6 ++----
>  drivers/hwtracing/coresight/coresight-tmc-etr.c | 13 ++++---------
>  3 files changed, 8 insertions(+), 17 deletions(-)

And this set.

Thanks,
Mathieu

>
> --
> 2.7.4
>