| Message ID | 1561042073-617-1-git-send-email-sorganov@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | serial: imx: fix RTS and RTS/CTS handling | expand |
Hi Sergey, On Thu, Jun 20, 2019 at 05:47:46PM +0300, Sergey Organov wrote: > The patches are not tested yet, so the RFC in the header. I'll re-roll > without RFC once Sasha Hauer tests them. > > Sasha, in addition to already discussed fixes, I've also reordered 2 > patches so that the sequence makes sense. > I reviewed and tested this series, so when resending you can add my: Reviewed-by: Sascha Hauer <s.hauer@pengutronix.de> Tested-by: Sascha Hauer <s.hauer@pengutronix.de> Thanks Sascha
Hi Sasha, Sascha Hauer <s.hauer@pengutronix.de> writes: > Hi Sergey, > > On Thu, Jun 20, 2019 at 05:47:46PM +0300, Sergey Organov wrote: >> The patches are not tested yet, so the RFC in the header. I'll re-roll >> without RFC once Sasha Hauer tests them. >> >> Sasha, in addition to already discussed fixes, I've also reordered 2 >> patches so that the sequence makes sense. >> > > I reviewed and tested this series, so when resending you can add my: > > Reviewed-by: Sascha Hauer <s.hauer@pengutronix.de> > Tested-by: Sascha Hauer <s.hauer@pengutronix.de> Thank you so much! Have a nice day, -- Sergey
The patches are not tested yet, so the RFC in the header. I'll re-roll without RFC once Sasha Hauer tests them. Sasha, in addition to already discussed fixes, I've also reordered 2 patches so that the sequence makes sense. Changelog: v1: * Fixed in "serial: imx: set_termios(): preserve RTS state" -+ ucr2 = UCR2_SRST | UCR2_IRTS; ++ ucr2 |= UCR2_SRST | UCR2_IRTS; as noticed by Lothar Waßmann <LW@KARO-electronics.de> * Fixed in "serial: imx: set_termios(): preserve RTS state" -+ ucr2 = old_ucr2 & (UCR2_TXEN | UCR2_RXEN | UCR2_ATEN | UCR2_CTSC); ++ ucr2 = old_ucr2 & (UCR2_TXEN | UCR2_RXEN | UCR2_ATEN | UCR2_CTS); as the fix for the problem found by Sascha Hauer <s.hauer@pengutronix.de> * Reordered: serial: imx: set_termios(): preserve RTS state serial: imx: set_termios(): do not enable autoRTS if RTS is unset as the latter makes sense only provided the former is already applied. Sergey Organov (7): serial: imx: fix locking in set_termios() serial: imx: set_termios(): factor-out 'ucr2' initial value serial: imx: set_termios(): clarify RTS/CTS bits calculation serial: imx: set_termios(): preserve RTS state serial: imx: set_termios(): do not enable autoRTS if RTS is unset serial: imx: set_mctrl(): correctly restore autoRTS state serial: imx: get rid of imx_uart_rts_auto() drivers/tty/serial/imx.c | 93 ++++++++++++++++++++++++------------------------ 1 file changed, 47 insertions(+), 46 deletions(-) -- 2.10.0.1.g57b01a3