| Message ID | 1565594914-18999-1-git-send-email-appana.durga.rao@xilinx.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | can: xilinx_can: Bug fixes | expand |
On 8/12/19 9:28 AM, Appana Durga Kedareswara rao wrote: > This patch series fixes below issues > --> Bugs in the driver w.r.to CANFD 2.0 IP support > --> Defer the probe if clock is not found > > Appana Durga Kedareswara rao (3): > can: xilinx_can: Fix FSR register handling in the rx path > can: xilinx_can: Fix the data updation logic for CANFD FD frames > can: xilinx_can: Fix FSR register FL and RI mask values for canfd 2.0 > > Srinivas Neeli (1): > can: xilinx_can: Fix the data phase btr1 calculation > > Venkatesh Yadav Abbarapu (1): > can: xilinx_can: defer the probe if clock is not found Please add your S-o-b to patches 4+5. As these all are bugfixes please add a reference to the commit it fixes: Fixes: commitish ("description") Marc
Hi Marc, Thanks for the review. <Snip> > On 8/12/19 9:28 AM, Appana Durga Kedareswara rao wrote: > > This patch series fixes below issues > > --> Bugs in the driver w.r.to CANFD 2.0 IP support Defer the probe if > > --> clock is not found > > > > Appana Durga Kedareswara rao (3): > > can: xilinx_can: Fix FSR register handling in the rx path > > can: xilinx_can: Fix the data updation logic for CANFD FD frames > > can: xilinx_can: Fix FSR register FL and RI mask values for canfd > > 2.0 > > > > Srinivas Neeli (1): > > can: xilinx_can: Fix the data phase btr1 calculation > > > > Venkatesh Yadav Abbarapu (1): > > can: xilinx_can: defer the probe if clock is not found > > Please add your S-o-b to patches 4+5. > > As these all are bugfixes please add a reference to the commit it fixes: > > Fixes: commitish ("description") Sure will fix in v2... Regards, Kedar. > > Marc > > -- > Pengutronix e.K. | Marc Kleine-Budde | > Industrial Linux Solutions | Phone: +49-231-2826-924 | > Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | > Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
On 8/12/19 11:05 AM, Marc Kleine-Budde wrote: > On 8/12/19 9:28 AM, Appana Durga Kedareswara rao wrote: >> This patch series fixes below issues >> --> Bugs in the driver w.r.to CANFD 2.0 IP support >> --> Defer the probe if clock is not found >> >> Appana Durga Kedareswara rao (3): >> can: xilinx_can: Fix FSR register handling in the rx path >> can: xilinx_can: Fix the data updation logic for CANFD FD frames >> can: xilinx_can: Fix FSR register FL and RI mask values for canfd 2.0 >> >> Srinivas Neeli (1): >> can: xilinx_can: Fix the data phase btr1 calculation >> >> Venkatesh Yadav Abbarapu (1): >> can: xilinx_can: defer the probe if clock is not found > > Please add your S-o-b to patches 4+5. > > As these all are bugfixes please add a reference to the commit it fixes: > > Fixes: commitish ("description") Add this to your ~/.gitconfig: [alias] lfixes = log --pretty=fixes [pretty] fixes = Fixes: %h (\"%s\") and then use $(git lfixes $commitish). Marc
On 12. 08. 19 11:10, Marc Kleine-Budde wrote: > On 8/12/19 11:05 AM, Marc Kleine-Budde wrote: >> On 8/12/19 9:28 AM, Appana Durga Kedareswara rao wrote: >>> This patch series fixes below issues >>> --> Bugs in the driver w.r.to CANFD 2.0 IP support >>> --> Defer the probe if clock is not found >>> >>> Appana Durga Kedareswara rao (3): >>> can: xilinx_can: Fix FSR register handling in the rx path >>> can: xilinx_can: Fix the data updation logic for CANFD FD frames >>> can: xilinx_can: Fix FSR register FL and RI mask values for canfd 2.0 >>> >>> Srinivas Neeli (1): >>> can: xilinx_can: Fix the data phase btr1 calculation >>> >>> Venkatesh Yadav Abbarapu (1): >>> can: xilinx_can: defer the probe if clock is not found >> >> Please add your S-o-b to patches 4+5. >> >> As these all are bugfixes please add a reference to the commit it fixes: >> >> Fixes: commitish ("description") > > Add this to your ~/.gitconfig: > > [alias] > lfixes = log --pretty=fixes > [pretty] > fixes = Fixes: %h (\"%s\") This is understandable and I have this in my .gitconfig for quite a long time. And this is just log > and then use $(git lfixes $commitish). But what do you mean by this? Are you able to add this to commit message just with sha1? Thanks, Michal
On 8/12/19 12:18 PM, Michal Simek wrote: > On 12. 08. 19 11:10, Marc Kleine-Budde wrote: >> On 8/12/19 11:05 AM, Marc Kleine-Budde wrote: >>> On 8/12/19 9:28 AM, Appana Durga Kedareswara rao wrote: >>>> This patch series fixes below issues >>>> --> Bugs in the driver w.r.to CANFD 2.0 IP support >>>> --> Defer the probe if clock is not found >>>> >>>> Appana Durga Kedareswara rao (3): >>>> can: xilinx_can: Fix FSR register handling in the rx path >>>> can: xilinx_can: Fix the data updation logic for CANFD FD frames >>>> can: xilinx_can: Fix FSR register FL and RI mask values for canfd 2.0 >>>> >>>> Srinivas Neeli (1): >>>> can: xilinx_can: Fix the data phase btr1 calculation >>>> >>>> Venkatesh Yadav Abbarapu (1): >>>> can: xilinx_can: defer the probe if clock is not found >>> >>> Please add your S-o-b to patches 4+5. >>> >>> As these all are bugfixes please add a reference to the commit it fixes: >>> >>> Fixes: commitish ("description") >> >> Add this to your ~/.gitconfig: >> >> [alias] >> lfixes = log --pretty=fixes >> [pretty] >> fixes = Fixes: %h (\"%s\") > > This is understandable and I have this in my .gitconfig for quite a long > time. And this is just log > >> and then use $(git lfixes $commitish). > > But what do you mean by this? Are you able to add this to commit message > just with sha1? First identify the commit that this patch fixes then go to the command line and enter git lfixes $committish and git will print out the line that you can copy directly to the commit message. Marc
On 12. 08. 19 12:47, Marc Kleine-Budde wrote: > On 8/12/19 12:18 PM, Michal Simek wrote: >> On 12. 08. 19 11:10, Marc Kleine-Budde wrote: >>> On 8/12/19 11:05 AM, Marc Kleine-Budde wrote: >>>> On 8/12/19 9:28 AM, Appana Durga Kedareswara rao wrote: >>>>> This patch series fixes below issues >>>>> --> Bugs in the driver w.r.to CANFD 2.0 IP support >>>>> --> Defer the probe if clock is not found >>>>> >>>>> Appana Durga Kedareswara rao (3): >>>>> can: xilinx_can: Fix FSR register handling in the rx path >>>>> can: xilinx_can: Fix the data updation logic for CANFD FD frames >>>>> can: xilinx_can: Fix FSR register FL and RI mask values for canfd 2.0 >>>>> >>>>> Srinivas Neeli (1): >>>>> can: xilinx_can: Fix the data phase btr1 calculation >>>>> >>>>> Venkatesh Yadav Abbarapu (1): >>>>> can: xilinx_can: defer the probe if clock is not found >>>> >>>> Please add your S-o-b to patches 4+5. >>>> >>>> As these all are bugfixes please add a reference to the commit it fixes: >>>> >>>> Fixes: commitish ("description") >>> >>> Add this to your ~/.gitconfig: >>> >>> [alias] >>> lfixes = log --pretty=fixes >>> [pretty] >>> fixes = Fixes: %h (\"%s\") >> >> This is understandable and I have this in my .gitconfig for quite a long >> time. And this is just log >> >>> and then use $(git lfixes $commitish). >> >> But what do you mean by this? Are you able to add this to commit message >> just with sha1? > > First identify the commit that this patch fixes then go to the command > line and enter > > git lfixes $committish > > and git will print out the line that you can copy directly to the commit > message. ok. I thought you have any nice way to directly add it to commit message without c&p. Thanks, Michal
On 8/12/19 12:57 PM, Michal Simek wrote: > On 12. 08. 19 12:47, Marc Kleine-Budde wrote: >> On 8/12/19 12:18 PM, Michal Simek wrote: >>> On 12. 08. 19 11:10, Marc Kleine-Budde wrote: >>>> On 8/12/19 11:05 AM, Marc Kleine-Budde wrote: >>>>> On 8/12/19 9:28 AM, Appana Durga Kedareswara rao wrote: >>>>>> This patch series fixes below issues >>>>>> --> Bugs in the driver w.r.to CANFD 2.0 IP support >>>>>> --> Defer the probe if clock is not found >>>>>> >>>>>> Appana Durga Kedareswara rao (3): >>>>>> can: xilinx_can: Fix FSR register handling in the rx path >>>>>> can: xilinx_can: Fix the data updation logic for CANFD FD frames >>>>>> can: xilinx_can: Fix FSR register FL and RI mask values for canfd 2.0 >>>>>> >>>>>> Srinivas Neeli (1): >>>>>> can: xilinx_can: Fix the data phase btr1 calculation >>>>>> >>>>>> Venkatesh Yadav Abbarapu (1): >>>>>> can: xilinx_can: defer the probe if clock is not found >>>>> >>>>> Please add your S-o-b to patches 4+5. >>>>> >>>>> As these all are bugfixes please add a reference to the commit it fixes: >>>>> >>>>> Fixes: commitish ("description") >>>> >>>> Add this to your ~/.gitconfig: >>>> >>>> [alias] >>>> lfixes = log --pretty=fixes >>>> [pretty] >>>> fixes = Fixes: %h (\"%s\") >>> >>> This is understandable and I have this in my .gitconfig for quite a long >>> time. And this is just log >>> >>>> and then use $(git lfixes $commitish). >>> >>> But what do you mean by this? Are you able to add this to commit message >>> just with sha1? >> >> First identify the commit that this patch fixes then go to the command >> line and enter >> >> git lfixes $committish >> >> and git will print out the line that you can copy directly to the commit >> message. > > ok. I thought you have any nice way to directly add it to commit message > without c&p. You can insert the output from a console command in vim by adding a "!" in front of it in the command mode. Marc
On 12. 08. 19 12:59, Marc Kleine-Budde wrote: > On 8/12/19 12:57 PM, Michal Simek wrote: >> On 12. 08. 19 12:47, Marc Kleine-Budde wrote: >>> On 8/12/19 12:18 PM, Michal Simek wrote: >>>> On 12. 08. 19 11:10, Marc Kleine-Budde wrote: >>>>> On 8/12/19 11:05 AM, Marc Kleine-Budde wrote: >>>>>> On 8/12/19 9:28 AM, Appana Durga Kedareswara rao wrote: >>>>>>> This patch series fixes below issues >>>>>>> --> Bugs in the driver w.r.to CANFD 2.0 IP support >>>>>>> --> Defer the probe if clock is not found >>>>>>> >>>>>>> Appana Durga Kedareswara rao (3): >>>>>>> can: xilinx_can: Fix FSR register handling in the rx path >>>>>>> can: xilinx_can: Fix the data updation logic for CANFD FD frames >>>>>>> can: xilinx_can: Fix FSR register FL and RI mask values for canfd 2.0 >>>>>>> >>>>>>> Srinivas Neeli (1): >>>>>>> can: xilinx_can: Fix the data phase btr1 calculation >>>>>>> >>>>>>> Venkatesh Yadav Abbarapu (1): >>>>>>> can: xilinx_can: defer the probe if clock is not found >>>>>> >>>>>> Please add your S-o-b to patches 4+5. >>>>>> >>>>>> As these all are bugfixes please add a reference to the commit it fixes: >>>>>> >>>>>> Fixes: commitish ("description") >>>>> >>>>> Add this to your ~/.gitconfig: >>>>> >>>>> [alias] >>>>> lfixes = log --pretty=fixes >>>>> [pretty] >>>>> fixes = Fixes: %h (\"%s\") >>>> >>>> This is understandable and I have this in my .gitconfig for quite a long >>>> time. And this is just log >>>> >>>>> and then use $(git lfixes $commitish). >>>> >>>> But what do you mean by this? Are you able to add this to commit message >>>> just with sha1? >>> >>> First identify the commit that this patch fixes then go to the command >>> line and enter >>> >>> git lfixes $committish >>> >>> and git will print out the line that you can copy directly to the commit >>> message. >> >> ok. I thought you have any nice way to directly add it to commit message >> without c&p. > > You can insert the output from a console command in vim by adding a "!" > in front of it in the command mode. ok. M