Message ID | 1581942793-19468-1-git-send-email-srinivas.neeli@xilinx.com (mailing list archive) |
---|---|
Headers | show |
Series | gpio: zynq: Update on gpio-zynq driver | expand |
pon., 17 lut 2020 o 13:33 Srinivas Neeli <srinivas.neeli@xilinx.com> napisaĆ(a): > > This patch series does the following: > -protect direction in/out with a spinlock > -Add binding for Versal gpio > -Add binding for pmc gpio node > -Add Versal support > -Disable the irq if it is not a wakeup source > -Add pmc gpio support > -Remove error prints in EPROBE_DEFER > > --- > Changes in V2: > - In previous series [PATCH 1/8] already applied on "linux-next". > - Fixed checkpatch warning for spinlock description. > - Added description for Versal PS_GPIO and PMC_GPIO. > Changes in V3: > - Updated commit description for PATCH 4 and 6. > --- > > Glenn Langedock (1): > gpio: zynq: protect direction in/out with a spinlock > > Shubhrajyoti Datta (6): > dt-bindings: gpio: Add binding for Versal gpio > devicetree-binding: Add pmc gpio node > gpio: zynq: Add Versal support > gpio: zynq: Disable the irq if it is not a wakeup source > gpio: zynq: Add pmc gpio support > gpio: zynq: Remove error prints in EPROBE_DEFER > > .../devicetree/bindings/gpio/gpio-zynq.txt | 4 +- > drivers/gpio/gpio-zynq.c | 66 +++++++++++++++++++++- > 2 files changed, 67 insertions(+), 3 deletions(-) > > -- > 2.7.4 > Other than the commit messages, the series looks good to me. Bart
On Mon, Feb 17, 2020 at 1:33 PM Srinivas Neeli <srinivas.neeli@xilinx.com> wrote: > This patch series does the following: > -protect direction in/out with a spinlock > -Add binding for Versal gpio > -Add binding for pmc gpio node > -Add Versal support > -Disable the irq if it is not a wakeup source > -Add pmc gpio support > -Remove error prints in EPROBE_DEFER > > --- > Changes in V2: > - In previous series [PATCH 1/8] already applied on "linux-next". > - Fixed checkpatch warning for spinlock description. > - Added description for Versal PS_GPIO and PMC_GPIO. > Changes in V3: > - Updated commit description for PATCH 4 and 6. I agree with Bartosz, this looks really good. If you fix the remaining commit messages and post a v4 we can apply this series. Yours, Linus Walleij