From patchwork Thu Jul 2 14:52:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Tomer X-Patchwork-Id: 11639235 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C7252618 for ; Thu, 2 Jul 2020 15:03:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9FCC520737 for ; Thu, 2 Jul 2020 15:03:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="T0GrdwQc"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Kka9ippd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9FCC520737 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Owner; bh=48YulfDyqX/j6UbX20Rrvp0pmijp0HW61TnRgrEuP3k=; b=T0GrdwQcDIgI15rvKvDOvLgXRG npKphxV6AjziNYWCvS9H4h0hN0JUXeGVs+6y4jJxY3qN5f5XQ/UNEFuAslYYR8Kr3Ww4g0bIgxTik S//TRP7WpJgMMWkmiopGTrGjvEwSIByCLogsvizppgy+UxRV35W1aQYUsrsskQCBjz70RwfwhUg2r RIF8nBYToW4ziYNpcPgSZbmFBh2dwFWi/tDE4CFEZvyKrXdIrDtVEiFoZl1as1Tb3IOEDN3yvvkaB 2X5WjxmAMRm4jXFKeEU2nqnjHTPqzAItmH9WCrIm360strIscr2IoqU3r17b84lYAbSWL3qc6n4Ni Wd14PF2g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jr0iB-00051H-BT; Thu, 02 Jul 2020 15:01:15 +0000 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jr0ab-0000tW-Vd; Thu, 02 Jul 2020 14:53:27 +0000 Received: by mail-pg1-x542.google.com with SMTP id e18so13581920pgn.7; Thu, 02 Jul 2020 07:53:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=jduNTiFSbkv+vQW84HoH9SAD82c2w+L8CXfoz21/kIo=; b=Kka9ippdZc0/ARjWtd60u5Ikf+rq3IlFTWVbj6FqiuRgg8KO7xMpaYNEMvvvwbCinB 1MiEgGnb2SFaYXEZ/jfVMz/J69lu9r7gjCwqfEPbuVu168Zk+VA3BewlFdqpdD93r8v6 9r60Tcn8FLQD1ocRdAPuc6XyHw1sYWSEuufTm5k/PrTW38ihL2lXjUZDYq18j94MJfgF VuN3BPTTlqnyaN6ABSJPsfLWT7Ap1T+ZaYXhhNeQZNQylZ8wXyVjKuCHBrsxRDG9hpsg 9Zs/ZDGjyItS4jRcrIjOSfv36OCEz+GmG8D86A6swC8rhSd13EYUOvyulPh+rXD4XT1R 9jWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=jduNTiFSbkv+vQW84HoH9SAD82c2w+L8CXfoz21/kIo=; b=lGp0nGXC6kdtiXdAiha2G7X42OixwIBgAwN2lr65ubmPcrb5GDuZ8Ur8sGenaN2q2e 8t+obgs+UzZx/ERbCk+PJHSsWWgvwmnGRmxvo0MjQU4Nz5yicTqiIyuYS9kVMKOJtFFx FfiOJaFOuLDdqb5lPVrzFp+t8cuwM1BsOiR/0ZjvOs6PYY0yl2GgmZZMLWm1XVHFm4d8 +t7pz2btDSaI+2op7fYasqr54VGLXSDcKJ56qIUUOjMYjsmG5+03bwjQdgD5XGnWLQ4X DAv2yXTNI6bbN/E7SuiI4vrgOSddzgFyTtobHkzwnsI4zorQonJ+XrgxEhdxbSFOuO/Y k/yA== X-Gm-Message-State: AOAM531QGZKJkPYqrsq1uk+Xf6g6HILvnN1YeVecM8vw6SOdOKwLUZN3 FOZUp8OwHZXl6KShEFfu6WI= X-Google-Smtp-Source: ABdhPJw7etrvCbjPiOKqTi64NX74F0Xn18vwqFCpDkAAUiZ6jA+q6lN/094raTuFQUNRLyYXH9wAug== X-Received: by 2002:a63:f316:: with SMTP id l22mr23946969pgh.291.1593701599347; Thu, 02 Jul 2020 07:53:19 -0700 (PDT) Received: from localhost.localdomain ([223.190.0.253]) by smtp.gmail.com with ESMTPSA id 204sm9487891pfc.18.2020.07.02.07.53.12 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 Jul 2020 07:53:18 -0700 (PDT) From: Amit Singh Tomar To: andre.przywara@arm.com, afaerber@suse.de, manivannan.sadhasivam@linaro.org, vkoul@kernel.org, sboyd@kernel.org, robh+dt@kernel.org Subject: [PATCH v5 00/10] Add MMC and DMA support for Actions S700 Date: Thu, 2 Jul 2020 20:22:46 +0530 Message-Id: <1593701576-28580-1-git-send-email-amittomer25@gmail.com> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200702_105326_219643_77E27FCA X-CRM114-Status: GOOD ( 25.31 ) X-Spam-Score: 0.1 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:542 listed in] [list.dnswl.org] 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit [amittomer25[at]gmail.com] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [amittomer25[at]gmail.com] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dan.j.williams@intel.com, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, cristian.ciocaltea@gmail.com MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org This Series(v5) addressed the review comments provided by Vinod, and patch 05/10 is moved to 01/10 so that documentation patch comes before driver. Apart from it, changes are made in patch 03/10(earlier it was 02/10) to replace of_match_device() with of_device_get_match_data() and removed uintptr_t from type-cast. This Series is rebased on top of 5.8.0-rc3. --------------------------------------------------------------------- Series(v4) addressed the review comments provided by Mani, and there are changes in patch 1/10, 2/10 and 6/10 for it. For first couple of patches , old comments are preserved and more details about how DMA descriptors fields are programmed is added. Apart from it, Typo is fixed patch 6/10 and placed the header file in alphabetical order. Also, this series fixes one compilation warning (reported by Kbuild) introduced by patch 2/10 using clang compiler. ------------------------------------------------------------------------ Series(v3) addressed the review comments provided by Rob, and there are changes in patch 5/10 for it. Also, one of the important change for this series(v3) is about the way we we handle address range conflict between pinctrl and sps node. In the last Series(v2), patch 4/10 was sent as *do not merge* but while discussing about some proper solution for it, we have come up with idea of limiting pinctrl address range(to 0x100) to avoid this conflict. This is safe to do as current pinctrl driver uses address range only up to 0x100 (even less than that?), and this would let sps to work properly. Since sps block is now enabled , we have to provide power-domain bit for dma to work properly and patch 6/10 has that change now. Looking forward have some comments for this series. --------------------------------------------------------------------------- Series(v2) addressed the review comments provided by Andre, and there are changes in patch 1/10, 2/10, 5/10 and 9/10. * Accessor function (to get the frame lenght) has moved from patch 2/9 to patch 1/9 with inline removed. * Removed the unnecessary line break. * Added comments about the way DMA descriptor differs between S700 and S900. * Added a macro to define fcnt value. * Updated dma DT bindings. * Used SoC secific compatible string for MMC. Apart from it, a new patch 8/10 is added in this series to update mmc DT bindings. Series is rebased on 5.7.0-rc6. ----------------------------------------------------------------------------- Series(v1) have following changes from the previous series. New patch(5/8) has been introduced that converts dma dt-binding for Actions OWL SoC from text format to yaml file. For patch(2/8) new accessor function is added to get the frame lenght which is common to both S900 and S700. Apart from it SoC check is removed from irq routine as it is not needed. Patch(4/8) which is an hack to prove our DMA and MMC works for S700 is now sent as *do not merge* patch. DMA is tested using dmatest with follwoing result: root@ubuntu:~# echo dma0chan1 > /sys/module/dmatest/parameters/channel root@ubuntu:~# echo 2000 > /sys/module/dmatest/parameters/timeout root@ubuntu:~# echo 1 > /sys/module/dmatest/parameters/iterations root@ubuntu:~# echo 1 > /sys/module/dmatest/parameters/run root@ubuntu:~# dmesg | tail [ 303.362586] dmatest: Added 1 threads using dma0chan1 [ 317.258658] dmatest: Started 1 threads using dma0chan1 [ 317.259397] dmatest: dma0chan1-copy0: summary 1 tests, 0 failures 16129.03 iops 32258 KB/s (0) ------------------------------------------------------------------------------- The intention of RFC series is to enable uSD and DMA support for Cubieboard7 based on Actions S700 SoC, and on the way we found that it requires changes in dmaengine present on S700 as its different from what is present on S900. Patch(1/8) does provide a new way to describe DMA descriptor, idea is to remove the bit-fields as its less maintainable. It is only build tested and it would be great if this can be tested on S900 based hardware. Patch(2/8) adds S700 DMA engine support, there is new compatible string added for it, which means a changed bindings needed to submitted for this. I would plan to send it later the converted "owl-dma.yaml". Patch(4/8) disables the sps node as its memory range is conflicting pinctrl node and results in pinctrl proble failure. Rest of patches in the series adds DMA/MMC nodes for S700 alone with binding constants and enables the uSD for Cubieboard7. This whole series is tested, by building/compiling Kernel on Cubieboard7-lite which was *almost* successful (OOM kicked in, while Linking due to less RAM present on hardware). Following is the mmc speed : ubuntu@ubuntu:~$ sudo hdparm -tT /dev/mmcblk0 /dev/mmcblk0: Timing cached reads: 1310 MB in 2.00 seconds = 655.15 MB/sec Timing buffered disk reads: 62 MB in 3.05 seconds = 20.30 MB/sec Amit Singh Tomar (10): dt-bindings: dmaengine: convert Actions Semi Owl SoCs bindings to yaml dmaengine: Actions: get rid of bit fields from dma descriptor dmaengine: Actions: Add support for S700 DMA engine clk: actions: Add MMC clock-register reset bits arm64: dts: actions: limit address range for pinctrl node arm64: dts: actions: Add DMA Controller for S700 dt-bindings: reset: s700: Add binding constants for mmc dt-bindings: mmc: owl: add compatible string actions,s700-mmc arm64: dts: actions: Add MMC controller support for S700 arm64: dts: actions: Add uSD support for Cubieboard7 Documentation/devicetree/bindings/dma/owl-dma.txt | 47 ------- Documentation/devicetree/bindings/dma/owl-dma.yaml | 79 ++++++++++++ Documentation/devicetree/bindings/mmc/owl-mmc.yaml | 6 +- arch/arm64/boot/dts/actions/s700-cubieboard7.dts | 41 ++++++ arch/arm64/boot/dts/actions/s700.dtsi | 51 +++++++- drivers/clk/actions/owl-s700.c | 3 + drivers/dma/owl-dma.c | 139 +++++++++++++-------- include/dt-bindings/reset/actions,s700-reset.h | 3 + 8 files changed, 271 insertions(+), 98 deletions(-) delete mode 100644 Documentation/devicetree/bindings/dma/owl-dma.txt create mode 100644 Documentation/devicetree/bindings/dma/owl-dma.yaml