From patchwork Thu Sep 3 12:05:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sumit Garg X-Patchwork-Id: 11753465 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 98FEE739 for ; Thu, 3 Sep 2020 12:07:18 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6E37F2072A for ; Thu, 3 Sep 2020 12:07:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="3Sic2zzm"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DvbGunJ3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E37F2072A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Owner; bh=N0M5TgzzSaw7QMmoNfAlY3bWmpQXaZQnFcarDl3nycI=; b=3Sic2zzmG1BXBC9M4gedlS1HbV SpwR9I0ExmOaOu3V/bAmpeu2cK2qquqcUwv+3hSmhLz69FHguCpykPGoBxUZyWrok+j1pujUGbO2v B7ZfpLzI/xjMKt9K47I2mn9kxH63vAJS5xrAR2+wtHdjMLywkmon2y0Fotovxrh1BS+2ZuEBO9sDa o8sikvh5nfAU7Pwk51hfJ5vWkf+pA8PpJ5ard5KCjgLQ5RK3Slun7tSSlFJXF871FGFbxn3B/kVU+ 0ZmVHwivOrFs5+/WEC+JuFH4WhadRQHqpB4eypLGr+6HWkz/GKZP8ajWnprvvfpdT6OGir6nKJdDE XYwfnxNg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDnzv-000298-I1; Thu, 03 Sep 2020 12:05:47 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDnzs-00028W-Ij for linux-arm-kernel@lists.infradead.org; Thu, 03 Sep 2020 12:05:45 +0000 Received: by mail-pf1-x441.google.com with SMTP id f18so2150128pfa.10 for ; Thu, 03 Sep 2020 05:05:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=FOLTzf/XO+P7QNOPhKxlSTfK9nSZlqcSxLohkx+kXno=; b=DvbGunJ3jVOhcpKidYgRLJomJssy0XrlfofrGt6ER9y6uEGB5CxvcxQ7m3YR7QmKzZ QHIleoxPUlkjZdjZHbbbWX85vS/A1jf8BglOTY5mxEskkB4Bjv9u5nv0/f+Fi86k27KQ ORkzIn9/NrlgdBdWzPUW4YGq8RQWVetEnkBGzDmjp/yXneZDAiR2ThMO91x3Kxo6+Q34 ifFRwkmJa+7I16clQHdtc5GebdYH26Htu4SmECb1T1+QqINFKHYkIac1N7SzFgPql65t xnezWLYtG4rFo0nv0Nv1YD+PeGg42adBXMjErE6/A99Oo8art6QEoTmUId2MrXpyKxEf EDIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=FOLTzf/XO+P7QNOPhKxlSTfK9nSZlqcSxLohkx+kXno=; b=ScpDPMSlWx/0rZlPyEL2Xew+vOKqkJ0C4BmKQYXlLtCGRgI4nvHoRX0chTtgsExbvO RXQ+6pl/giwBMuNpKmlAsyIyqxaOnwjGkMtd9gdXffzfCR8L9ige0jpTwP9EtJ4hmJUF 92+hEGv4lvwESwLJylS8nHWe7D3PyhWcqproadUGBj54IG3KecQQRQo/7qpiGRdeh4VM 4aJBw3rjpp1B7M4a06wnSYQ/H13B9walQFTdQP8ipZHCYI27ayZQ8wlLTXa0SCZ7qVI5 UxIS/7kaMUNMupHNzEZ/HmbGm60Z/ABbM5ArKN1wQNH3RwqiffU3EZlzI8DRJgao1VSA Yn6Q== X-Gm-Message-State: AOAM530nwouTYgXMxPPbatz9BUMDzJy75hW7QXSaGDeQ7JZePbjOHNe9 xU0vYgW4M360yexVocO3R9HlvQ== X-Google-Smtp-Source: ABdhPJx69wueSgaulyBljwP5X2r7+JVhzDLt3bpKRIsvkt68un6f73FkRk63fK9P/WX/0/tFU0EDQA== X-Received: by 2002:a62:cf04:: with SMTP id b4mr3500815pfg.84.1599134740520; Thu, 03 Sep 2020 05:05:40 -0700 (PDT) Received: from localhost.localdomain ([117.210.209.248]) by smtp.gmail.com with ESMTPSA id s1sm2922022pgh.47.2020.09.03.05.05.33 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 03 Sep 2020 05:05:39 -0700 (PDT) From: Sumit Garg To: maz@kernel.org, catalin.marinas@arm.com, will@kernel.org Subject: [PATCH v3 0/4] arm64: Introduce new IPI as IPI_CALL_NMI_FUNC Date: Thu, 3 Sep 2020 17:35:08 +0530 Message-Id: <1599134712-30923-1-git-send-email-sumit.garg@linaro.org> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200903_080544_722744_D78DE73C X-CRM114-Status: GOOD ( 14.52 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:441 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sumit Garg , daniel.thompson@linaro.org, jason@lakedaemon.net, kgdb-bugreport@lists.sourceforge.net, dianders@chromium.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jason.wessel@windriver.com, tglx@linutronix.de, julien.thierry.kdev@gmail.com MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org With pseudo NMIs support available its possible to configure SGIs to be triggered as pseudo NMIs running in NMI context. And kernel features such as kgdb relies on NMI support to round up CPUs which are stuck in hard lockup state with interrupts disabled. This patch-set adds support for IPI_CALL_NMI_FUNC which can be triggered as a pseudo NMI which in turn is leveraged via kgdb to round up CPUs. After this patch-set we should be able to get a backtrace for a CPU stuck in HARDLOCKUP. Have a look at an example below from a testcase run on Developerbox: $ echo HARDLOCKUP > /sys/kernel/debug/provoke-crash/DIRECT # Enter kdb via Magic SysRq [11]kdb> btc btc: cpu status: Currently on cpu 10 Available cpus: 0-7(I), 8, 9(I), 10, 11-23(I) Stack traceback for pid 619 0xffff000871bc9c00 619 618 1 8 R 0xffff000871bca5c0 bash CPU: 8 PID: 619 Comm: bash Not tainted 5.7.0-rc6-00762-g3804420 #77 Hardware name: Socionext SynQuacer E-series DeveloperBox, BIOS build #73 Apr 6 2020 Call trace: dump_backtrace+0x0/0x198 show_stack+0x18/0x28 dump_stack+0xb8/0x100 kgdb_cpu_enter+0x5c0/0x5f8 kgdb_nmicallback+0xa0/0xa8 ipi_kgdb_nmicallback+0x24/0x30 ipi_handler+0x160/0x1b8 handle_percpu_devid_fasteoi_ipi+0x44/0x58 generic_handle_irq+0x30/0x48 handle_domain_nmi+0x44/0x80 gic_handle_irq+0x140/0x2a0 el1_irq+0xcc/0x180 lkdtm_HARDLOCKUP+0x10/0x18 direct_entry+0x124/0x1c0 full_proxy_write+0x60/0xb0 __vfs_write+0x1c/0x48 vfs_write+0xe4/0x1d0 ksys_write+0x6c/0xf8 __arm64_sys_write+0x1c/0x28 el0_svc_common.constprop.0+0x74/0x1f0 do_el0_svc+0x24/0x90 el0_sync_handler+0x178/0x2b8 el0_sync+0x158/0x180 Changes in v3: - Rebased to Marc's latest IPIs patch-set [1]. [1] https://lkml.org/lkml/2020/9/1/603 Changes since RFC version [1]: - Switch to use generic interrupt framework to turn an IPI as NMI. - Dependent on Marc's patch-set [2] which turns IPIs into normal interrupts. - Addressed misc. comments from Doug on patch #4. - Posted kgdb NMI printk() fixup separately which has evolved since to be solved using different approach via changing kgdb interception of printk() in common printk() code (see patch [3]). [1] https://lkml.org/lkml/2020/4/24/328 [2] https://lkml.org/lkml/2020/5/19/710 [3] https://lkml.org/lkml/2020/5/20/418 Sumit Garg (4): arm64: smp: Introduce a new IPI as IPI_CALL_NMI_FUNC irqchip/gic-v3: Enable support for SGIs to act as NMIs arm64: smp: Setup IPI_CALL_NMI_FUNC as a pseudo NMI arm64: kgdb: Round up cpus using IPI_CALL_NMI_FUNC arch/arm64/include/asm/kgdb.h | 8 +++++++ arch/arm64/include/asm/smp.h | 1 + arch/arm64/kernel/kgdb.c | 21 ++++++++++++++++++ arch/arm64/kernel/smp.c | 50 ++++++++++++++++++++++++++++++++++--------- drivers/irqchip/irq-gic-v3.c | 13 +++++++++-- 5 files changed, 81 insertions(+), 12 deletions(-)