From patchwork Wed Feb 16 06:20:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hongxing Zhu X-Patchwork-Id: 12747992 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25103C433EF for ; Wed, 16 Feb 2022 06:54:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:Cc:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=3y3LgpRWcxafC++V+e+nY9Xo0Xj/3v0jbH4NUmvGCvU=; b=dTaoAPSBws/m5y fj1zaim05I2M3YNLFY+PS0zBQjMQgVDvkrxyZ0kTUd+Y3XfF1ObJwSt/+MAtE7yPeYis1Vnkxq3Gp 5VmXJePv1KJlzCPqpWOUHDYDmDlYQKrfZiLrMTmEccnNDJ4rFFPiZqwDTUDh6cK075N/qrxPgnaR+ i+3P0JvUwj8mSjW3eDuAzuDezfHcbbydk6/MAOCEy81Bavr7Cfh5MOXwdgd4a8Qlqpwo5dFma01Mz w/C2JXZQSBBb/tSrkL95RDO7BJmQFQevjA7okxdNgfYCoLMrApmDC5kxzLVmacxocLUdi9R0D7i6B ME3/RHsH8Sz6/ZeI5bFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nKEBM-005j1Y-Tb; Wed, 16 Feb 2022 06:52:57 +0000 Received: from inva021.nxp.com ([92.121.34.21]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nKEBJ-005j05-CE for linux-arm-kernel@lists.infradead.org; Wed, 16 Feb 2022 06:52:55 +0000 Received: from inva021.nxp.com (localhost [127.0.0.1]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 2170620024C; Wed, 16 Feb 2022 07:52:50 +0100 (CET) Received: from aprdc01srsp001v.ap-rdc01.nxp.com (aprdc01srsp001v.ap-rdc01.nxp.com [165.114.16.16]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id DC4F0200200; Wed, 16 Feb 2022 07:52:49 +0100 (CET) Received: from localhost.localdomain (shlinux2.ap.freescale.net [10.192.224.44]) by aprdc01srsp001v.ap-rdc01.nxp.com (Postfix) with ESMTP id 997CE183F0C5; Wed, 16 Feb 2022 14:52:48 +0800 (+08) From: Richard Zhu To: l.stach@pengutronix.de, bhelgaas@google.com, broonie@kernel.org, lorenzo.pieralisi@arm.com, jingoohan1@gmail.com, festevam@gmail.com, francesco.dolcini@toradex.com Cc: hongxing.zhu@nxp.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, linux-imx@nxp.com Subject: [PATCH v7 0/8] PCI: imx6: refine codes and add compliance tests mode support Date: Wed, 16 Feb 2022 14:20:55 +0800 Message-Id: <1644992463-14467-1-git-send-email-hongxing.zhu@nxp.com> X-Mailer: git-send-email 2.7.4 X-Virus-Scanned: ClamAV using ClamSMTP X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220215_225253_744576_EE33B1E0 X-CRM114-Status: GOOD ( 13.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This series patches refine pci-imx6 driver and do the following changes. - Encapsulate the clock enable into one standalone function - Add the error propagation from host_init - Balance the usage of the regulator and clocks when link never came up - Add the compliance tests mode support Main changes from v6 to v7: - Keep the regulator usage counter balance in the #5 patch Main changes from v5 to v6: - Refer to the following discussion with Fabio, fix the dump by his patch. https://patchwork.kernel.org/project/linux-pci/patch/1641368602-20401-6-git-send-email-hongxing.zhu@nxp.com/ Refine and rebase this patch-set after Fabio' dump fix patch is merged. - Add one new #4 patch to disable i.MX6QDL REF clock too when disable clocks - Split the regulator refine codes into one standalone patch #5 in this version. Main changes from v4 to v5: - Since i.MX8MM PCIe support had been merged. Based on Lorenzo's git repos, resend the patch-set after rebase. Main changes from v3 to v4: - Regarding Mark's comments, delete the regulator_is_enabled() check. - Squash #3 and #6 of v3 patch into #5 patch of v4 set. Main changes from v2 to v3: - Add "Reviewed-by: Lucas Stach " tag into first two patches. - Add a Fixes tag into #3 patch. - Split the #4 of v2 to two patches, one is clock disable codes move, the other one is the acutal clock unbalance fix. - Add a new host_exit() callback into dw_pcie_host_ops, then it could be invoked to handle the unbalance issue in the error handling after host_init() function when link is down. - Add a new host_exit() callback for i.MX PCIe driver to handle this case in the error handling after host_init. Main changes from v1 to v2: Regarding Lucas' comments. - Move the placement of the new imx6_pcie_clk_enable() to avoid the forward declarition. - Seperate the second patch of v1 patch-set to three patches. - Use the module_param to replace the kernel command line. Regarding Bjorn's comments: - Use the cover-letter for a multi-patch series. - Correct the subject line, and refine the commit logs. For example, remove the timestamp of the logs. drivers/pci/controller/dwc/pci-imx6.c | 218 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------------------- drivers/pci/controller/dwc/pcie-designware-host.c | 5 ++- drivers/pci/controller/dwc/pcie-designware.h | 1 + 3 files changed, 147 insertions(+), 77 deletions(-) [PATCH v7 1/8] PCI: imx6: Encapsulate the clock enable into one [PATCH v7 2/8] PCI: imx6: Add the error propagation from host_init [PATCH v7 3/8] PCI: imx6: Move imx6_pcie_clk_disable() earlier [PATCH v7 4/8] PCI: imx6: Disable iMX6QDL PCIe REF clock when disable [PATCH v7 5/8] PCI: imx6: Refine the regulator usage [PATCH v7 6/8] PCI: dwc: Add dw_pcie_host_ops.host_exit() callback [PATCH v7 7/8] PCI: imx6: Disable enabled clocks and regulators after [PATCH v7 8/8] PCI: imx6: Add the compliance tests mode support