| Message ID | 20180820085445.14632-1-ludovic.desroches@microchip.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | atmel-mci and maybe android-goldfish broken on 4.18 | expand |
On 20 August 2018 at 10:54, Ludovic Desroches <ludovic.desroches@microchip.com> wrote: > Hi, > > Dougas Gilbert noticed that atmel-mci was broken with the 4.18 release. > He found the culprit commit which is 5b4277814e3fd > ("[PATCH 2/7] mmc: atmel-mci: use sg_copy_{from,to}_buffer"). The from/to > logic was inverted: sg_copy_to_buffer copies from an SG list to a linear > buffer so it can't replace a memcpy where the destination is the virtual > address of an SG buffer. > > This patch was part of "make more host drivers highmem safe v2". It seems > there is the same logical error within the android-goldfish driver but I > couldn't check it on real hardware. > > Ludovic Desroches (2): > mmc: atmel-mci: fix bad logic of sg_copy_{from,to}_buffer conversion > mmc: android-goldfish: fix bad logic of sg_copy_{from,to}_buffer > conversion > > drivers/mmc/host/android-goldfish.c | 4 ++-- > drivers/mmc/host/atmel-mci.c | 12 ++++++------ > 2 files changed, 8 insertions(+), 8 deletions(-) > Thanks, applied for fixes! Kind regards Uffe
Hi, Dougas Gilbert noticed that atmel-mci was broken with the 4.18 release. He found the culprit commit which is 5b4277814e3fd ("[PATCH 2/7] mmc: atmel-mci: use sg_copy_{from,to}_buffer"). The from/to logic was inverted: sg_copy_to_buffer copies from an SG list to a linear buffer so it can't replace a memcpy where the destination is the virtual address of an SG buffer. This patch was part of "make more host drivers highmem safe v2". It seems there is the same logical error within the android-goldfish driver but I couldn't check it on real hardware. Ludovic Desroches (2): mmc: atmel-mci: fix bad logic of sg_copy_{from,to}_buffer conversion mmc: android-goldfish: fix bad logic of sg_copy_{from,to}_buffer conversion drivers/mmc/host/android-goldfish.c | 4 ++-- drivers/mmc/host/atmel-mci.c | 12 ++++++------ 2 files changed, 8 insertions(+), 8 deletions(-)