From patchwork Mon Aug 20 08:54:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ludovic Desroches X-Patchwork-Id: 10570011 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9E4CB109C for ; Mon, 20 Aug 2018 08:59:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8C2F428E26 for ; Mon, 20 Aug 2018 08:59:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7FF7E28E2E; Mon, 20 Aug 2018 08:59:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 3E8DC28E26 for ; Mon, 20 Aug 2018 08:59:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=v02r+MCBkEFiMGAVJR8PyP8DEijCtRoMl7nd0stYBU0=; b=b4sWfs8zyt904W jCSjunykvxegyknRDu6zRuxJQI0FzzRsMMyDiAaOy/Og2MfNas16Gms7jG4RAqWlCuu8wICb5KZPw eJuYcKNgo2fK5bQW1xFDto7qDDLCE/mNhd2mubRB0LUmUPilxIcljZfRW5dfoetoUUxtOh+MuyOwL zCMZ/i6dpxwMw3O5NhSbQl1sNJXLFa0CPxyauNI9kf0aMBLzJ6eAlAQy4xcjHYSKKMsJlcIuipotl jrIgGcPCKjpRalTFyt+Z3yCvv0gIX30qfWBFLpJzXY0AqA6lxS7R7m2d1to2i8vIlnoUlZi/lgY20 PG+gdKRzknXng82x2XTg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1frg1f-0002L7-De; Mon, 20 Aug 2018 08:59:03 +0000 Received: from esa4.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1frg1d-0002IF-2U for linux-arm-kernel@lists.infradead.org; Mon, 20 Aug 2018 08:59:02 +0000 X-IronPort-AV: E=Sophos;i="5.53,264,1531810800"; d="scan'208";a="18003594" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa4.microchip.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 20 Aug 2018 01:58:49 -0700 Received: from ibiza.rfo.atmel.com (10.10.76.4) by chn-sv-exch04.mchp-main.com (10.10.76.105) with Microsoft SMTP Server id 14.3.352.0; Mon, 20 Aug 2018 01:58:44 -0700 From: Ludovic Desroches To: , Subject: [PATCH 0/2] atmel-mci and maybe android-goldfish broken on 4.18 Date: Mon, 20 Aug 2018 10:54:43 +0200 Message-ID: <20180820085445.14632-1-ludovic.desroches@microchip.com> X-Mailer: git-send-email 2.12.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180820_015901_147564_E85C0A35 X-CRM114-Status: UNSURE ( 9.12 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ulf.hansson@linaro.org, alexandre.belloni@bootlin.com, linux-kernel@vger.kernel.org, Ludovic Desroches , dgilbert@interlog.com Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Hi, Dougas Gilbert noticed that atmel-mci was broken with the 4.18 release. He found the culprit commit which is 5b4277814e3fd ("[PATCH 2/7] mmc: atmel-mci: use sg_copy_{from,to}_buffer"). The from/to logic was inverted: sg_copy_to_buffer copies from an SG list to a linear buffer so it can't replace a memcpy where the destination is the virtual address of an SG buffer. This patch was part of "make more host drivers highmem safe v2". It seems there is the same logical error within the android-goldfish driver but I couldn't check it on real hardware. Ludovic Desroches (2): mmc: atmel-mci: fix bad logic of sg_copy_{from,to}_buffer conversion mmc: android-goldfish: fix bad logic of sg_copy_{from,to}_buffer conversion drivers/mmc/host/android-goldfish.c | 4 ++-- drivers/mmc/host/atmel-mci.c | 12 ++++++------ 2 files changed, 8 insertions(+), 8 deletions(-)